From e5a5d2de7c5ff5d37fb412f423d3c63ac3c454b8 Mon Sep 17 00:00:00 2001 From: t0ng7u Date: Sat, 6 Sep 2025 21:57:26 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20fix(models):=20export=20setActiv?= =?UTF-8?q?ePage=20to=20prevent=20tab-change=20TypeError?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Context: Clicking a vendor tab triggered “setActivePage is not a function” from ModelsTabs.jsx:43. Root cause: ModelsTabs expects `setActivePage` via props (spread from `useModelsData`), but the hook did not expose it in its return object, so the prop resolved to `undefined`. Fix: Export `setActivePage` from `useModelsData`’s return object so `ModelsTabs` receives a valid function. Result: Tab switching now correctly resets pagination to page 1 and reloads models without runtime errors. Files: - web/src/hooks/models/useModelsData.jsx Test plan: - Open the Models page - Click different vendor tabs - Verify no crash occurs and the list reloads with page reset to 1 Refs: web/src/components/table/models/ModelsTabs.jsx:43 --- web/src/hooks/models/useModelsData.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/web/src/hooks/models/useModelsData.jsx b/web/src/hooks/models/useModelsData.jsx index 57b4bea3d..b1bd8b65d 100644 --- a/web/src/hooks/models/useModelsData.jsx +++ b/web/src/hooks/models/useModelsData.jsx @@ -462,6 +462,7 @@ export const useModelsData = () => { copyText, // Pagination + setActivePage, handlePageChange, handlePageSizeChange,