github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 19:28:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): dedupe temp root setup in identity avatar e2e

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-21 19:00:25 +00:00
parent 9ead79937e
commit 0401762144
1 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/agents/identity-avatar.e2e.test.ts
View File

@@ -1,7 +1,7 @@
import fs from "node:fs/promises"; import fs from "node:fs/promises";
import os from "node:os"; import os from "node:os";
import path from "node:path"; import path from "node:path";
import { describe, expect, it } from "vitest"; import { afterEach, describe, expect, it } from "vitest";
import type { OpenClawConfig } from "../config/config.js"; import type { OpenClawConfig } from "../config/config.js";
import { resolveAgentAvatar } from "./identity-avatar.js"; import { resolveAgentAvatar } from "./identity-avatar.js";
@@ -24,9 +24,25 @@ async function expectLocalAvatarPath(
} }
} }
const tempRoots: string[] = [];
async function createTempAvatarRoot() {
const root = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-avatar-"));
tempRoots.push(root);
return root;
}
afterEach(async () => {
await Promise.all(
tempRoots
.splice(0, tempRoots.length)
.map((root) => fs.rm(root, { recursive: true, force: true })),
);
});
describe("resolveAgentAvatar", () => { describe("resolveAgentAvatar", () => {
it("resolves local avatar from config when inside workspace", async () => { it("resolves local avatar from config when inside workspace", async () => {
const root = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-avatar-")); const root = await createTempAvatarRoot();
const workspace = path.join(root, "work"); const workspace = path.join(root, "work");
const avatarPath = path.join(workspace, "avatars", "main.png"); const avatarPath = path.join(workspace, "avatars", "main.png");
await writeFile(avatarPath); await writeFile(avatarPath);
@@ -47,7 +63,7 @@ describe("resolveAgentAvatar", () => {
}); });
it("rejects avatars outside the workspace", async () => { it("rejects avatars outside the workspace", async () => {
const root = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-avatar-")); const root = await createTempAvatarRoot();
const workspace = path.join(root, "work"); const workspace = path.join(root, "work");
await fs.mkdir(workspace, { recursive: true }); await fs.mkdir(workspace, { recursive: true });
const outsidePath = path.join(root, "outside.png"); const outsidePath = path.join(root, "outside.png");
@@ -73,7 +89,7 @@ describe("resolveAgentAvatar", () => {
}); });
it("falls back to IDENTITY.md when config has no avatar", async () => { it("falls back to IDENTITY.md when config has no avatar", async () => {
const root = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-avatar-")); const root = await createTempAvatarRoot();
const workspace = path.join(root, "work"); const workspace = path.join(root, "work");
const avatarPath = path.join(workspace, "avatars", "fallback.png"); const avatarPath = path.join(workspace, "avatars", "fallback.png");
await writeFile(avatarPath); await writeFile(avatarPath);
@@ -94,7 +110,7 @@ describe("resolveAgentAvatar", () => {
}); });
it("returns missing for non-existent local avatar files", async () => { it("returns missing for non-existent local avatar files", async () => {
const root = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-avatar-")); const root = await createTempAvatarRoot();
const workspace = path.join(root, "work"); const workspace = path.join(root, "work");
await fs.mkdir(workspace, { recursive: true }); await fs.mkdir(workspace, { recursive: true });