refactor(core): dedupe shared config and runtime helpers

src/infra/exec-approval-forwarder.test.ts

@@ -24,18 +24,40 @@ function getFirstDeliveryText(deliver: ReturnType<typeof vi.fn>): string {
   return firstCall?.payloads?.[0]?.text ?? "";
 }
 
+const TARGETS_CFG = {
+  approvals: {
+    exec: {
+      enabled: true,
+      mode: "targets",
+      targets: [{ channel: "telegram", to: "123" }],
+    },
+  },
+} as OpenClawConfig;
+
+function createForwarder(params: {
+  cfg: OpenClawConfig;
+  deliver?: ReturnType<typeof vi.fn>;
+  resolveSessionTarget?: () => { channel: string; to: string } | null;
+}) {
+  const deliver = params.deliver ?? vi.fn().mockResolvedValue([]);
+  const forwarder = createExecApprovalForwarder({
+    getConfig: () => params.cfg,
+    deliver,
+    nowMs: () => 1000,
+    resolveSessionTarget: params.resolveSessionTarget ?? (() => null),
+  });
+  return { deliver, forwarder };
+}
+
 describe("exec approval forwarder", () => {
   it("forwards to session target and resolves", async () => {
     vi.useFakeTimers();
-    const deliver = vi.fn().mockResolvedValue([]);
     const cfg = {
       approvals: { exec: { enabled: true, mode: "session" } },
     } as OpenClawConfig;
 
-    const forwarder = createExecApprovalForwarder({
-      getConfig: () => cfg,
-      deliver,
-      nowMs: () => 1000,
+    const { deliver, forwarder } = createForwarder({
+      cfg,
       resolveSessionTarget: () => ({ channel: "slack", to: "U1" }),
     });
 
@@ -56,23 +78,7 @@ describe("exec approval forwarder", () => {
 
   it("forwards to explicit targets and expires", async () => {
     vi.useFakeTimers();
-    const deliver = vi.fn().mockResolvedValue([]);
-    const cfg = {
-      approvals: {
-        exec: {
-          enabled: true,
-          mode: "targets",
-          targets: [{ channel: "telegram", to: "123" }],
-        },
-      },
-    } as OpenClawConfig;
-
-    const forwarder = createExecApprovalForwarder({
-      getConfig: () => cfg,
-      deliver,
-      nowMs: () => 1000,
-      resolveSessionTarget: () => null,
-    });
+    const { deliver, forwarder } = createForwarder({ cfg: TARGETS_CFG });
 
     await forwarder.handleRequested(baseRequest);
     expect(deliver).toHaveBeenCalledTimes(1);
@@ -83,23 +89,7 @@ describe("exec approval forwarder", () => {
 
   it("formats single-line commands as inline code", async () => {
     vi.useFakeTimers();
-    const deliver = vi.fn().mockResolvedValue([]);
-    const cfg = {
-      approvals: {
-        exec: {
-          enabled: true,
-          mode: "targets",
-          targets: [{ channel: "telegram", to: "123" }],
-        },
-      },
-    } as OpenClawConfig;
-
-    const forwarder = createExecApprovalForwarder({
-      getConfig: () => cfg,
-      deliver,
-      nowMs: () => 1000,
-      resolveSessionTarget: () => null,
-    });
+    const { deliver, forwarder } = createForwarder({ cfg: TARGETS_CFG });
 
     await forwarder.handleRequested(baseRequest);
 
@@ -108,23 +98,7 @@ describe("exec approval forwarder", () => {
 
   it("formats complex commands as fenced code blocks", async () => {
     vi.useFakeTimers();
-    const deliver = vi.fn().mockResolvedValue([]);
-    const cfg = {
-      approvals: {
-        exec: {
-          enabled: true,
-          mode: "targets",
-          targets: [{ channel: "telegram", to: "123" }],
-        },
-      },
-    } as OpenClawConfig;
-
-    const forwarder = createExecApprovalForwarder({
-      getConfig: () => cfg,
-      deliver,
-      nowMs: () => 1000,
-      resolveSessionTarget: () => null,
-    });
+    const { deliver, forwarder } = createForwarder({ cfg: TARGETS_CFG });
 
     await forwarder.handleRequested({
       ...baseRequest,
@@ -139,7 +113,6 @@ describe("exec approval forwarder", () => {
 
   it("skips discord forwarding when discord exec approvals target channel", async () => {
     vi.useFakeTimers();
-    const deliver = vi.fn().mockResolvedValue([]);
     const cfg = {
       approvals: { exec: { enabled: true, mode: "session" } },
       channels: {
@@ -153,10 +126,8 @@ describe("exec approval forwarder", () => {
       },
     } as OpenClawConfig;
 
-    const forwarder = createExecApprovalForwarder({
-      getConfig: () => cfg,
-      deliver,
-      nowMs: () => 1000,
+    const { deliver, forwarder } = createForwarder({
+      cfg,
       resolveSessionTarget: () => ({ channel: "discord", to: "channel:123" }),
     });
 
@@ -167,23 +138,7 @@ describe("exec approval forwarder", () => {
 
   it("uses a longer fence when command already contains triple backticks", async () => {
     vi.useFakeTimers();
-    const deliver = vi.fn().mockResolvedValue([]);
-    const cfg = {
-      approvals: {
-        exec: {
-          enabled: true,
-          mode: "targets",
-          targets: [{ channel: "telegram", to: "123" }],
-        },
-      },
-    } as OpenClawConfig;
-
-    const forwarder = createExecApprovalForwarder({
-      getConfig: () => cfg,
-      deliver,
-      nowMs: () => 1000,
-      resolveSessionTarget: () => null,
-    });
+    const { deliver, forwarder } = createForwarder({ cfg: TARGETS_CFG });
 
     await forwarder.handleRequested({
       ...baseRequest,