github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-19 03:07:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): dedupe shared config and runtime helpers

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-16 14:52:03 +00:00
parent 544ffbcf7b
commit 04892ee230
68 changed files with 1966 additions and 2018 deletions
Download Patch File Download Diff File Expand all files Collapse all files

160
src/routing/resolve-route.test.ts
View File

@@ -386,24 +386,49 @@ test("dmScope=per-account-channel-peer uses default accountId when not provided"
});
describe("parentPeer binding inheritance (thread support)", () => {
const threadPeer = { kind: "channel" as const, id: "thread-456" };
const defaultParentPeer = { kind: "channel" as const, id: "parent-channel-123" };
function makeDiscordPeerBinding(agentId: string, peerId: string) {
return {
agentId,
match: {
channel: "discord" as const,
peer: { kind: "channel" as const, id: peerId },
},
};
}
function makeDiscordGuildBinding(agentId: string, guildId: string) {
return {
agentId,
match: {
channel: "discord" as const,
guildId,
},
};
}
function resolveDiscordThreadRoute(params: {
cfg: OpenClawConfig;
parentPeer?: { kind: "channel"; id: string } | null;
guildId?: string;
}) {
const parentPeer = "parentPeer" in params ? params.parentPeer : defaultParentPeer;
return resolveAgentRoute({
cfg: params.cfg,
channel: "discord",
peer: threadPeer,
parentPeer,
guildId: params.guildId,
});
}
test("thread inherits binding from parent channel when no direct match", () => {
const cfg: OpenClawConfig = {
bindings: [
{
agentId: "adecco",
match: {
channel: "discord",
peer: { kind: "channel", id: "parent-channel-123" },
},
},
],
bindings: [makeDiscordPeerBinding("adecco", defaultParentPeer.id)],
};
const route = resolveAgentRoute({
cfg,
channel: "discord",
peer: { kind: "channel", id: "thread-456" },
parentPeer: { kind: "channel", id: "parent-channel-123" },
});
const route = resolveDiscordThreadRoute({ cfg });
expect(route.agentId).toBe("adecco");
expect(route.matchedBy).toBe("binding.peer.parent");
});
@@ -411,28 +436,11 @@ describe("parentPeer binding inheritance (thread support)", () => {
test("direct peer binding wins over parent peer binding", () => {
const cfg: OpenClawConfig = {
bindings: [
{
agentId: "thread-agent",
match: {
channel: "discord",
peer: { kind: "channel", id: "thread-456" },
},
},
{
agentId: "parent-agent",
match: {
channel: "discord",
peer: { kind: "channel", id: "parent-channel-123" },
},
},
makeDiscordPeerBinding("thread-agent", threadPeer.id),
makeDiscordPeerBinding("parent-agent", defaultParentPeer.id),
],
};
const route = resolveAgentRoute({
cfg,
channel: "discord",
peer: { kind: "channel", id: "thread-456" },
parentPeer: { kind: "channel", id: "parent-channel-123" },
});
const route = resolveDiscordThreadRoute({ cfg });
expect(route.agentId).toBe("thread-agent");
expect(route.matchedBy).toBe("binding.peer");
});
@@ -440,29 +448,11 @@ describe("parentPeer binding inheritance (thread support)", () => {
test("parent peer binding wins over guild binding", () => {
const cfg: OpenClawConfig = {
bindings: [
{
agentId: "parent-agent",
match: {
channel: "discord",
peer: { kind: "channel", id: "parent-channel-123" },
},
},
{
agentId: "guild-agent",
match: {
channel: "discord",
guildId: "guild-789",
},
},
makeDiscordPeerBinding("parent-agent", defaultParentPeer.id),
makeDiscordGuildBinding("guild-agent", "guild-789"),
],
};
const route = resolveAgentRoute({
cfg,
channel: "discord",
peer: { kind: "channel", id: "thread-456" },
parentPeer: { kind: "channel", id: "parent-channel-123" },
guildId: "guild-789",
});
const route = resolveDiscordThreadRoute({ cfg, guildId: "guild-789" });
expect(route.agentId).toBe("parent-agent");
expect(route.matchedBy).toBe("binding.peer.parent");
});
@@ -470,73 +460,29 @@ describe("parentPeer binding inheritance (thread support)", () => {
test("falls back to guild binding when no parent peer match", () => {
const cfg: OpenClawConfig = {
bindings: [
{
agentId: "other-parent-agent",
match: {
channel: "discord",
peer: { kind: "channel", id: "other-parent-999" },
},
},
{
agentId: "guild-agent",
match: {
channel: "discord",
guildId: "guild-789",
},
},
makeDiscordPeerBinding("other-parent-agent", "other-parent-999"),
makeDiscordGuildBinding("guild-agent", "guild-789"),
],
};
const route = resolveAgentRoute({
cfg,
channel: "discord",
peer: { kind: "channel", id: "thread-456" },
parentPeer: { kind: "channel", id: "parent-channel-123" },
guildId: "guild-789",
});
const route = resolveDiscordThreadRoute({ cfg, guildId: "guild-789" });
expect(route.agentId).toBe("guild-agent");
expect(route.matchedBy).toBe("binding.guild");
});
test("parentPeer with empty id is ignored", () => {
const cfg: OpenClawConfig = {
bindings: [
{
agentId: "parent-agent",
match: {
channel: "discord",
peer: { kind: "channel", id: "parent-channel-123" },
},
},
],
bindings: [makeDiscordPeerBinding("parent-agent", defaultParentPeer.id)],
};
const route = resolveAgentRoute({
cfg,
channel: "discord",
peer: { kind: "channel", id: "thread-456" },
parentPeer: { kind: "channel", id: "" },
});
const route = resolveDiscordThreadRoute({ cfg, parentPeer: { kind: "channel", id: "" } });
expect(route.agentId).toBe("main");
expect(route.matchedBy).toBe("default");
});
test("null parentPeer is handled gracefully", () => {
const cfg: OpenClawConfig = {
bindings: [
{
agentId: "parent-agent",
match: {
channel: "discord",
peer: { kind: "channel", id: "parent-channel-123" },
},
},
],
bindings: [makeDiscordPeerBinding("parent-agent", defaultParentPeer.id)],
};
const route = resolveAgentRoute({
cfg,
channel: "discord",
peer: { kind: "channel", id: "thread-456" },
parentPeer: null,
});
const route = resolveDiscordThreadRoute({ cfg, parentPeer: null });
expect(route.agentId).toBe("main");
expect(route.matchedBy).toBe("default");
});