refactor(nodes): share node id matcher

src/shared/node-match.test.ts

@@ -0,0 +1,44 @@
+import { describe, expect, it } from "vitest";
+import { resolveNodeIdFromCandidates } from "./node-match.js";
+
+describe("resolveNodeIdFromCandidates", () => {
+  it("matches nodeId", () => {
+    expect(
+      resolveNodeIdFromCandidates(
+        [
+          { nodeId: "mac-123", displayName: "Mac Studio", remoteIp: "100.0.0.1" },
+          { nodeId: "pi-456", displayName: "Raspberry Pi", remoteIp: "100.0.0.2" },
+        ],
+        "pi-456",
+      ),
+    ).toBe("pi-456");
+  });
+
+  it("matches displayName using normalization", () => {
+    expect(
+      resolveNodeIdFromCandidates([{ nodeId: "mac-123", displayName: "Mac Studio" }], "mac studio"),
+    ).toBe("mac-123");
+  });
+
+  it("matches nodeId prefix (>=6 chars)", () => {
+    expect(resolveNodeIdFromCandidates([{ nodeId: "mac-abcdef" }], "mac-ab")).toBe("mac-abcdef");
+  });
+
+  it("throws unknown node with known list", () => {
+    expect(() =>
+      resolveNodeIdFromCandidates(
+        [
+          { nodeId: "mac-123", displayName: "Mac Studio", remoteIp: "100.0.0.1" },
+          { nodeId: "pi-456" },
+        ],
+        "nope",
+      ),
+    ).toThrow(/unknown node: nope.*known: /);
+  });
+
+  it("throws ambiguous node with matches list", () => {
+    expect(() =>
+      resolveNodeIdFromCandidates([{ nodeId: "mac-abcdef" }, { nodeId: "mac-abc999" }], "mac-abc"),
+    ).toThrow(/ambiguous node: mac-abc.*matches:/);
+  });
+});

src/shared/node-match.ts

@@ -0,0 +1,69 @@
+export type NodeMatchCandidate = {
+  nodeId: string;
+  displayName?: string;
+  remoteIp?: string;
+};
+
+export function normalizeNodeKey(value: string) {
+  return value
+    .toLowerCase()
+    .replace(/[^a-z0-9]+/g, "-")
+    .replace(/^-+/, "")
+    .replace(/-+$/, "");
+}
+
+function listKnownNodes(nodes: NodeMatchCandidate[]): string {
+  return nodes
+    .map((n) => n.displayName || n.remoteIp || n.nodeId)
+    .filter(Boolean)
+    .join(", ");
+}
+
+export function resolveNodeMatches(
+  nodes: NodeMatchCandidate[],
+  query: string,
+): NodeMatchCandidate[] {
+  const q = query.trim();
+  if (!q) {
+    return [];
+  }
+
+  const qNorm = normalizeNodeKey(q);
+  return nodes.filter((n) => {
+    if (n.nodeId === q) {
+      return true;
+    }
+    if (typeof n.remoteIp === "string" && n.remoteIp === q) {
+      return true;
+    }
+    const name = typeof n.displayName === "string" ? n.displayName : "";
+    if (name && normalizeNodeKey(name) === qNorm) {
+      return true;
+    }
+    if (q.length >= 6 && n.nodeId.startsWith(q)) {
+      return true;
+    }
+    return false;
+  });
+}
+
+export function resolveNodeIdFromCandidates(nodes: NodeMatchCandidate[], query: string): string {
+  const q = query.trim();
+  if (!q) {
+    throw new Error("node required");
+  }
+
+  const matches = resolveNodeMatches(nodes, q);
+  if (matches.length === 1) {
+    return matches[0]?.nodeId ?? "";
+  }
+  if (matches.length === 0) {
+    const known = listKnownNodes(nodes);
+    throw new Error(`unknown node: ${q}${known ? ` (known: ${known})` : ""}`);
+  }
+  throw new Error(
+    `ambiguous node: ${q} (matches: ${matches
+      .map((n) => n.displayName || n.remoteIp || n.nodeId)
+      .join(", ")})`,
+  );
+}