mirror of
https://github.com/openclaw/openclaw.git
synced 2026-05-08 21:38:25 +00:00
test: move skills-install fallback suite to e2e lane
This commit is contained in:
Peter Steinberger
@@ -1,240 +0,0 @@
|
||||
import fs from "node:fs/promises";
|
||||
import os from "node:os";
|
||||
import path from "node:path";
|
||||
import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import { installSkill } from "./skills-install.js";
|
||||
import { buildWorkspaceSkillStatus } from "./skills-status.js";
|
||||
|
||||
const runCommandWithTimeoutMock = vi.fn();
|
||||
const scanDirectoryWithSummaryMock = vi.fn();
|
||||
const hasBinaryMock = vi.fn();
|
||||
|
||||
vi.mock("../process/exec.js", () => ({
|
||||
runCommandWithTimeout: (...args: unknown[]) => runCommandWithTimeoutMock(...args),
|
||||
}));
|
||||
|
||||
vi.mock("../infra/net/fetch-guard.js", () => ({
|
||||
fetchWithSsrFGuard: vi.fn(),
|
||||
}));
|
||||
|
||||
vi.mock("../security/skill-scanner.js", async (importOriginal) => {
|
||||
const actual = await importOriginal<typeof import("../security/skill-scanner.js")>();
|
||||
return {
|
||||
...actual,
|
||||
scanDirectoryWithSummary: (...args: unknown[]) => scanDirectoryWithSummaryMock(...args),
|
||||
};
|
||||
});
|
||||
|
||||
vi.mock("../shared/config-eval.js", async (importOriginal) => {
|
||||
const actual = await importOriginal<typeof import("../shared/config-eval.js")>();
|
||||
return {
|
||||
...actual,
|
||||
hasBinary: (...args: unknown[]) => hasBinaryMock(...args),
|
||||
};
|
||||
});
|
||||
|
||||
vi.mock("../infra/brew.js", () => ({
|
||||
resolveBrewExecutable: () => undefined,
|
||||
}));
|
||||
|
||||
async function writeSkillWithInstallers(
|
||||
workspaceDir: string,
|
||||
name: string,
|
||||
installSpecs: Array<Record<string, string>>,
|
||||
): Promise<string> {
|
||||
const skillDir = path.join(workspaceDir, "skills", name);
|
||||
await fs.mkdir(skillDir, { recursive: true });
|
||||
await fs.writeFile(
|
||||
path.join(skillDir, "SKILL.md"),
|
||||
`---
|
||||
name: ${name}
|
||||
description: test skill
|
||||
metadata: ${JSON.stringify({ openclaw: { install: installSpecs } })}
|
||||
---
|
||||
|
||||
# ${name}
|
||||
`,
|
||||
"utf-8",
|
||||
);
|
||||
await fs.writeFile(path.join(skillDir, "runner.js"), "export {};\n", "utf-8");
|
||||
return skillDir;
|
||||
}
|
||||
|
||||
async function writeSkillWithInstaller(
|
||||
workspaceDir: string,
|
||||
name: string,
|
||||
kind: string,
|
||||
extra: Record<string, string>,
|
||||
): Promise<string> {
|
||||
return writeSkillWithInstallers(workspaceDir, name, [{ id: "deps", kind, ...extra }]);
|
||||
}
|
||||
|
||||
describe("skills-install fallback edge cases", () => {
|
||||
let workspaceDir: string;
|
||||
|
||||
beforeAll(async () => {
|
||||
workspaceDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-fallback-test-"));
|
||||
await writeSkillWithInstaller(workspaceDir, "go-tool-single", "go", {
|
||||
module: "example.com/tool@latest",
|
||||
});
|
||||
await writeSkillWithInstallers(workspaceDir, "go-tool-multi", [
|
||||
{ id: "brew", kind: "brew", formula: "go" },
|
||||
{ id: "go", kind: "go", module: "example.com/tool@latest" },
|
||||
]);
|
||||
await writeSkillWithInstaller(workspaceDir, "py-tool", "uv", {
|
||||
package: "example-package",
|
||||
});
|
||||
});
|
||||
|
||||
beforeEach(async () => {
|
||||
runCommandWithTimeoutMock.mockReset();
|
||||
scanDirectoryWithSummaryMock.mockReset();
|
||||
hasBinaryMock.mockReset();
|
||||
scanDirectoryWithSummaryMock.mockResolvedValue({ critical: 0, warn: 0, findings: [] });
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
await fs.rm(workspaceDir, { recursive: true, force: true }).catch(() => undefined);
|
||||
});
|
||||
|
||||
it("apt-get available but sudo missing/unusable returns helpful error for go install", async () => {
|
||||
// go not available, brew not available, apt-get + sudo are available, sudo check fails
|
||||
hasBinaryMock.mockImplementation((bin: string) => {
|
||||
if (bin === "go") {
|
||||
return false;
|
||||
}
|
||||
if (bin === "brew") {
|
||||
return false;
|
||||
}
|
||||
if (bin === "apt-get" || bin === "sudo") {
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
});
|
||||
|
||||
// sudo -n true fails (no passwordless sudo)
|
||||
runCommandWithTimeoutMock.mockResolvedValueOnce({
|
||||
code: 1,
|
||||
stdout: "",
|
||||
stderr: "sudo: a password is required",
|
||||
});
|
||||
|
||||
const result = await installSkill({
|
||||
workspaceDir,
|
||||
skillName: "go-tool-single",
|
||||
installId: "deps",
|
||||
});
|
||||
|
||||
expect(result.ok).toBe(false);
|
||||
expect(result.message).toContain("sudo");
|
||||
expect(result.message).toContain("https://go.dev/doc/install");
|
||||
|
||||
// Verify sudo -n true was called
|
||||
expect(runCommandWithTimeoutMock).toHaveBeenCalledWith(
|
||||
["sudo", "-n", "true"],
|
||||
expect.objectContaining({ timeoutMs: 5_000 }),
|
||||
);
|
||||
|
||||
// Verify apt-get install was NOT called
|
||||
const aptCalls = runCommandWithTimeoutMock.mock.calls.filter(
|
||||
(call) => Array.isArray(call[0]) && (call[0] as string[]).includes("apt-get"),
|
||||
);
|
||||
expect(aptCalls).toHaveLength(0);
|
||||
});
|
||||
|
||||
it("status-selected go installer fails gracefully when apt fallback needs sudo", async () => {
|
||||
// no go/brew, but apt and sudo are present
|
||||
hasBinaryMock.mockImplementation((bin: string) => {
|
||||
if (bin === "go" || bin === "brew") {
|
||||
return false;
|
||||
}
|
||||
if (bin === "apt-get" || bin === "sudo") {
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
});
|
||||
|
||||
runCommandWithTimeoutMock.mockResolvedValueOnce({
|
||||
code: 1,
|
||||
stdout: "",
|
||||
stderr: "sudo: a password is required",
|
||||
});
|
||||
|
||||
const status = buildWorkspaceSkillStatus(workspaceDir);
|
||||
const skill = status.skills.find((entry) => entry.name === "go-tool-multi");
|
||||
expect(skill?.install[0]?.id).toBe("go");
|
||||
|
||||
const result = await installSkill({
|
||||
workspaceDir,
|
||||
skillName: "go-tool-multi",
|
||||
installId: skill?.install[0]?.id ?? "",
|
||||
});
|
||||
|
||||
expect(result.ok).toBe(false);
|
||||
expect(result.message).toContain("sudo is not usable");
|
||||
});
|
||||
|
||||
it("handles sudo probe spawn failures without throwing", async () => {
|
||||
// go not available, brew not available, apt-get + sudo appear available
|
||||
hasBinaryMock.mockImplementation((bin: string) => {
|
||||
if (bin === "go") {
|
||||
return false;
|
||||
}
|
||||
if (bin === "brew") {
|
||||
return false;
|
||||
}
|
||||
if (bin === "apt-get" || bin === "sudo") {
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
});
|
||||
|
||||
runCommandWithTimeoutMock.mockRejectedValueOnce(
|
||||
new Error('Executable not found in $PATH: "sudo"'),
|
||||
);
|
||||
|
||||
const result = await installSkill({
|
||||
workspaceDir,
|
||||
skillName: "go-tool-single",
|
||||
installId: "deps",
|
||||
});
|
||||
|
||||
expect(result.ok).toBe(false);
|
||||
expect(result.message).toContain("sudo is not usable");
|
||||
expect(result.stderr).toContain("Executable not found");
|
||||
|
||||
// Verify apt-get install was NOT called
|
||||
const aptCalls = runCommandWithTimeoutMock.mock.calls.filter(
|
||||
(call) => Array.isArray(call[0]) && (call[0] as string[]).includes("apt-get"),
|
||||
);
|
||||
expect(aptCalls).toHaveLength(0);
|
||||
});
|
||||
|
||||
it("uv not installed and no brew returns helpful error without curl auto-install", async () => {
|
||||
// uv not available, brew not available, curl IS available
|
||||
hasBinaryMock.mockImplementation((bin: string) => {
|
||||
if (bin === "uv") {
|
||||
return false;
|
||||
}
|
||||
if (bin === "brew") {
|
||||
return false;
|
||||
}
|
||||
if (bin === "curl") {
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
});
|
||||
|
||||
const result = await installSkill({
|
||||
workspaceDir,
|
||||
skillName: "py-tool",
|
||||
installId: "deps",
|
||||
});
|
||||
|
||||
expect(result.ok).toBe(false);
|
||||
expect(result.message).toContain("https://docs.astral.sh/uv/getting-started/installation/");
|
||||
|
||||
// Verify NO curl command was attempted (no auto-install)
|
||||
expect(runCommandWithTimeoutMock).not.toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user