github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 20:28:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(discord): dedupe guild permission route mocks

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-21 22:57:55 +00:00
parent f41be7159c
commit 0e68789ebf
1 changed files with 74 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

147
src/discord/send.permissions.authz.test.ts
View File

@@ -15,6 +15,34 @@ vi.mock("./client.js", () => ({
resolveDiscordRest: () => mockRest as unknown as RequestClient, resolveDiscordRest: () => mockRest as unknown as RequestClient,
})); }));
type RouteMockParams = {
guildId?: string;
userId?: string;
roles: Array<{ id: string; permissions: string | bigint }>;
memberRoles: string[];
};
function mockGuildMemberRoutes(params: RouteMockParams): void {
const guildId = params.guildId ?? "guild-1";
const userId = params.userId ?? "user-1";
mockRest.get.mockImplementation(async (route: string) => {
if (route === Routes.guild(guildId)) {
return {
id: guildId,
roles: params.roles.map((role) => ({
id: role.id,
permissions:
typeof role.permissions === "bigint" ? role.permissions.toString() : role.permissions,
})),
};
}
if (route === Routes.guildMember(guildId, userId)) {
return { id: userId, roles: params.memberRoles };
}
throw new Error(`Unexpected route: ${route}`);
});
}
describe("discord guild permission authorization", () => { describe("discord guild permission authorization", () => {
describe("fetchMemberGuildPermissionsDiscord", () => { describe("fetchMemberGuildPermissionsDiscord", () => {
it("returns null when user is not a guild member", async () => { it("returns null when user is not a guild member", async () => {
@@ -25,23 +53,12 @@ describe("discord guild permission authorization", () => {
}); });
it("includes @everyone and member roles in computed permissions", async () => { it("includes @everyone and member roles in computed permissions", async () => {
mockRest.get.mockImplementation(async (route: string) => { mockGuildMemberRoutes({
if (route === Routes.guild("guild-1")) { roles: [
return { { id: "guild-1", permissions: PermissionFlagsBits.ViewChannel },
id: "guild-1", { id: "role-mod", permissions: PermissionFlagsBits.KickMembers },
roles: [ ],
{ id: "guild-1", permissions: PermissionFlagsBits.ViewChannel.toString() }, memberRoles: ["role-mod"],
{ id: "role-mod", permissions: PermissionFlagsBits.KickMembers.toString() },
],
};
}
if (route === Routes.guildMember("guild-1", "user-1")) {
return {
id: "user-1",
roles: ["role-mod"],
};
}
throw new Error(`Unexpected route: ${route}`);
}); });
const result = await fetchMemberGuildPermissionsDiscord("guild-1", "user-1"); const result = await fetchMemberGuildPermissionsDiscord("guild-1", "user-1");
@@ -57,20 +74,12 @@ describe("discord guild permission authorization", () => {
describe("hasAnyGuildPermissionDiscord", () => { describe("hasAnyGuildPermissionDiscord", () => {
it("returns true when user has required permission", async () => { it("returns true when user has required permission", async () => {
mockRest.get.mockImplementation(async (route: string) => { mockGuildMemberRoutes({
if (route === Routes.guild("guild-1")) { roles: [
return { { id: "guild-1", permissions: "0" },
id: "guild-1", { id: "role-mod", permissions: PermissionFlagsBits.KickMembers },
roles: [ ],
{ id: "guild-1", permissions: "0" }, memberRoles: ["role-mod"],
{ id: "role-mod", permissions: PermissionFlagsBits.KickMembers.toString() },
],
};
}
if (route === Routes.guildMember("guild-1", "user-1")) {
return { id: "user-1", roles: ["role-mod"] };
}
throw new Error(`Unexpected route: ${route}`);
}); });
const result = await hasAnyGuildPermissionDiscord("guild-1", "user-1", [ const result = await hasAnyGuildPermissionDiscord("guild-1", "user-1", [
@@ -80,23 +89,15 @@ describe("discord guild permission authorization", () => {
}); });
it("returns true when user has ADMINISTRATOR", async () => { it("returns true when user has ADMINISTRATOR", async () => {
mockRest.get.mockImplementation(async (route: string) => { mockGuildMemberRoutes({
if (route === Routes.guild("guild-1")) { roles: [
return { { id: "guild-1", permissions: "0" },
id: "guild-1", {
roles: [ id: "role-admin",
{ id: "guild-1", permissions: "0" }, permissions: PermissionFlagsBits.Administrator,
{ },
id: "role-admin", ],
permissions: PermissionFlagsBits.Administrator.toString(), memberRoles: ["role-admin"],
},
],
};
}
if (route === Routes.guildMember("guild-1", "user-1")) {
return { id: "user-1", roles: ["role-admin"] };
}
throw new Error(`Unexpected route: ${route}`);
}); });
const result = await hasAnyGuildPermissionDiscord("guild-1", "user-1", [ const result = await hasAnyGuildPermissionDiscord("guild-1", "user-1", [
@@ -106,17 +107,9 @@ describe("discord guild permission authorization", () => {
}); });
it("returns false when user lacks all required permissions", async () => { it("returns false when user lacks all required permissions", async () => {
mockRest.get.mockImplementation(async (route: string) => { mockGuildMemberRoutes({
if (route === Routes.guild("guild-1")) { roles: [{ id: "guild-1", permissions: PermissionFlagsBits.ViewChannel }],
return { memberRoles: [],
id: "guild-1",
roles: [{ id: "guild-1", permissions: PermissionFlagsBits.ViewChannel.toString() }],
};
}
if (route === Routes.guildMember("guild-1", "user-1")) {
return { id: "user-1", roles: [] };
}
throw new Error(`Unexpected route: ${route}`);
}); });
const result = await hasAnyGuildPermissionDiscord("guild-1", "user-1", [ const result = await hasAnyGuildPermissionDiscord("guild-1", "user-1", [
@@ -129,20 +122,12 @@ describe("discord guild permission authorization", () => {
describe("hasAllGuildPermissionsDiscord", () => { describe("hasAllGuildPermissionsDiscord", () => {
it("returns false when user has only one of multiple required permissions", async () => { it("returns false when user has only one of multiple required permissions", async () => {
mockRest.get.mockImplementation(async (route: string) => { mockGuildMemberRoutes({
if (route === Routes.guild("guild-1")) { roles: [
return { { id: "guild-1", permissions: "0" },
id: "guild-1", { id: "role-mod", permissions: PermissionFlagsBits.KickMembers },
roles: [ ],
{ id: "guild-1", permissions: "0" }, memberRoles: ["role-mod"],
{ id: "role-mod", permissions: PermissionFlagsBits.KickMembers.toString() },
],
};
}
if (route === Routes.guildMember("guild-1", "user-1")) {
return { id: "user-1", roles: ["role-mod"] };
}
throw new Error(`Unexpected route: ${route}`);
}); });
const result = await hasAllGuildPermissionsDiscord("guild-1", "user-1", [ const result = await hasAllGuildPermissionsDiscord("guild-1", "user-1", [
@@ -151,5 +136,21 @@ describe("discord guild permission authorization", () => {
]); ]);
expect(result).toBe(false); expect(result).toBe(false);
}); });
it("returns true for hasAll checks when user has ADMINISTRATOR", async () => {
mockGuildMemberRoutes({
roles: [
{ id: "guild-1", permissions: "0" },
{ id: "role-admin", permissions: PermissionFlagsBits.Administrator },
],
memberRoles: ["role-admin"],
});
const result = await hasAllGuildPermissionsDiscord("guild-1", "user-1", [
PermissionFlagsBits.KickMembers,
PermissionFlagsBits.BanMembers,
]);
expect(result).toBe(true);
});
}); });
}); });