From 0f9e16ca463b6efaf89a73279d1a83e05b4f7c9d Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 22:20:56 +0000
Subject: [PATCH] refactor: share provider chunk context resolution

---
 src/auto-reply/reply/block-streaming.ts | 54 ++++++++++++-------------
 1 file changed, 25 insertions(+), 29 deletions(-)

diff --git a/src/auto-reply/reply/block-streaming.ts b/src/auto-reply/reply/block-streaming.ts
index 6d306b166c1..b24ee8cac1a 100644
--- a/src/auto-reply/reply/block-streaming.ts
+++ b/src/auto-reply/reply/block-streaming.ts
@@ -26,6 +26,22 @@ function normalizeChunkProvider(provider?: string): TextChunkProvider | undefine
     : undefined;
 }
 
+function resolveProviderChunkContext(
+  cfg: OpenClawConfig | undefined,
+  provider?: string,
+  accountId?: string | null,
+) {
+  const providerKey = normalizeChunkProvider(provider);
+  const providerId = providerKey ? normalizeChannelId(providerKey) : null;
+  const providerChunkLimit = providerId
+    ? getChannelDock(providerId)?.outbound?.textChunkLimit
+    : undefined;
+  const textLimit = resolveTextChunkLimit(cfg, providerKey, accountId, {
+    fallbackLimit: providerChunkLimit,
+  });
+  return { providerKey, providerId, textLimit };
+}
+
 type ProviderBlockStreamingConfig = {
   blockStreamingCoalesce?: BlockStreamingCoalesceConfig;
   accounts?: Record<string, { blockStreamingCoalesce?: BlockStreamingCoalesceConfig }>;
@@ -97,14 +113,7 @@ export function resolveEffectiveBlockStreamingConfig(params: {
   chunking: BlockStreamingChunking;
   coalescing: BlockStreamingCoalescing;
 } {
-  const providerKey = normalizeChunkProvider(params.provider);
-  const providerId = providerKey ? normalizeChannelId(providerKey) : null;
-  const providerChunkLimit = providerId
-    ? getChannelDock(providerId)?.outbound?.textChunkLimit
-    : undefined;
-  const textLimit = resolveTextChunkLimit(params.cfg, providerKey, params.accountId, {
-    fallbackLimit: providerChunkLimit,
-  });
+  const { textLimit } = resolveProviderChunkContext(params.cfg, params.provider, params.accountId);
   const chunkingDefaults =
     params.chunking ?? resolveBlockStreamingChunking(params.cfg, params.provider, params.accountId);
   const chunkingMax = clampPositiveInteger(params.maxChunkChars, chunkingDefaults.maxChars, {
@@ -154,21 +163,13 @@ export function resolveBlockStreamingChunking(
   provider?: string,
   accountId?: string | null,
 ): BlockStreamingChunking {
-  const providerKey = normalizeChunkProvider(provider);
-  const providerConfigKey = providerKey;
-  const providerId = providerKey ? normalizeChannelId(providerKey) : null;
-  const providerChunkLimit = providerId
-    ? getChannelDock(providerId)?.outbound?.textChunkLimit
-    : undefined;
-  const textLimit = resolveTextChunkLimit(cfg, providerConfigKey, accountId, {
-    fallbackLimit: providerChunkLimit,
-  });
+  const { providerKey, textLimit } = resolveProviderChunkContext(cfg, provider, accountId);
   const chunkCfg = cfg?.agents?.defaults?.blockStreamingChunk;
 
   // When chunkMode="newline", the outbound delivery splits on paragraph boundaries.
   // The block chunker should flush eagerly on \n\n boundaries during streaming,
   // regardless of minChars, so each paragraph is sent as its own message.
-  const chunkMode = resolveChunkMode(cfg, providerConfigKey, accountId);
+  const chunkMode = resolveChunkMode(cfg, providerKey, accountId);
 
   const maxRequested = Math.max(1, Math.floor(chunkCfg?.maxChars ?? DEFAULT_BLOCK_STREAM_MAX));
   const maxChars = Math.max(1, Math.min(maxRequested, textLimit));
@@ -198,20 +199,15 @@ export function resolveBlockStreamingCoalescing(
   },
   opts?: { chunkMode?: "length" | "newline" },
 ): BlockStreamingCoalescing | undefined {
-  const providerKey = normalizeChunkProvider(provider);
-  const providerConfigKey = providerKey;
+  const { providerKey, providerId, textLimit } = resolveProviderChunkContext(
+    cfg,
+    provider,
+    accountId,
+  );
 
   // Resolve the outbound chunkMode so the coalescer can flush on paragraph boundaries
   // when chunkMode="newline", matching the delivery-time splitting behavior.
-  const chunkMode = opts?.chunkMode ?? resolveChunkMode(cfg, providerConfigKey, accountId);
-
-  const providerId = providerKey ? normalizeChannelId(providerKey) : null;
-  const providerChunkLimit = providerId
-    ? getChannelDock(providerId)?.outbound?.textChunkLimit
-    : undefined;
-  const textLimit = resolveTextChunkLimit(cfg, providerConfigKey, accountId, {
-    fallbackLimit: providerChunkLimit,
-  });
+  const chunkMode = opts?.chunkMode ?? resolveChunkMode(cfg, providerKey, accountId);
   const providerDefaults = providerId
     ? getChannelDock(providerId)?.streaming?.blockStreamingCoalesceDefaults
     : undefined;