github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-11 06:34:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(agents): only recover edit when oldText no longer in file (review feedback)

Browse Source
This commit is contained in:
倪汉杰0668001185
2026-03-03 09:53:03 +08:00
committed by Peter Steinberger
parent bf6aa7ca67
commit 0fb3f188b2
2 changed files with 30 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/agents/pi-tools.read.host-edit-recovery.test.ts
View File

@@ -44,18 +44,15 @@ describe("createHostWorkspaceEditTool post-write recovery", () => {
}
});
it("returns success when upstream throws but file on disk contains newText", async () => {
it("returns success when upstream throws but file has newText and no longer has oldText", async () => {
tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-edit-recovery-"));
const filePath = path.join(tmpDir, "MEMORY.md");
const oldText = "# Memory";
const newText = "Blog Writing";
await fs.writeFile(filePath, `# Memory\n\n${newText}\n`, "utf-8");
await fs.writeFile(filePath, `\n\n${newText}\n`, "utf-8");
const tool = createHostWorkspaceEditTool(tmpDir);
const result = await tool.execute(
"call-1",
{ path: filePath, oldText: "# Memory", newText },
undefined,
);
const result = await tool.execute("call-1", { path: filePath, oldText, newText }, undefined);
expect(result).toBeDefined();
const content = Array.isArray((result as { content?: unknown }).content)
@@ -75,4 +72,17 @@ describe("createHostWorkspaceEditTool post-write recovery", () => {
tool.execute("call-1", { path: filePath, oldText: "x", newText: "never-written" }, undefined),
).rejects.toThrow("Simulated post-write failure");
});
it("rethrows when file still contains oldText (pre-write failure; avoid false success)", async () => {
tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-edit-recovery-"));
const filePath = path.join(tmpDir, "pre-write-fail.md");
const oldText = "replace me";
const newText = "new content";
await fs.writeFile(filePath, `before ${oldText} after ${newText}`, "utf-8");
const tool = createHostWorkspaceEditTool(tmpDir);
await expect(
tool.execute("call-1", { path: filePath, oldText, newText }, undefined),
).rejects.toThrow("Simulated post-write failure");
});
});