github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-07 14:01:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: dedupe registry/session tests and add install source coverage

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-18 05:04:44 +00:00
parent 07fdceb5fd
commit 112f8250fc
4 changed files with 242 additions and 131 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
src/agents/session-tool-result-guard.e2e.test.ts
View File

@@ -33,6 +33,12 @@ function getPersistedMessages(sm: SessionManager): AgentMessage[] {
.map((e) => (e as { message: AgentMessage }).message);
}
function expectPersistedRoles(sm: SessionManager, expectedRoles: AgentMessage["role"][]) {
const messages = getPersistedMessages(sm);
expect(messages.map((message) => message.role)).toEqual(expectedRoles);
return messages;
}
function getToolResultText(messages: AgentMessage[]): string {
const toolResult = messages.find((m) => m.role === "toolResult") as {
content: Array<{ type: string; text: string }>;
@@ -58,13 +64,8 @@ describe("installSessionToolResultGuard", () => {
}),
);
const entries = sm
.getEntries()
.filter((e) => e.type === "message")
.map((e) => (e as { message: AgentMessage }).message);
expect(entries.map((m) => m.role)).toEqual(["assistant", "toolResult", "assistant"]);
const synthetic = entries[1] as {
const messages = expectPersistedRoles(sm, ["assistant", "toolResult", "assistant"]);
const synthetic = messages[1] as {
toolCallId?: string;
isError?: boolean;
content?: Array<{ type?: string; text?: string }>;
@@ -81,12 +82,7 @@ describe("installSessionToolResultGuard", () => {
sm.appendMessage(toolCallMessage);
guard.flushPendingToolResults();
const messages = sm
.getEntries()
.filter((e) => e.type === "message")
.map((e) => (e as { message: AgentMessage }).message);
expect(messages.map((m) => m.role)).toEqual(["assistant", "toolResult"]);
expectPersistedRoles(sm, ["assistant", "toolResult"]);
});
it("does not add synthetic toolResult when a matching one exists", () => {
@@ -103,12 +99,7 @@ describe("installSessionToolResultGuard", () => {
}),
);
const messages = sm
.getEntries()
.filter((e) => e.type === "message")
.map((e) => (e as { message: AgentMessage }).message);
expect(messages.map((m) => m.role)).toEqual(["assistant", "toolResult"]);
expectPersistedRoles(sm, ["assistant", "toolResult"]);
});
it("preserves ordering with multiple tool calls and partial results", () => {
@@ -139,12 +130,7 @@ describe("installSessionToolResultGuard", () => {
}),
);
const messages = sm
.getEntries()
.filter((e) => e.type === "message")
.map((e) => (e as { message: AgentMessage }).message);
expect(messages.map((m) => m.role)).toEqual([
const messages = expectPersistedRoles(sm, [
"assistant", // tool calls
"toolResult", // call_a real
"toolResult", // synthetic for call_b
@@ -187,11 +173,7 @@ describe("installSessionToolResultGuard", () => {
}),
);
const messages = sm
.getEntries()
.filter((e) => e.type === "message")
.map((e) => (e as { message: AgentMessage }).message);
expect(messages.map((m) => m.role)).toEqual(["assistant", "toolResult"]);
expectPersistedRoles(sm, ["assistant", "toolResult"]);
});
it("drops malformed tool calls missing input before persistence", () => {
@@ -205,11 +187,7 @@ describe("installSessionToolResultGuard", () => {
}),
);
const messages = sm
.getEntries()
.filter((e) => e.type === "message")
.map((e) => (e as { message: AgentMessage }).message);
const messages = getPersistedMessages(sm);
expect(messages).toHaveLength(0);
});
@@ -231,12 +209,7 @@ describe("installSessionToolResultGuard", () => {
}),
);
const messages = sm
.getEntries()
.filter((e) => e.type === "message")
.map((e) => (e as { message: AgentMessage }).message);
expect(messages.map((m) => m.role)).toEqual(["assistant", "toolResult"]);
expectPersistedRoles(sm, ["assistant", "toolResult"]);
});
it("caps oversized tool result text during persistence", () => {