github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 01:51:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Fix types in tests 31/N.

Browse Source
This commit is contained in:
cpojer
2026-02-17 14:33:26 +09:00
parent f2f17bafbc
commit 116f5afea3
12 changed files with 185 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
src/agents/pi-tools.before-tool-call.e2e.test.ts
View File

@@ -32,11 +32,17 @@ describe("before_tool_call hook integration", () => {
agentId: "main",
sessionKey: "main",
});
const extensionContext = {} as Parameters<typeof tool.execute>[3];
await tool.execute("call-1", { path: "/tmp/file" }, undefined, undefined);
await tool.execute("call-1", { path: "/tmp/file" }, undefined, extensionContext);
expect(hookRunner.runBeforeToolCall).not.toHaveBeenCalled();
expect(execute).toHaveBeenCalledWith("call-1", { path: "/tmp/file" }, undefined, undefined);
expect(execute).toHaveBeenCalledWith(
"call-1",
{ path: "/tmp/file" },
undefined,
extensionContext,
);
});
it("allows hook to modify parameters", async () => {
@@ -45,14 +51,15 @@ describe("before_tool_call hook integration", () => {
const execute = vi.fn().mockResolvedValue({ content: [], details: { ok: true } });
// oxlint-disable-next-line typescript/no-explicit-any
const tool = wrapToolWithBeforeToolCallHook({ name: "exec", execute } as any);
const extensionContext = {} as Parameters<typeof tool.execute>[3];
await tool.execute("call-2", { cmd: "ls" }, undefined, undefined);
await tool.execute("call-2", { cmd: "ls" }, undefined, extensionContext);
expect(execute).toHaveBeenCalledWith(
"call-2",
{ cmd: "ls", mode: "safe" },
undefined,
undefined,
extensionContext,
);
});
@@ -65,10 +72,11 @@ describe("before_tool_call hook integration", () => {
const execute = vi.fn().mockResolvedValue({ content: [], details: { ok: true } });
// oxlint-disable-next-line typescript/no-explicit-any
const tool = wrapToolWithBeforeToolCallHook({ name: "exec", execute } as any);
const extensionContext = {} as Parameters<typeof tool.execute>[3];
await expect(tool.execute("call-3", { cmd: "rm -rf /" }, undefined, undefined)).rejects.toThrow(
"blocked",
);
await expect(
tool.execute("call-3", { cmd: "rm -rf /" }, undefined, extensionContext),
).rejects.toThrow("blocked");
expect(execute).not.toHaveBeenCalled();
});
@@ -78,10 +86,16 @@ describe("before_tool_call hook integration", () => {
const execute = vi.fn().mockResolvedValue({ content: [], details: { ok: true } });
// oxlint-disable-next-line typescript/no-explicit-any
const tool = wrapToolWithBeforeToolCallHook({ name: "read", execute } as any);
const extensionContext = {} as Parameters<typeof tool.execute>[3];
await tool.execute("call-4", { path: "/tmp/file" }, undefined, undefined);
await tool.execute("call-4", { path: "/tmp/file" }, undefined, extensionContext);
expect(execute).toHaveBeenCalledWith("call-4", { path: "/tmp/file" }, undefined, undefined);
expect(execute).toHaveBeenCalledWith(
"call-4",
{ path: "/tmp/file" },
undefined,
extensionContext,
);
});
it("normalizes non-object params for hook contract", async () => {
@@ -93,8 +107,9 @@ describe("before_tool_call hook integration", () => {
agentId: "main",
sessionKey: "main",
});
const extensionContext = {} as Parameters<typeof tool.execute>[3];
await tool.execute("call-5", "not-an-object", undefined, undefined);
await tool.execute("call-5", "not-an-object", undefined, extensionContext);
expect(hookRunner.runBeforeToolCall).toHaveBeenCalledWith(
{
@@ -136,14 +151,16 @@ describe("before_tool_call hook deduplication (#15502)", () => {
sessionKey: "main",
});
const [def] = toToolDefinitions([wrapped]);
const extensionContext = {} as Parameters<typeof def.execute>[3];
await def.execute(
const args: Parameters<typeof def.execute> = [
"call-dedup",
{ url: "https://example.com" },
undefined,
extensionContext,
undefined,
undefined,
);
];
await def.execute(...args);
expect(hookRunner.runBeforeToolCall).toHaveBeenCalledTimes(1);
});
@@ -183,8 +200,16 @@ describe("before_tool_call hook integration for client tools", () => {
onClientToolCall,
{ agentId: "main", sessionKey: "main" },
);
const extensionContext = {} as Parameters<typeof tool.execute>[3];
await tool.execute("client-call-1", { value: "ok" }, undefined, undefined, undefined);
const args: Parameters<typeof tool.execute> = [
"client-call-1",
{ value: "ok" },
undefined,
extensionContext,
undefined,
];
await tool.execute(...args);
expect(onClientToolCall).toHaveBeenCalledWith("client_tool", {
value: "ok",