chore(tsgo/lint): fix CI errors

This commit is contained in:
Gustavo Madeira Santana
2026-03-02 03:03:11 -05:00
parent 22be0c5801
commit 1443bb9a84
17 changed files with 132 additions and 103 deletions

View File

@@ -72,7 +72,7 @@ async function runMemberCase(args: MemberCaseArgs = {}): Promise<void> {
}
describe("registerSlackMemberEvents", () => {
it.each([
const cases: Array<{ name: string; args: MemberCaseArgs; calls: number }> = [
{
name: "enqueues DM member events when dmPolicy is open",
args: { overrides: { dmPolicy: "open" } },
@@ -112,7 +112,9 @@ describe("registerSlackMemberEvents", () => {
},
calls: 0,
},
])("$name", async ({ args, calls }) => {
];
it.each(cases)("$name", async ({ args, calls }) => {
await runMemberCase(args);
expect(memberMocks.enqueue).toHaveBeenCalledTimes(calls);
});

View File

@@ -87,7 +87,7 @@ async function runMessageCase(input: MessageCase = {}): Promise<void> {
}
describe("registerSlackMessageEvents", () => {
it.each([
const cases: Array<{ name: string; input: MessageCase; calls: number }> = [
{
name: "enqueues message_changed system events when dmPolicy is open",
input: { overrides: { dmPolicy: "open" }, event: makeChangedEvent() },
@@ -130,7 +130,9 @@ describe("registerSlackMessageEvents", () => {
},
calls: 0,
},
])("$name", async ({ input, calls }) => {
];
it.each(cases)("$name", async ({ input, calls }) => {
await runMessageCase(input);
expect(messageQueueMock).toHaveBeenCalledTimes(calls);
});

View File

@@ -75,32 +75,36 @@ async function runPinCase(input: PinCase = {}): Promise<void> {
}
describe("registerSlackPinEvents", () => {
it.each([
["enqueues DM pin system events when dmPolicy is open", { overrides: { dmPolicy: "open" } }, 1],
[
"blocks DM pin system events when dmPolicy is disabled",
{ overrides: { dmPolicy: "disabled" } },
0,
],
[
"blocks DM pin system events for unauthorized senders in allowlist mode",
{
const cases: Array<{ name: string; args: PinCase; expectedCalls: number }> = [
{
name: "enqueues DM pin system events when dmPolicy is open",
args: { overrides: { dmPolicy: "open" } },
expectedCalls: 1,
},
{
name: "blocks DM pin system events when dmPolicy is disabled",
args: { overrides: { dmPolicy: "disabled" } },
expectedCalls: 0,
},
{
name: "blocks DM pin system events for unauthorized senders in allowlist mode",
args: {
overrides: { dmPolicy: "allowlist", allowFrom: ["U2"] },
event: makePinEvent({ user: "U1" }),
},
0,
],
[
"allows DM pin system events for authorized senders in allowlist mode",
{
expectedCalls: 0,
},
{
name: "allows DM pin system events for authorized senders in allowlist mode",
args: {
overrides: { dmPolicy: "allowlist", allowFrom: ["U1"] },
event: makePinEvent({ user: "U1" }),
},
1,
],
[
"blocks channel pin events for users outside channel users allowlist",
{
expectedCalls: 1,
},
{
name: "blocks channel pin events for users outside channel users allowlist",
args: {
overrides: {
dmPolicy: "open",
channelType: "channel",
@@ -108,9 +112,11 @@ describe("registerSlackPinEvents", () => {
},
event: makePinEvent({ channel: "C1", user: "U_ATTACKER" }),
},
0,
],
])("%s", async (_name, args: PinCase, expectedCalls: number) => {
expectedCalls: 0,
},
];
it.each(cases)("$name", async ({ args, expectedCalls }) => {
await runPinCase(args);
expect(pinEnqueueMock).toHaveBeenCalledTimes(expectedCalls);
});

View File

@@ -78,7 +78,7 @@ async function executeReactionCase(input: ReactionRunInput = {}) {
}
describe("registerSlackReactionEvents", () => {
it.each([
const cases: Array<{ name: string; args: ReactionRunInput; expectedCalls: number }> = [
{
name: "enqueues DM reaction system events when dmPolicy is open",
args: { overrides: { dmPolicy: "open" } },
@@ -129,7 +129,9 @@ describe("registerSlackReactionEvents", () => {
},
expectedCalls: 0,
},
])("$name", async ({ args, expectedCalls }) => {
];
it.each(cases)("$name", async ({ args, expectedCalls }) => {
await executeReactionCase(args);
expect(reactionQueueMock).toHaveBeenCalledTimes(expectedCalls);
});