test(agents): collapse repeated announce direct-send scenarios

src/agents/subagent-announce.format.e2e.test.ts

@@ -595,9 +595,10 @@ describe("subagent announce formatting", () => {
     expect(directTargets).not.toContain("channel:main-parent-channel");
   });
 
-  it.each([
+  it("uses completion direct-send headers for error and timeout outcomes", async () => {
+    const { runSubagentAnnounceFlow } = await import("./subagent-announce.js");
+    const cases = [
       {
-      name: "error",
         childSessionId: "child-session-direct-error",
         requesterSessionId: "requester-session-error",
         childRunId: "run-direct-completion-error",
@@ -608,7 +609,6 @@ describe("subagent announce formatting", () => {
         spawnMode: "session" as const,
       },
       {
-      name: "timeout",
         childSessionId: "child-session-direct-timeout",
         requesterSessionId: "requester-session-timeout",
         childRunId: "run-direct-completion-timeout",
@@ -618,42 +618,33 @@ describe("subagent announce formatting", () => {
         excludedHeader: "✅ Subagent main finished",
         spawnMode: undefined,
       },
-  ])(
+    ] as const;
-    "uses completion direct-send header for $name outcomes",
+
-    async ({
+    for (const testCase of cases) {
-      childSessionId,
+      sendSpy.mockClear();
-      requesterSessionId,
-      childRunId,
-      replyText,
-      outcome,
-      expectedHeader,
-      excludedHeader,
-      spawnMode,
-    }) => {
-      const { runSubagentAnnounceFlow } = await import("./subagent-announce.js");
       sessionStore = {
         "agent:main:subagent:test": {
-          sessionId: childSessionId,
+          sessionId: testCase.childSessionId,
         },
         "agent:main:main": {
-          sessionId: requesterSessionId,
+          sessionId: testCase.requesterSessionId,
         },
       };
       chatHistoryMock.mockResolvedValueOnce({
-        messages: [{ role: "assistant", content: [{ type: "text", text: replyText }] }],
+        messages: [{ role: "assistant", content: [{ type: "text", text: testCase.replyText }] }],
       });
       readLatestAssistantReplyMock.mockResolvedValue("");
 
       const didAnnounce = await runSubagentAnnounceFlow({
         childSessionKey: "agent:main:subagent:test",
-        childRunId,
+        childRunId: testCase.childRunId,
         requesterSessionKey: "agent:main:main",
         requesterDisplayKey: "main",
         requesterOrigin: { channel: "discord", to: "channel:12345", accountId: "acct-1" },
         ...defaultOutcomeAnnounce,
-        outcome,
+        outcome: testCase.outcome,
         expectsCompletionMessage: true,
-        ...(spawnMode ? { spawnMode } : {}),
+        ...(testCase.spawnMode ? { spawnMode: testCase.spawnMode } : {}),
       });
 
       expect(didAnnounce).toBe(true);
@@ -661,73 +652,64 @@ describe("subagent announce formatting", () => {
       const call = sendSpy.mock.calls[0]?.[0] as { params?: Record<string, unknown> };
       const rawMessage = call?.params?.message;
       const msg = typeof rawMessage === "string" ? rawMessage : "";
-      expect(msg).toContain(expectedHeader);
+      expect(msg).toContain(testCase.expectedHeader);
-      expect(msg).toContain(replyText);
+      expect(msg).toContain(testCase.replyText);
-      expect(msg).not.toContain(excludedHeader);
+      expect(msg).not.toContain(testCase.excludedHeader);
-    },
+    }
-  );
+  });
 
-  it("ignores stale session thread hints for manual completion direct-send", async () => {
+  it("routes manual completion direct-send using requester thread hints", async () => {
     const { runSubagentAnnounceFlow } = await import("./subagent-announce.js");
-    sessionStore = {
+    const cases = [
-      "agent:main:subagent:test": {
+      {
-        sessionId: "child-session-direct-thread",
+        childSessionId: "child-session-direct-thread",
-      },
+        requesterSessionId: "requester-session-thread",
-      "agent:main:main": {
+        childRunId: "run-direct-stale-thread",
-        sessionId: "requester-session-thread",
+        requesterOrigin: { channel: "discord", to: "channel:12345", accountId: "acct-1" },
+        requesterSessionMeta: {
           lastChannel: "discord",
           lastTo: "channel:stale",
           lastThreadId: 42,
         },
-    };
+        expectedThreadId: undefined,
-    chatHistoryMock.mockResolvedValueOnce({
-      messages: [{ role: "assistant", content: [{ type: "text", text: "done" }] }],
-    });
-
-    const didAnnounce = await runSubagentAnnounceFlow({
-      childSessionKey: "agent:main:subagent:test",
-      childRunId: "run-direct-stale-thread",
-      requesterSessionKey: "agent:main:main",
-      requesterDisplayKey: "main",
-      requesterOrigin: { channel: "discord", to: "channel:12345", accountId: "acct-1" },
-      ...defaultOutcomeAnnounce,
-      expectsCompletionMessage: true,
-    });
-
-    expect(didAnnounce).toBe(true);
-    expect(sendSpy).toHaveBeenCalledTimes(1);
-    expect(agentSpy).not.toHaveBeenCalled();
-    const call = sendSpy.mock.calls[0]?.[0] as { params?: Record<string, unknown> };
-    expect(call?.params?.channel).toBe("discord");
-    expect(call?.params?.to).toBe("channel:12345");
-    expect(call?.params?.threadId).toBeUndefined();
-  });
-
-  it("passes requesterOrigin.threadId for manual completion direct-send", async () => {
-    const { runSubagentAnnounceFlow } = await import("./subagent-announce.js");
-    sessionStore = {
-      "agent:main:subagent:test": {
-        sessionId: "child-session-direct-thread-pass",
       },
-      "agent:main:main": {
+      {
-        sessionId: "requester-session-thread-pass",
+        childSessionId: "child-session-direct-thread-pass",
-      },
+        requesterSessionId: "requester-session-thread-pass",
-    };
-    chatHistoryMock.mockResolvedValueOnce({
-      messages: [{ role: "assistant", content: [{ type: "text", text: "done" }] }],
-    });
-
-    const didAnnounce = await runSubagentAnnounceFlow({
-      childSessionKey: "agent:main:subagent:test",
         childRunId: "run-direct-thread-pass",
-      requesterSessionKey: "agent:main:main",
-      requesterDisplayKey: "main",
         requesterOrigin: {
           channel: "discord",
           to: "channel:12345",
           accountId: "acct-1",
           threadId: 99,
         },
+        requesterSessionMeta: {},
+        expectedThreadId: "99",
+      },
+    ] as const;
+
+    for (const testCase of cases) {
+      sendSpy.mockClear();
+      agentSpy.mockClear();
+      sessionStore = {
+        "agent:main:subagent:test": {
+          sessionId: testCase.childSessionId,
+        },
+        "agent:main:main": {
+          sessionId: testCase.requesterSessionId,
+          ...testCase.requesterSessionMeta,
+        },
+      };
+      chatHistoryMock.mockResolvedValueOnce({
+        messages: [{ role: "assistant", content: [{ type: "text", text: "done" }] }],
+      });
+
+      const didAnnounce = await runSubagentAnnounceFlow({
+        childSessionKey: "agent:main:subagent:test",
+        childRunId: testCase.childRunId,
+        requesterSessionKey: "agent:main:main",
+        requesterDisplayKey: "main",
+        requesterOrigin: testCase.requesterOrigin,
         ...defaultOutcomeAnnounce,
         expectsCompletionMessage: true,
       });
@@ -738,12 +720,14 @@ describe("subagent announce formatting", () => {
       const call = sendSpy.mock.calls[0]?.[0] as { params?: Record<string, unknown> };
       expect(call?.params?.channel).toBe("discord");
       expect(call?.params?.to).toBe("channel:12345");
-    expect(call?.params?.threadId).toBe("99");
+      expect(call?.params?.threadId).toBe(testCase.expectedThreadId);
+    }
   });
 
-  it.each([
+  it("uses hook-provided thread target across requester thread variants", async () => {
+    const { runSubagentAnnounceFlow } = await import("./subagent-announce.js");
+    const cases = [
       {
-      name: "requester threadId matches hook target",
         childRunId: "run-direct-thread-bound",
         requesterOrigin: {
           channel: "discord",
@@ -753,7 +737,6 @@ describe("subagent announce formatting", () => {
         },
       },
       {
-      name: "requester origin has no threadId",
         childRunId: "run-direct-thread-bound-single",
         requesterOrigin: {
           channel: "discord",
@@ -762,7 +745,6 @@ describe("subagent announce formatting", () => {
         },
       },
       {
-      name: "requester threadId does not match",
         childRunId: "run-direct-thread-no-match",
         requesterOrigin: {
           channel: "discord",
@@ -771,8 +753,10 @@ describe("subagent announce formatting", () => {
           threadId: "999",
         },
       },
-  ])("uses hook-provided thread target when $name", async ({ childRunId, requesterOrigin }) => {
+    ] as const;
-    const { runSubagentAnnounceFlow } = await import("./subagent-announce.js");
+
+    for (const testCase of cases) {
+      sendSpy.mockClear();
       hasSubagentDeliveryTargetHook = true;
       subagentDeliveryTargetHookMock.mockResolvedValueOnce({
         origin: {
@@ -785,10 +769,10 @@ describe("subagent announce formatting", () => {
 
       const didAnnounce = await runSubagentAnnounceFlow({
         childSessionKey: "agent:main:subagent:test",
-      childRunId,
+        childRunId: testCase.childRunId,
         requesterSessionKey: "agent:main:main",
         requesterDisplayKey: "main",
-      requesterOrigin,
+        requesterOrigin: testCase.requesterOrigin,
         ...defaultOutcomeAnnounce,
         expectsCompletionMessage: true,
         spawnMode: "session",
@@ -799,13 +783,13 @@ describe("subagent announce formatting", () => {
         {
           childSessionKey: "agent:main:subagent:test",
           requesterSessionKey: "agent:main:main",
-        requesterOrigin,
+          requesterOrigin: testCase.requesterOrigin,
-        childRunId,
+          childRunId: testCase.childRunId,
           spawnMode: "session",
           expectsCompletionMessage: true,
         },
         {
-        runId: childRunId,
+          runId: testCase.childRunId,
           childSessionKey: "agent:main:subagent:test",
           requesterSessionKey: "agent:main:main",
         },
@@ -818,6 +802,7 @@ describe("subagent announce formatting", () => {
       const message = typeof call?.params?.message === "string" ? call.params.message : "";
       expect(message).toContain("completed this task (session remains active)");
       expect(message).not.toContain("finished");
+    }
   });
 
   it.each([