github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 02:21:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(hooks): replace console logging with proper subsystem logging in loader (openclaw#11029) thanks @shadril238

Browse Source 
Verified:
- pnpm build
- pnpm check
- pnpm test

Co-authored-by: shadril238 <63901551+shadril238@users.noreply.github.com>
Co-authored-by: Tak Hoffman <781889+Takhoffman@users.noreply.github.com>
This commit is contained in:
Shadril Hassan Shifat
2026-02-14 06:21:11 +06:00
committed by GitHub
parent 05524bb5ef
commit 1c928e493d
4 changed files with 22 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/hooks/loader.ts
View File

@@ -9,11 +9,14 @@ import path from "node:path";
import { pathToFileURL } from "node:url";
import type { OpenClawConfig } from "../config/config.js";
import type { InternalHookHandler } from "./internal-hooks.js";
import { createSubsystemLogger } from "../logging/subsystem.js";
import { resolveHookConfig } from "./config.js";
import { shouldIncludeHook } from "./config.js";
import { registerInternalHook } from "./internal-hooks.js";
import { loadWorkspaceHookEntries } from "./workspace.js";
const log = createSubsystemLogger("hooks:loader");
/**
* Load and register all hook handlers
*
@@ -78,16 +81,14 @@ export async function loadInternalHooks(
const handler = mod[exportName];
if (typeof handler !== "function") {
console.error(
`Hook error: Handler '${exportName}' from ${entry.hook.name} is not a function`,
);
log.error(`Handler '${exportName}' from ${entry.hook.name} is not a function`);
continue;
}
// Register for all events listed in metadata
const events = entry.metadata?.events ?? [];
if (events.length === 0) {
console.warn(`Hook warning: Hook '${entry.hook.name}' has no events defined in metadata`);
log.warn(`Hook '${entry.hook.name}' has no events defined in metadata`);
continue;
}
@@ -95,21 +96,19 @@ export async function loadInternalHooks(
registerInternalHook(event, handler as InternalHookHandler);
}
console.log(
log.info(
`Registered hook: ${entry.hook.name} -> ${events.join(", ")}${exportName !== "default" ? ` (export: ${exportName})` : ""}`,
);
loadedCount++;
} catch (err) {
console.error(
`Failed to load hook ${entry.hook.name}:`,
err instanceof Error ? err.message : String(err),
log.error(
`Failed to load hook ${entry.hook.name}: ${err instanceof Error ? err.message : String(err)}`,
);
}
}
} catch (err) {
console.error(
"Failed to load directory-based hooks:",
err instanceof Error ? err.message : String(err),
log.error(
`Failed to load directory-based hooks: ${err instanceof Error ? err.message : String(err)}`,
);
}
@@ -132,20 +131,18 @@ export async function loadInternalHooks(
const handler = mod[exportName];
if (typeof handler !== "function") {
console.error(`Hook error: Handler '${exportName}' from ${modulePath} is not a function`);
log.error(`Handler '${exportName}' from ${modulePath} is not a function`);
continue;
}
// Register the handler
registerInternalHook(handlerConfig.event, handler as InternalHookHandler);
console.log(
log.info(
`Registered hook (legacy): ${handlerConfig.event} -> ${modulePath}${exportName !== "default" ? `#${exportName}` : ""}`,
);
loadedCount++;
} catch (err) {
console.error(
`Failed to load hook handler from ${handlerConfig.module}:`,
err instanceof Error ? err.message : String(err),
log.error(
`Failed to load hook handler from ${handlerConfig.module}: ${err instanceof Error ? err.message : String(err)}`,
);
}
}