github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-09 15:04:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(slack): dedupe slash reply delivery

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-16 01:35:18 +00:00
parent a881bd41eb
commit 1d7b2bc9c8
1 changed files with 22 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

61
src/slack/monitor/slash.ts
View File

@@ -1,5 +1,6 @@
import type { SlackActionMiddlewareArgs, SlackCommandMiddlewareArgs } from "@slack/bolt"; import type { SlackActionMiddlewareArgs, SlackCommandMiddlewareArgs } from "@slack/bolt";
import type { ChatCommandDefinition, CommandArgs } from "../../auto-reply/commands-registry.js"; import type { ChatCommandDefinition, CommandArgs } from "../../auto-reply/commands-registry.js";
import type { ReplyPayload } from "../../auto-reply/types.js";
import type { ResolvedSlackAccount } from "../accounts.js"; import type { ResolvedSlackAccount } from "../accounts.js";
import type { SlackMonitorContext } from "./context.js"; import type { SlackMonitorContext } from "./context.js";
import { formatAllowlistMatchMeta } from "../../channels/allowlist-match.js"; import { formatAllowlistMatchMeta } from "../../channels/allowlist-match.js";
@@ -449,44 +450,7 @@ export async function registerSlackMonitorSlashCommands(params: {
accountId: route.accountId, accountId: route.accountId,
}); });
const { counts } = await dispatchReplyWithDispatcher({ const deliverSlashPayloads = async (replies: ReplyPayload[]) => {
ctx: ctxPayload,
cfg,
dispatcherOptions: {
...prefixOptions,
deliver: async (payload) => {
const [
{ deliverSlackSlashReplies },
{ resolveChunkMode },
{ resolveMarkdownTableMode },
] = await Promise.all([
import("./replies.js"),
import("../../auto-reply/chunk.js"),
import("../../config/markdown-tables.js"),
]);
await deliverSlackSlashReplies({
replies: [payload],
respond,
ephemeral: slashCommand.ephemeral,
textLimit: ctx.textLimit,
chunkMode: resolveChunkMode(cfg, "slack", route.accountId),
tableMode: resolveMarkdownTableMode({
cfg,
channel: "slack",
accountId: route.accountId,
}),
});
},
onError: (err, info) => {
runtime.error?.(danger(`slack slash ${info.kind} reply failed: ${String(err)}`));
},
},
replyOptions: {
skillFilter: channelConfig?.skills,
onModelSelected,
},
});
if (counts.final + counts.tool + counts.block === 0) {
const [{ deliverSlackSlashReplies }, { resolveChunkMode }, { resolveMarkdownTableMode }] = const [{ deliverSlackSlashReplies }, { resolveChunkMode }, { resolveMarkdownTableMode }] =
await Promise.all([ await Promise.all([
import("./replies.js"), import("./replies.js"),
@@ -494,7 +458,7 @@ export async function registerSlackMonitorSlashCommands(params: {
import("../../config/markdown-tables.js"), import("../../config/markdown-tables.js"),
]); ]);
await deliverSlackSlashReplies({ await deliverSlackSlashReplies({
replies: [], replies,
respond, respond,
ephemeral: slashCommand.ephemeral, ephemeral: slashCommand.ephemeral,
textLimit: ctx.textLimit, textLimit: ctx.textLimit,
@@ -505,6 +469,25 @@ export async function registerSlackMonitorSlashCommands(params: {
accountId: route.accountId, accountId: route.accountId,
}), }),
}); });
};
const { counts } = await dispatchReplyWithDispatcher({
ctx: ctxPayload,
cfg,
dispatcherOptions: {
...prefixOptions,
deliver: async (payload) => deliverSlashPayloads([payload]),
onError: (err, info) => {
runtime.error?.(danger(`slack slash ${info.kind} reply failed: ${String(err)}`));
},
},
replyOptions: {
skillFilter: channelConfig?.skills,
onModelSelected,
},
});
if (counts.final + counts.tool + counts.block === 0) {
await deliverSlashPayloads([]);
} }
} catch (err) { } catch (err) {
runtime.error?.(danger(`slack slash handler failed: ${String(err)}`)); runtime.error?.(danger(`slack slash handler failed: ${String(err)}`));