github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 21:28:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): dedupe command config and model test fixtures

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-16 16:32:11 +00:00
parent 130e59a9c0
commit 261f5ee492
6 changed files with 273 additions and 363 deletions
Download Patch File Download Diff File Expand all files Collapse all files

114
src/commands/daemon-install-helpers.e2e.test.ts
View File

@@ -42,20 +42,39 @@ describe("resolveGatewayDevMode", () => {
});
});
function mockNodeGatewayPlanFixture(
params: {
workingDirectory?: string;
version?: string;
supported?: boolean;
warning?: string;
serviceEnvironment?: Record<string, string>;
} = {},
) {
const {
workingDirectory = "/Users/me",
version = "22.0.0",
supported = true,
warning,
serviceEnvironment = { OPENCLAW_PORT: "3000" },
} = params;
mocks.resolvePreferredNodePath.mockResolvedValue("/opt/node");
mocks.resolveGatewayProgramArguments.mockResolvedValue({
programArguments: ["node", "gateway"],
workingDirectory,
});
mocks.resolveSystemNodeInfo.mockResolvedValue({
path: "/opt/node",
version,
supported,
});
mocks.renderSystemNodeWarning.mockReturnValue(warning);
mocks.buildServiceEnvironment.mockReturnValue(serviceEnvironment);
}
describe("buildGatewayInstallPlan", () => {
it("uses provided nodePath and returns plan", async () => {
mocks.resolvePreferredNodePath.mockResolvedValue("/opt/node");
mocks.resolveGatewayProgramArguments.mockResolvedValue({
programArguments: ["node", "gateway"],
workingDirectory: "/Users/me",
});
mocks.resolveSystemNodeInfo.mockResolvedValue({
path: "/opt/node",
version: "22.0.0",
supported: true,
});
mocks.renderSystemNodeWarning.mockReturnValue(undefined);
mocks.buildServiceEnvironment.mockReturnValue({ OPENCLAW_PORT: "3000" });
mockNodeGatewayPlanFixture();
const plan = await buildGatewayInstallPlan({
env: {},
@@ -72,18 +91,13 @@ describe("buildGatewayInstallPlan", () => {
it("emits warnings when renderSystemNodeWarning returns one", async () => {
const warn = vi.fn();
mocks.resolvePreferredNodePath.mockResolvedValue("/opt/node");
mocks.resolveGatewayProgramArguments.mockResolvedValue({
programArguments: ["node", "gateway"],
mockNodeGatewayPlanFixture({
workingDirectory: undefined,
});
mocks.resolveSystemNodeInfo.mockResolvedValue({
path: "/opt/node",
version: "18.0.0",
supported: false,
warning: "Node too old",
serviceEnvironment: {},
});
mocks.renderSystemNodeWarning.mockReturnValue("Node too old");
mocks.buildServiceEnvironment.mockReturnValue({});
await buildGatewayInstallPlan({
env: {},
@@ -97,19 +111,11 @@ describe("buildGatewayInstallPlan", () => {
});
it("merges config env vars into the environment", async () => {
mocks.resolvePreferredNodePath.mockResolvedValue("/opt/node");
mocks.resolveGatewayProgramArguments.mockResolvedValue({
programArguments: ["node", "gateway"],
workingDirectory: "/Users/me",
});
mocks.resolveSystemNodeInfo.mockResolvedValue({
path: "/opt/node",
version: "22.0.0",
supported: true,
});
mocks.buildServiceEnvironment.mockReturnValue({
OPENCLAW_PORT: "3000",
HOME: "/Users/me",
mockNodeGatewayPlanFixture({
serviceEnvironment: {
OPENCLAW_PORT: "3000",
HOME: "/Users/me",
},
});
const plan = await buildGatewayInstallPlan({
@@ -135,17 +141,7 @@ describe("buildGatewayInstallPlan", () => {
});
it("does not include empty config env values", async () => {
mocks.resolvePreferredNodePath.mockResolvedValue("/opt/node");
mocks.resolveGatewayProgramArguments.mockResolvedValue({
programArguments: ["node", "gateway"],
workingDirectory: "/Users/me",
});
mocks.resolveSystemNodeInfo.mockResolvedValue({
path: "/opt/node",
version: "22.0.0",
supported: true,
});
mocks.buildServiceEnvironment.mockReturnValue({ OPENCLAW_PORT: "3000" });
mockNodeGatewayPlanFixture();
const plan = await buildGatewayInstallPlan({
env: {},
@@ -166,17 +162,7 @@ describe("buildGatewayInstallPlan", () => {
});
it("drops whitespace-only config env values", async () => {
mocks.resolvePreferredNodePath.mockResolvedValue("/opt/node");
mocks.resolveGatewayProgramArguments.mockResolvedValue({
programArguments: ["node", "gateway"],
workingDirectory: "/Users/me",
});
mocks.resolveSystemNodeInfo.mockResolvedValue({
path: "/opt/node",
version: "22.0.0",
supported: true,
});
mocks.buildServiceEnvironment.mockReturnValue({});
mockNodeGatewayPlanFixture({ serviceEnvironment: {} });
const plan = await buildGatewayInstallPlan({
env: {},
@@ -197,19 +183,11 @@ describe("buildGatewayInstallPlan", () => {
});
it("keeps service env values over config env vars", async () => {
mocks.resolvePreferredNodePath.mockResolvedValue("/opt/node");
mocks.resolveGatewayProgramArguments.mockResolvedValue({
programArguments: ["node", "gateway"],
workingDirectory: "/Users/me",
});
mocks.resolveSystemNodeInfo.mockResolvedValue({
path: "/opt/node",
version: "22.0.0",
supported: true,
});
mocks.buildServiceEnvironment.mockReturnValue({
HOME: "/Users/service",
OPENCLAW_PORT: "3000",
mockNodeGatewayPlanFixture({
serviceEnvironment: {
HOME: "/Users/service",
OPENCLAW_PORT: "3000",
},
});
const plan = await buildGatewayInstallPlan({