refactor(test): dedupe command config and model test fixtures

This commit is contained in:
Peter Steinberger
2026-02-16 16:32:11 +00:00
parent 130e59a9c0
commit 261f5ee492
6 changed files with 273 additions and 363 deletions

View File

@@ -33,6 +33,22 @@ function makePrompter(): WizardPrompter {
};
}
function expectPrimaryModelChanged(
applied: { changed: boolean; next: OpenClawConfig },
primary: string,
) {
expect(applied.changed).toBe(true);
expect(applied.next.agents?.defaults?.model).toEqual({ primary });
}
function expectConfigUnchanged(
applied: { changed: boolean; next: OpenClawConfig },
cfg: OpenClawConfig,
) {
expect(applied.changed).toBe(false);
expect(applied.next).toEqual(cfg);
}
describe("applyDefaultModelChoice", () => {
it("ensures allowlist entry exists when returning an agent override", async () => {
const defaultModel = "vercel-ai-gateway/anthropic/claude-opus-4.6";
@@ -97,10 +113,7 @@ describe("applyGoogleGeminiModelDefault", () => {
it("sets gemini default when model is unset", () => {
const cfg: OpenClawConfig = { agents: { defaults: {} } };
const applied = applyGoogleGeminiModelDefault(cfg);
expect(applied.changed).toBe(true);
expect(applied.next.agents?.defaults?.model).toEqual({
primary: GOOGLE_GEMINI_DEFAULT_MODEL,
});
expectPrimaryModelChanged(applied, GOOGLE_GEMINI_DEFAULT_MODEL);
});
it("overrides existing model", () => {
@@ -108,10 +121,7 @@ describe("applyGoogleGeminiModelDefault", () => {
agents: { defaults: { model: "anthropic/claude-opus-4-5" } },
};
const applied = applyGoogleGeminiModelDefault(cfg);
expect(applied.changed).toBe(true);
expect(applied.next.agents?.defaults?.model).toEqual({
primary: GOOGLE_GEMINI_DEFAULT_MODEL,
});
expectPrimaryModelChanged(applied, GOOGLE_GEMINI_DEFAULT_MODEL);
});
it("no-ops when already gemini default", () => {
@@ -119,8 +129,7 @@ describe("applyGoogleGeminiModelDefault", () => {
agents: { defaults: { model: GOOGLE_GEMINI_DEFAULT_MODEL } },
};
const applied = applyGoogleGeminiModelDefault(cfg);
expect(applied.changed).toBe(false);
expect(applied.next).toEqual(cfg);
expectConfigUnchanged(applied, cfg);
});
});
@@ -162,10 +171,7 @@ describe("applyOpenAICodexModelDefault", () => {
it("sets openai-codex default when model is unset", () => {
const cfg: OpenClawConfig = { agents: { defaults: {} } };
const applied = applyOpenAICodexModelDefault(cfg);
expect(applied.changed).toBe(true);
expect(applied.next.agents?.defaults?.model).toEqual({
primary: OPENAI_CODEX_DEFAULT_MODEL,
});
expectPrimaryModelChanged(applied, OPENAI_CODEX_DEFAULT_MODEL);
});
it("sets openai-codex default when model is openai/*", () => {
@@ -173,10 +179,7 @@ describe("applyOpenAICodexModelDefault", () => {
agents: { defaults: { model: OPENAI_DEFAULT_MODEL } },
};
const applied = applyOpenAICodexModelDefault(cfg);
expect(applied.changed).toBe(true);
expect(applied.next.agents?.defaults?.model).toEqual({
primary: OPENAI_CODEX_DEFAULT_MODEL,
});
expectPrimaryModelChanged(applied, OPENAI_CODEX_DEFAULT_MODEL);
});
it("does not override openai-codex/*", () => {
@@ -184,8 +187,7 @@ describe("applyOpenAICodexModelDefault", () => {
agents: { defaults: { model: OPENAI_CODEX_DEFAULT_MODEL } },
};
const applied = applyOpenAICodexModelDefault(cfg);
expect(applied.changed).toBe(false);
expect(applied.next).toEqual(cfg);
expectConfigUnchanged(applied, cfg);
});
it("does not override non-openai models", () => {
@@ -193,8 +195,7 @@ describe("applyOpenAICodexModelDefault", () => {
agents: { defaults: { model: "anthropic/claude-opus-4-5" } },
};
const applied = applyOpenAICodexModelDefault(cfg);
expect(applied.changed).toBe(false);
expect(applied.next).toEqual(cfg);
expectConfigUnchanged(applied, cfg);
});
});
@@ -202,10 +203,7 @@ describe("applyOpencodeZenModelDefault", () => {
it("sets opencode default when model is unset", () => {
const cfg: OpenClawConfig = { agents: { defaults: {} } };
const applied = applyOpencodeZenModelDefault(cfg);
expect(applied.changed).toBe(true);
expect(applied.next.agents?.defaults?.model).toEqual({
primary: OPENCODE_ZEN_DEFAULT_MODEL,
});
expectPrimaryModelChanged(applied, OPENCODE_ZEN_DEFAULT_MODEL);
});
it("overrides existing model", () => {
@@ -213,10 +211,7 @@ describe("applyOpencodeZenModelDefault", () => {
agents: { defaults: { model: "anthropic/claude-opus-4-5" } },
} as OpenClawConfig;
const applied = applyOpencodeZenModelDefault(cfg);
expect(applied.changed).toBe(true);
expect(applied.next.agents?.defaults?.model).toEqual({
primary: OPENCODE_ZEN_DEFAULT_MODEL,
});
expectPrimaryModelChanged(applied, OPENCODE_ZEN_DEFAULT_MODEL);
});
it("no-ops when already opencode-zen default", () => {
@@ -224,8 +219,7 @@ describe("applyOpencodeZenModelDefault", () => {
agents: { defaults: { model: OPENCODE_ZEN_DEFAULT_MODEL } },
} as OpenClawConfig;
const applied = applyOpencodeZenModelDefault(cfg);
expect(applied.changed).toBe(false);
expect(applied.next).toEqual(cfg);
expectConfigUnchanged(applied, cfg);
});
it("no-ops when already legacy opencode-zen default", () => {
@@ -233,8 +227,7 @@ describe("applyOpencodeZenModelDefault", () => {
agents: { defaults: { model: "opencode-zen/claude-opus-4-5" } },
} as OpenClawConfig;
const applied = applyOpencodeZenModelDefault(cfg);
expect(applied.changed).toBe(false);
expect(applied.next).toEqual(cfg);
expectConfigUnchanged(applied, cfg);
});
it("preserves fallbacks when setting primary", () => {