test: consolidate sandbox docker merge scenarios

This commit is contained in:
Peter Steinberger
2026-02-23 22:01:22 +00:00
parent 8b192beaaf
commit 287586206c

View File

@@ -42,55 +42,67 @@ describe("sandbox config merges", () => {
}); });
}); });
it("merges sandbox docker binds (global + agent combined)", async () => { it("resolves docker binds and shared-scope override behavior", async () => {
const resolved = resolveSandboxDockerConfig({ for (const scenario of [
scope: "agent", {
name: "merges sandbox docker binds (global + agent combined)",
input: {
scope: "agent" as const,
globalDocker: { globalDocker: {
binds: ["/var/run/docker.sock:/var/run/docker.sock"], binds: ["/var/run/docker.sock:/var/run/docker.sock"],
}, },
agentDocker: { agentDocker: {
binds: ["/home/user/source:/source:rw"], binds: ["/home/user/source:/source:rw"],
}, },
}); },
assert: (resolved: ReturnType<typeof resolveSandboxDockerConfig>) => {
expect(resolved.binds).toEqual([ expect(resolved.binds).toEqual([
"/var/run/docker.sock:/var/run/docker.sock", "/var/run/docker.sock:/var/run/docker.sock",
"/home/user/source:/source:rw", "/home/user/source:/source:rw",
]); ]);
}); },
},
it("returns undefined binds when neither global nor agent has binds", async () => { {
const resolved = resolveSandboxDockerConfig({ name: "returns undefined binds when neither global nor agent has binds",
scope: "agent", input: {
scope: "agent" as const,
globalDocker: {}, globalDocker: {},
agentDocker: {}, agentDocker: {},
}); },
assert: (resolved: ReturnType<typeof resolveSandboxDockerConfig>) => {
expect(resolved.binds).toBeUndefined(); expect(resolved.binds).toBeUndefined();
}); },
},
it("ignores agent binds under shared scope", async () => { {
const resolved = resolveSandboxDockerConfig({ name: "ignores agent binds under shared scope",
scope: "shared", input: {
scope: "shared" as const,
globalDocker: { globalDocker: {
binds: ["/var/run/docker.sock:/var/run/docker.sock"], binds: ["/var/run/docker.sock:/var/run/docker.sock"],
}, },
agentDocker: { agentDocker: {
binds: ["/home/user/source:/source:rw"], binds: ["/home/user/source:/source:rw"],
}, },
}); },
assert: (resolved: ReturnType<typeof resolveSandboxDockerConfig>) => {
expect(resolved.binds).toEqual(["/var/run/docker.sock:/var/run/docker.sock"]); expect(resolved.binds).toEqual(["/var/run/docker.sock:/var/run/docker.sock"]);
}); },
},
it("ignores agent docker overrides under shared scope", async () => { {
const resolved = resolveSandboxDockerConfig({ name: "ignores agent docker overrides under shared scope",
scope: "shared", input: {
scope: "shared" as const,
globalDocker: { image: "global" }, globalDocker: { image: "global" },
agentDocker: { image: "agent" }, agentDocker: { image: "agent" },
}); },
assert: (resolved: ReturnType<typeof resolveSandboxDockerConfig>) => {
expect(resolved.image).toBe("global"); expect(resolved.image).toBe("global");
},
},
]) {
const resolved = resolveSandboxDockerConfig(scenario.input);
scenario.assert(resolved);
}
}); });
it("applies per-agent browser and prune overrides (ignored under shared scope)", async () => { it("applies per-agent browser and prune overrides (ignored under shared scope)", async () => {