github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 03:01:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): dedupe ghost reminder assertions

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-15 15:40:43 +00:00
parent d979c6c089
commit 2b143de554
1 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/infra/heartbeat-runner.ghost-reminder.test.ts
View File

@@ -70,6 +70,22 @@ describe("Ghost reminder bug (issue #13317)", () => {
return { cfg, sessionKey }; return { cfg, sessionKey };
}; };
const expectCronEventPrompt = (
getReplySpy: { mock: { calls: unknown[][] } },
reminderText: string,
) => {
expect(getReplySpy).toHaveBeenCalledTimes(1);
const calledCtx = (getReplySpy.mock.calls[0]?.[0] ?? null) as {
Provider?: string;
Body?: string;
} | null;
expect(calledCtx?.Provider).toBe("cron-event");
expect(calledCtx?.Body).toContain("scheduled reminder has been triggered");
expect(calledCtx?.Body).toContain(reminderText);
expect(calledCtx?.Body).not.toContain("HEARTBEAT_OK");
expect(calledCtx?.Body).not.toContain("heartbeat poll");
};
it("does not use CRON_EVENT_PROMPT when only a HEARTBEAT_OK event is present", async () => { it("does not use CRON_EVENT_PROMPT when only a HEARTBEAT_OK event is present", async () => {
const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-ghost-")); const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-ghost-"));
const sendTelegram = vi.fn().mockResolvedValue({ const sendTelegram = vi.fn().mockResolvedValue({
@@ -131,13 +147,7 @@ describe("Ghost reminder bug (issue #13317)", () => {
}); });
expect(result.status).toBe("ran"); expect(result.status).toBe("ran");
expect(getReplySpy).toHaveBeenCalledTimes(1); expectCronEventPrompt(getReplySpy, "Reminder: Check Base Scout results");
const calledCtx = getReplySpy.mock.calls[0]?.[0];
expect(calledCtx?.Provider).toBe("cron-event");
expect(calledCtx?.Body).toContain("scheduled reminder has been triggered");
expect(calledCtx?.Body).toContain("Reminder: Check Base Scout results");
expect(calledCtx?.Body).not.toContain("HEARTBEAT_OK");
expect(calledCtx?.Body).not.toContain("heartbeat poll");
expect(sendTelegram).toHaveBeenCalled(); expect(sendTelegram).toHaveBeenCalled();
} finally { } finally {
await fs.rm(tmpDir, { recursive: true, force: true }); await fs.rm(tmpDir, { recursive: true, force: true });
@@ -169,13 +179,7 @@ describe("Ghost reminder bug (issue #13317)", () => {
}); });
expect(result.status).toBe("ran"); expect(result.status).toBe("ran");
expect(getReplySpy).toHaveBeenCalledTimes(1); expectCronEventPrompt(getReplySpy, "Reminder: Check Base Scout results");
const calledCtx = getReplySpy.mock.calls[0]?.[0];
expect(calledCtx?.Provider).toBe("cron-event");
expect(calledCtx?.Body).toContain("scheduled reminder has been triggered");
expect(calledCtx?.Body).toContain("Reminder: Check Base Scout results");
expect(calledCtx?.Body).not.toContain("HEARTBEAT_OK");
expect(calledCtx?.Body).not.toContain("heartbeat poll");
expect(sendTelegram).toHaveBeenCalled(); expect(sendTelegram).toHaveBeenCalled();
} finally { } finally {
await fs.rm(tmpDir, { recursive: true, force: true }); await fs.rm(tmpDir, { recursive: true, force: true });