fix(daemon): default NODE_USE_SYSTEM_CA=1 on macOS

This commit is contained in:
magos-minor
2026-03-02 13:52:31 -08:00
committed by Peter Steinberger
parent 19fafed11d
commit 350ac0d824
2 changed files with 56 additions and 0 deletions

View File

@@ -354,6 +354,33 @@ describe("buildServiceEnvironment", () => {
});
expect(env.NODE_EXTRA_CA_CERTS).toBe("/custom/certs/ca.pem");
});
it("defaults NODE_USE_SYSTEM_CA=1 on macOS", () => {
const env = buildServiceEnvironment({
env: { HOME: "/home/user" },
port: 18789,
platform: "darwin",
});
expect(env.NODE_USE_SYSTEM_CA).toBe("1");
});
it("does not default NODE_USE_SYSTEM_CA on non-macOS", () => {
const env = buildServiceEnvironment({
env: { HOME: "/home/user" },
port: 18789,
platform: "linux",
});
expect(env.NODE_USE_SYSTEM_CA).toBeUndefined();
});
it("respects user-provided NODE_USE_SYSTEM_CA over the default", () => {
const env = buildServiceEnvironment({
env: { HOME: "/home/user", NODE_USE_SYSTEM_CA: "0" },
port: 18789,
platform: "darwin",
});
expect(env.NODE_USE_SYSTEM_CA).toBe("0");
});
});
describe("buildNodeServiceEnvironment", () => {
@@ -449,6 +476,30 @@ describe("buildNodeServiceEnvironment", () => {
});
expect(env.NODE_EXTRA_CA_CERTS).toBe("/custom/certs/ca.pem");
});
it("defaults NODE_USE_SYSTEM_CA=1 on macOS for node services", () => {
const env = buildNodeServiceEnvironment({
env: { HOME: "/home/user" },
platform: "darwin",
});
expect(env.NODE_USE_SYSTEM_CA).toBe("1");
});
it("does not default NODE_USE_SYSTEM_CA on non-macOS for node services", () => {
const env = buildNodeServiceEnvironment({
env: { HOME: "/home/user" },
platform: "linux",
});
expect(env.NODE_USE_SYSTEM_CA).toBeUndefined();
});
it("respects user-provided NODE_USE_SYSTEM_CA for node services", () => {
const env = buildNodeServiceEnvironment({
env: { HOME: "/home/user", NODE_USE_SYSTEM_CA: "0" },
platform: "darwin",
});
expect(env.NODE_USE_SYSTEM_CA).toBe("0");
});
});
describe("resolveGatewayStateDir", () => {