fix(tui): strip inbound metadata blocks from user messages (clean rewrite) (#22345)

* fix(tui): strip inbound metadata blocks from user text

* chore: clean up metadata-strip format and changelog credit

* chore: format tui metadata-strip tests

* test: align metadata-strip regression expectations

* refactor: reuse canonical inbound metadata stripper

* test: allow tmp media fixture paths in media-understanding tests

* refactor: reuse canonical inbound metadata stripper

* format: fix changelog blank line after headings

* test: fix unrelated check typing regressions

* test: align memory async mock embedding signatures

* test: avoid tsgo mock typing pitfall

* test: restore async search mock typings in merge tree

* test: trigger ci rerun without behavior change

* chore: dedupe todays changelog entries

* fix: dedupe sqlite mock keys in qmd manager test

* Update qmd-manager.test.ts

* test: align chat metadata sanitization expectation

src/gateway/chat-sanitize.test.ts

@@ -59,15 +59,13 @@ describe("stripEnvelopeFromMessage", () => {
     expect(result.content).toBe("Actual user message");
   });
 
-  test("does not strip metadata-like blocks that are not a prefix", () => {
+  test("strips metadata-like blocks even when not a prefix", () => {
     const input = {
       role: "user",
       content:
         'Actual text\nConversation info (untrusted metadata):\n```json\n{"message_id": "123"}\n```\n\nFollow-up',
     };
     const result = stripEnvelopeFromMessage(input) as { content?: string };
-    expect(result.content).toBe(
-      'Actual text\nConversation info (untrusted metadata):\n```json\n{"message_id": "123"}\n```\n\nFollow-up',
-    );
+    expect(result.content).toBe("Actual text\n\nFollow-up");
   });
 });

src/gateway/chat-sanitize.ts

@@ -1,8 +1,5 @@
-import {
-  stripEnvelope,
-  stripInboundMetadataBlocks,
-  stripMessageIdHints,
-} from "../shared/chat-envelope.js";
+import { stripInboundMetadata } from "../auto-reply/reply/strip-inbound-meta.js";
+import { stripEnvelope, stripMessageIdHints } from "../shared/chat-envelope.js";
 
 export { stripEnvelope };
 
@@ -16,7 +13,7 @@ function stripEnvelopeFromContent(content: unknown[]): { content: unknown[]; cha
     if (entry.type !== "text" || typeof entry.text !== "string") {
       return item;
     }
-    const stripped = stripMessageIdHints(stripEnvelope(stripInboundMetadataBlocks(entry.text)));
+    const stripped = stripMessageIdHints(stripEnvelope(stripInboundMetadata(entry.text)));
     if (stripped === entry.text) {
       return item;
     }
@@ -43,7 +40,7 @@ export function stripEnvelopeFromMessage(message: unknown): unknown {
   const next: Record<string, unknown> = { ...entry };
 
   if (typeof entry.content === "string") {
-    const stripped = stripMessageIdHints(stripEnvelope(stripInboundMetadataBlocks(entry.content)));
+    const stripped = stripMessageIdHints(stripEnvelope(stripInboundMetadata(entry.content)));
     if (stripped !== entry.content) {
       next.content = stripped;
       changed = true;
@@ -55,7 +52,7 @@ export function stripEnvelopeFromMessage(message: unknown): unknown {
       changed = true;
     }
   } else if (typeof entry.text === "string") {
-    const stripped = stripMessageIdHints(stripEnvelope(stripInboundMetadataBlocks(entry.text)));
+    const stripped = stripMessageIdHints(stripEnvelope(stripInboundMetadata(entry.text)));
     if (stripped !== entry.text) {
       next.text = stripped;
       changed = true;

src/gateway/server.chat.gateway-server-chat-b.e2e.test.ts

@@ -150,6 +150,7 @@ describe("gateway server chat", () => {
         let capturedOpts: GetReplyOptions | undefined;
         spy.mockImplementationOnce(async (_ctx: unknown, opts?: GetReplyOptions) => {
           capturedOpts = opts;
+          return undefined;
         });
 
         const sendRes = await rpcReq(ws, "chat.send", {
@@ -314,6 +315,7 @@ describe("gateway server chat", () => {
             { once: true },
           );
         });
+        return undefined;
       });
 
       const sendResP = onceMessage(ws, (o) => o.type === "res" && o.id === "send-abort-1", 8_000);