github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-10 22:04:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(outbound): return error instead of silently redirecting to allowList[0] (#13578)

Browse Source
This commit is contained in:
Marcus Castro
2026-02-13 01:20:03 -03:00
committed by GitHub
parent a43136c85e
commit 39ee708df6
11 changed files with 392 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/infra/outbound/targets.test.ts
View File

@@ -16,7 +16,7 @@ describe("resolveOutboundTarget", () => {
);
});
it("falls back to whatsapp allowFrom via config", () => {
it("rejects whatsapp with empty target even when allowFrom configured", () => {
const cfg: OpenClawConfig = {
channels: { whatsapp: { allowFrom: ["+1555"] } },
};
@@ -26,7 +26,10 @@ describe("resolveOutboundTarget", () => {
cfg,
mode: "explicit",
});
expect(res).toEqual({ ok: true, to: "+1555" });
expect(res.ok).toBe(false);
if (!res.ok) {
expect(res.error.message).toContain("WhatsApp");
}
});
it.each([
@@ -49,18 +52,18 @@ describe("resolveOutboundTarget", () => {
expected: { ok: true as const, to: "120363401234567890@g.us" },
},
{
name: "falls back to whatsapp allowFrom",
name: "rejects whatsapp with empty target and allowFrom (no silent fallback)",
input: { channel: "whatsapp" as const, to: "", allowFrom: ["+1555"] },
expected: { ok: true as const, to: "+1555" },
expectedErrorIncludes: "WhatsApp",
},
{
name: "normalizes whatsapp allowFrom fallback targets",
name: "rejects whatsapp with empty target and prefixed allowFrom (no silent fallback)",
input: {
channel: "whatsapp" as const,
to: "",
allowFrom: ["whatsapp:(555) 123-4567"],
},
expected: { ok: true as const, to: "+5551234567" },
expectedErrorIncludes: "WhatsApp",
},
{
name: "rejects invalid whatsapp target",