refactor(core): extract shared dedup helpers

src/auto-reply/reply/get-reply.message-hooks.test.ts

@@ -1,5 +1,6 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import type { MsgContext } from "../templating.js";
+import { registerGetReplyCommonMocks } from "./get-reply.test-mocks.js";
 
 const mocks = vi.hoisted(() => ({
   applyMediaUnderstanding: vi.fn(async (..._args: unknown[]) => undefined),
@@ -10,28 +11,8 @@ const mocks = vi.hoisted(() => ({
   initSessionState: vi.fn(),
 }));
 
-vi.mock("../../agents/agent-scope.js", () => ({
-  resolveAgentDir: vi.fn(() => "/tmp/agent"),
-  resolveAgentWorkspaceDir: vi.fn(() => "/tmp/workspace"),
-  resolveSessionAgentId: vi.fn(() => "main"),
-  resolveAgentSkillsFilter: vi.fn(() => undefined),
-}));
-vi.mock("../../agents/model-selection.js", () => ({
-  resolveModelRefFromString: vi.fn(() => null),
-}));
-vi.mock("../../agents/timeout.js", () => ({
-  resolveAgentTimeoutMs: vi.fn(() => 60000),
-}));
-vi.mock("../../agents/workspace.js", () => ({
-  DEFAULT_AGENT_WORKSPACE_DIR: "/tmp/workspace",
-  ensureAgentWorkspace: vi.fn(async () => ({ dir: "/tmp/workspace" })),
-}));
-vi.mock("../../channels/model-overrides.js", () => ({
-  resolveChannelModelOverride: vi.fn(() => undefined),
-}));
-vi.mock("../../config/config.js", () => ({
-  loadConfig: vi.fn(() => ({})),
-}));
+registerGetReplyCommonMocks();
+
 vi.mock("../../globals.js", () => ({
   logVerbose: vi.fn(),
 }));
@@ -45,55 +26,18 @@ vi.mock("../../link-understanding/apply.js", () => ({
 vi.mock("../../media-understanding/apply.js", () => ({
   applyMediaUnderstanding: mocks.applyMediaUnderstanding,
 }));
-vi.mock("../../runtime.js", () => ({
-  defaultRuntime: { log: vi.fn() },
-}));
-vi.mock("../command-auth.js", () => ({
-  resolveCommandAuthorization: vi.fn(() => ({ isAuthorizedSender: true })),
-}));
 vi.mock("./commands-core.js", () => ({
   emitResetCommandHooks: vi.fn(async () => undefined),
 }));
-vi.mock("./directive-handling.js", () => ({
-  resolveDefaultModel: vi.fn(() => ({
-    defaultProvider: "openai",
-    defaultModel: "gpt-4o-mini",
-    aliasIndex: new Map(),
-  })),
-}));
 vi.mock("./get-reply-directives.js", () => ({
   resolveReplyDirectives: mocks.resolveReplyDirectives,
 }));
 vi.mock("./get-reply-inline-actions.js", () => ({
   handleInlineActions: vi.fn(async () => ({ kind: "reply", reply: { text: "ok" } })),
 }));
-vi.mock("./get-reply-run.js", () => ({
-  runPreparedReply: vi.fn(async () => undefined),
-}));
-vi.mock("./inbound-context.js", () => ({
-  finalizeInboundContext: vi.fn((ctx: unknown) => ctx),
-}));
-vi.mock("./session-reset-model.js", () => ({
-  applyResetModelOverride: vi.fn(async () => undefined),
-}));
 vi.mock("./session.js", () => ({
   initSessionState: mocks.initSessionState,
 }));
-vi.mock("./stage-sandbox-media.js", () => ({
-  stageSandboxMedia: vi.fn(async () => undefined),
-}));
-vi.mock("./typing.js", () => ({
-  createTypingController: vi.fn(() => ({
-    onReplyStart: async () => undefined,
-    startTypingLoop: async () => undefined,
-    startTypingOnText: async () => undefined,
-    refreshTypingTtl: () => undefined,
-    isActive: () => false,
-    markRunComplete: () => undefined,
-    markDispatchIdle: () => undefined,
-    cleanup: () => undefined,
-  })),
-}));
 
 const { getReplyFromConfig } = await import("./get-reply.js");
 

src/auto-reply/reply/get-reply.reset-hooks-fallback.test.ts

@@ -1,5 +1,6 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import type { MsgContext } from "../templating.js";
+import { registerGetReplyCommonMocks } from "./get-reply.test-mocks.js";
 
 const mocks = vi.hoisted(() => ({
   resolveReplyDirectives: vi.fn(),
@@ -8,83 +9,26 @@ const mocks = vi.hoisted(() => ({
   initSessionState: vi.fn(),
 }));
 
-vi.mock("../../agents/agent-scope.js", () => ({
-  resolveAgentDir: vi.fn(() => "/tmp/agent"),
-  resolveAgentWorkspaceDir: vi.fn(() => "/tmp/workspace"),
-  resolveSessionAgentId: vi.fn(() => "main"),
-  resolveAgentSkillsFilter: vi.fn(() => undefined),
-}));
-vi.mock("../../agents/model-selection.js", () => ({
-  resolveModelRefFromString: vi.fn(() => null),
-}));
-vi.mock("../../agents/timeout.js", () => ({
-  resolveAgentTimeoutMs: vi.fn(() => 60000),
-}));
-vi.mock("../../agents/workspace.js", () => ({
-  DEFAULT_AGENT_WORKSPACE_DIR: "/tmp/workspace",
-  ensureAgentWorkspace: vi.fn(async () => ({ dir: "/tmp/workspace" })),
-}));
-vi.mock("../../channels/model-overrides.js", () => ({
-  resolveChannelModelOverride: vi.fn(() => undefined),
-}));
-vi.mock("../../config/config.js", () => ({
-  loadConfig: vi.fn(() => ({})),
-}));
+registerGetReplyCommonMocks();
+
 vi.mock("../../link-understanding/apply.js", () => ({
   applyLinkUnderstanding: vi.fn(async () => undefined),
 }));
 vi.mock("../../media-understanding/apply.js", () => ({
   applyMediaUnderstanding: vi.fn(async () => undefined),
 }));
-vi.mock("../../runtime.js", () => ({
-  defaultRuntime: { log: vi.fn() },
-}));
-vi.mock("../command-auth.js", () => ({
-  resolveCommandAuthorization: vi.fn(() => ({ isAuthorizedSender: true })),
-}));
 vi.mock("./commands-core.js", () => ({
   emitResetCommandHooks: (...args: unknown[]) => mocks.emitResetCommandHooks(...args),
 }));
-vi.mock("./directive-handling.js", () => ({
-  resolveDefaultModel: vi.fn(() => ({
-    defaultProvider: "openai",
-    defaultModel: "gpt-4o-mini",
-    aliasIndex: new Map(),
-  })),
-}));
 vi.mock("./get-reply-directives.js", () => ({
   resolveReplyDirectives: (...args: unknown[]) => mocks.resolveReplyDirectives(...args),
 }));
 vi.mock("./get-reply-inline-actions.js", () => ({
   handleInlineActions: (...args: unknown[]) => mocks.handleInlineActions(...args),
 }));
-vi.mock("./get-reply-run.js", () => ({
-  runPreparedReply: vi.fn(async () => undefined),
-}));
-vi.mock("./inbound-context.js", () => ({
-  finalizeInboundContext: vi.fn((ctx: unknown) => ctx),
-}));
-vi.mock("./session-reset-model.js", () => ({
-  applyResetModelOverride: vi.fn(async () => undefined),
-}));
 vi.mock("./session.js", () => ({
   initSessionState: (...args: unknown[]) => mocks.initSessionState(...args),
 }));
-vi.mock("./stage-sandbox-media.js", () => ({
-  stageSandboxMedia: vi.fn(async () => undefined),
-}));
-vi.mock("./typing.js", () => ({
-  createTypingController: vi.fn(() => ({
-    onReplyStart: async () => undefined,
-    startTypingLoop: async () => undefined,
-    startTypingOnText: async () => undefined,
-    refreshTypingTtl: () => undefined,
-    isActive: () => false,
-    markRunComplete: () => undefined,
-    markDispatchIdle: () => undefined,
-    cleanup: () => undefined,
-  })),
-}));
 
 const { getReplyFromConfig } = await import("./get-reply.js");
 

src/auto-reply/reply/get-reply.test-mocks.ts

@@ -0,0 +1,63 @@
+import { vi } from "vitest";
+
+export function registerGetReplyCommonMocks(): void {
+  vi.mock("../../agents/agent-scope.js", () => ({
+    resolveAgentDir: vi.fn(() => "/tmp/agent"),
+    resolveAgentWorkspaceDir: vi.fn(() => "/tmp/workspace"),
+    resolveSessionAgentId: vi.fn(() => "main"),
+    resolveAgentSkillsFilter: vi.fn(() => undefined),
+  }));
+  vi.mock("../../agents/model-selection.js", () => ({
+    resolveModelRefFromString: vi.fn(() => null),
+  }));
+  vi.mock("../../agents/timeout.js", () => ({
+    resolveAgentTimeoutMs: vi.fn(() => 60000),
+  }));
+  vi.mock("../../agents/workspace.js", () => ({
+    DEFAULT_AGENT_WORKSPACE_DIR: "/tmp/workspace",
+    ensureAgentWorkspace: vi.fn(async () => ({ dir: "/tmp/workspace" })),
+  }));
+  vi.mock("../../channels/model-overrides.js", () => ({
+    resolveChannelModelOverride: vi.fn(() => undefined),
+  }));
+  vi.mock("../../config/config.js", () => ({
+    loadConfig: vi.fn(() => ({})),
+  }));
+  vi.mock("../../runtime.js", () => ({
+    defaultRuntime: { log: vi.fn() },
+  }));
+  vi.mock("../command-auth.js", () => ({
+    resolveCommandAuthorization: vi.fn(() => ({ isAuthorizedSender: true })),
+  }));
+  vi.mock("./directive-handling.js", () => ({
+    resolveDefaultModel: vi.fn(() => ({
+      defaultProvider: "openai",
+      defaultModel: "gpt-4o-mini",
+      aliasIndex: new Map(),
+    })),
+  }));
+  vi.mock("./get-reply-run.js", () => ({
+    runPreparedReply: vi.fn(async () => undefined),
+  }));
+  vi.mock("./inbound-context.js", () => ({
+    finalizeInboundContext: vi.fn((ctx: unknown) => ctx),
+  }));
+  vi.mock("./session-reset-model.js", () => ({
+    applyResetModelOverride: vi.fn(async () => undefined),
+  }));
+  vi.mock("./stage-sandbox-media.js", () => ({
+    stageSandboxMedia: vi.fn(async () => undefined),
+  }));
+  vi.mock("./typing.js", () => ({
+    createTypingController: vi.fn(() => ({
+      onReplyStart: async () => undefined,
+      startTypingLoop: async () => undefined,
+      startTypingOnText: async () => undefined,
+      refreshTypingTtl: () => undefined,
+      isActive: () => false,
+      markRunComplete: () => undefined,
+      markDispatchIdle: () => undefined,
+      cleanup: () => undefined,
+    })),
+  }));
+}