From 3eabd538980e6695b0d58e0be565a5a56efc6658 Mon Sep 17 00:00:00 2001
From: Sahil Satralkar <62758655+sahilsatralkar@users.noreply.github.com>
Date: Mon, 23 Feb 2026 21:50:45 +0530
Subject: [PATCH] Tests: add regressions for subagent completion fallback and
 explicit direct route

---
 src/agents/subagent-announce.format.test.ts | 71 +++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/src/agents/subagent-announce.format.test.ts b/src/agents/subagent-announce.format.test.ts
index a612e9fca02..b486dff75c8 100644
--- a/src/agents/subagent-announce.format.test.ts
+++ b/src/agents/subagent-announce.format.test.ts
@@ -993,6 +993,77 @@ describe("subagent announce formatting", () => {
     });
   });
 
+  it("falls back to internal requester-session injection when completion route is missing", async () => {
+    embeddedRunMock.isEmbeddedPiRunActive.mockReturnValue(false);
+    embeddedRunMock.isEmbeddedPiRunStreaming.mockReturnValue(false);
+    sessionStore = {
+      "agent:main:main": {
+        sessionId: "requester-session-no-route",
+      },
+    };
+    agentSpy.mockImplementationOnce(async (req: AgentCallRequest) => {
+      const deliver = req.params?.deliver;
+      const channel = req.params?.channel;
+      if (deliver === true && typeof channel !== "string") {
+        throw new Error("Channel is required when deliver=true");
+      }
+      return { runId: "run-main", status: "ok" };
+    });
+
+    const didAnnounce = await runSubagentAnnounceFlow({
+      childSessionKey: "agent:main:subagent:worker",
+      childRunId: "run-completion-missing-route",
+      requesterSessionKey: "main",
+      requesterDisplayKey: "main",
+      expectsCompletionMessage: true,
+      ...defaultOutcomeAnnounce,
+    });
+
+    expect(didAnnounce).toBe(true);
+    expect(sendSpy).toHaveBeenCalledTimes(0);
+    expect(agentSpy).toHaveBeenCalledTimes(1);
+    expect(agentSpy.mock.calls[0]?.[0]).toMatchObject({
+      method: "agent",
+      params: {
+        sessionKey: "agent:main:main",
+        deliver: false,
+      },
+    });
+  });
+
+  it("uses direct completion delivery when explicit channel+to route is available", async () => {
+    sessionStore = {
+      "agent:main:main": {
+        sessionId: "requester-session-direct-route",
+      },
+    };
+    agentSpy.mockImplementationOnce(async () => {
+      throw new Error("agent fallback should not run when direct route exists");
+    });
+
+    const didAnnounce = await runSubagentAnnounceFlow({
+      childSessionKey: "agent:main:subagent:worker",
+      childRunId: "run-completion-explicit-route",
+      requesterSessionKey: "main",
+      requesterDisplayKey: "main",
+      requesterOrigin: { channel: "discord", to: "channel:12345", accountId: "acct-1" },
+      expectsCompletionMessage: true,
+      ...defaultOutcomeAnnounce,
+    });
+
+    expect(didAnnounce).toBe(true);
+    expect(sendSpy).toHaveBeenCalledTimes(1);
+    expect(agentSpy).toHaveBeenCalledTimes(0);
+    expect(sendSpy.mock.calls[0]?.[0]).toMatchObject({
+      method: "send",
+      params: {
+        sessionKey: "agent:main:main",
+        channel: "discord",
+        to: "channel:12345",
+      },
+    });
+  });
+
   it("returns failure for completion-mode when direct delivery fails and queue fallback is unavailable", async () => {
     embeddedRunMock.isEmbeddedPiRunActive.mockReturnValue(false);
     embeddedRunMock.isEmbeddedPiRunStreaming.mockReturnValue(false);