github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-10 14:14:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf(test): consolidate inbound access-control suites

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-14 23:25:33 +00:00
parent 5a6fc20bd7
commit 3ec275f0b5
2 changed files with 51 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
src/web/inbound/access-control.pairing.test.ts
View File

@@ -1,65 +0,0 @@
import { beforeEach, describe, expect, it } from "vitest";
import {
sendMessageMock,
setupAccessControlTestHarness,
upsertPairingRequestMock,
} from "./access-control.test-harness.js";
type CheckInboundAccessControl = typeof import("./access-control.js").checkInboundAccessControl;
let checkInboundAccessControl: CheckInboundAccessControl;
setupAccessControlTestHarness();
beforeEach(async () => {
({ checkInboundAccessControl } = await import("./access-control.js"));
});
describe("checkInboundAccessControl", () => {
it("suppresses pairing replies for historical DMs on connect", async () => {
const connectedAtMs = 1_000_000;
const messageTimestampMs = connectedAtMs - 31_000;
const result = await checkInboundAccessControl({
accountId: "default",
from: "+15550001111",
selfE164: "+15550009999",
senderE164: "+15550001111",
group: false,
pushName: "Sam",
isFromMe: false,
messageTimestampMs,
connectedAtMs,
pairingGraceMs: 30_000,
sock: { sendMessage: sendMessageMock },
remoteJid: "15550001111@s.whatsapp.net",
});
expect(result.allowed).toBe(false);
expect(upsertPairingRequestMock).not.toHaveBeenCalled();
expect(sendMessageMock).not.toHaveBeenCalled();
});
it("sends pairing replies for live DMs", async () => {
const connectedAtMs = 1_000_000;
const messageTimestampMs = connectedAtMs - 10_000;
const result = await checkInboundAccessControl({
accountId: "default",
from: "+15550001111",
selfE164: "+15550009999",
senderE164: "+15550001111",
group: false,
pushName: "Sam",
isFromMe: false,
messageTimestampMs,
connectedAtMs,
pairingGraceMs: 30_000,
sock: { sendMessage: sendMessageMock },
remoteJid: "15550001111@s.whatsapp.net",
});
expect(result.allowed).toBe(false);
expect(upsertPairingRequestMock).toHaveBeenCalled();
expect(sendMessageMock).toHaveBeenCalled();
});
});

57
src/web/inbound/access-control.dm-policy.test.ts → src/web/inbound/access-control.test.ts
View File

@@ -1,4 +1,4 @@
import { beforeEach, describe, expect, it } from "vitest"; import { describe, expect, it } from "vitest";
import { import {
sendMessageMock, sendMessageMock,
setAccessControlTestConfig, setAccessControlTestConfig,
@@ -6,13 +6,58 @@ import {
upsertPairingRequestMock, upsertPairingRequestMock,
} from "./access-control.test-harness.js"; } from "./access-control.test-harness.js";
type CheckInboundAccessControl = typeof import("./access-control.js").checkInboundAccessControl;
let checkInboundAccessControl: CheckInboundAccessControl;
setupAccessControlTestHarness(); setupAccessControlTestHarness();
beforeEach(async () => { const { checkInboundAccessControl } = await import("./access-control.js");
({ checkInboundAccessControl } = await import("./access-control.js"));
describe("checkInboundAccessControl pairing grace", () => {
it("suppresses pairing replies for historical DMs on connect", async () => {
const connectedAtMs = 1_000_000;
const messageTimestampMs = connectedAtMs - 31_000;
const result = await checkInboundAccessControl({
accountId: "default",
from: "+15550001111",
selfE164: "+15550009999",
senderE164: "+15550001111",
group: false,
pushName: "Sam",
isFromMe: false,
messageTimestampMs,
connectedAtMs,
pairingGraceMs: 30_000,
sock: { sendMessage: sendMessageMock },
remoteJid: "15550001111@s.whatsapp.net",
});
expect(result.allowed).toBe(false);
expect(upsertPairingRequestMock).not.toHaveBeenCalled();
expect(sendMessageMock).not.toHaveBeenCalled();
});
it("sends pairing replies for live DMs", async () => {
const connectedAtMs = 1_000_000;
const messageTimestampMs = connectedAtMs - 10_000;
const result = await checkInboundAccessControl({
accountId: "default",
from: "+15550001111",
selfE164: "+15550009999",
senderE164: "+15550001111",
group: false,
pushName: "Sam",
isFromMe: false,
messageTimestampMs,
connectedAtMs,
pairingGraceMs: 30_000,
sock: { sendMessage: sendMessageMock },
remoteJid: "15550001111@s.whatsapp.net",
});
expect(result.allowed).toBe(false);
expect(upsertPairingRequestMock).toHaveBeenCalled();
expect(sendMessageMock).toHaveBeenCalled();
});
}); });
describe("WhatsApp dmPolicy precedence", () => { describe("WhatsApp dmPolicy precedence", () => {