feat(cron): enhance delivery modes and job configuration

- Updated isolated cron jobs to support new delivery modes: `announce` and `none`, improving output management.
- Refactored job configuration to remove legacy fields and streamline delivery settings.
- Enhanced the `CronJobEditor` UI to reflect changes in delivery options, including a new segmented control for delivery mode selection.
- Updated documentation to clarify the new delivery configurations and their implications for job execution.
- Improved tests to validate the new delivery behavior and ensure backward compatibility with legacy settings.

This update provides users with greater flexibility in managing how isolated jobs deliver their outputs, enhancing overall usability and clarity in job configurations.
This commit is contained in:
Tyler Yust
2026-02-03 16:53:46 -08:00
committed by Peter Steinberger
parent ab9f06f4ff
commit 3f82daefd8
56 changed files with 917 additions and 1150 deletions

View File

@@ -4,10 +4,8 @@ export type CronDeliveryPlan = {
mode: CronDeliveryMode;
channel: CronMessageChannel;
to?: string;
bestEffort: boolean;
source: "delivery" | "payload";
requested: boolean;
legacyMode?: "explicit" | "auto" | "off";
};
function normalizeChannel(value: unknown): CronMessageChannel | undefined {
@@ -35,19 +33,20 @@ export function resolveCronDeliveryPlan(job: CronJob): CronDeliveryPlan {
const hasDelivery = delivery && typeof delivery === "object";
const rawMode = hasDelivery ? (delivery as { mode?: unknown }).mode : undefined;
const mode =
rawMode === "none" || rawMode === "announce" || rawMode === "deliver" ? rawMode : undefined;
rawMode === "announce"
? "announce"
: rawMode === "none"
? "none"
: rawMode === "deliver"
? "announce"
: undefined;
const payloadChannel = normalizeChannel(payload?.channel);
const payloadTo = normalizeTo(payload?.to);
const payloadBestEffort = payload?.bestEffortDeliver === true;
const deliveryChannel = normalizeChannel(
(delivery as { channel?: unknown } | undefined)?.channel,
);
const deliveryTo = normalizeTo((delivery as { to?: unknown } | undefined)?.to);
const deliveryBestEffortRaw = (delivery as { bestEffort?: unknown } | undefined)?.bestEffort;
const deliveryBestEffort =
typeof deliveryBestEffortRaw === "boolean" ? deliveryBestEffortRaw : undefined;
const channel = (deliveryChannel ?? payloadChannel ?? "last") as CronMessageChannel;
const to = deliveryTo ?? payloadTo;
@@ -57,9 +56,8 @@ export function resolveCronDeliveryPlan(job: CronJob): CronDeliveryPlan {
mode: resolvedMode,
channel,
to,
bestEffort: deliveryBestEffort ?? false,
source: "delivery",
requested: resolvedMode !== "none",
requested: resolvedMode === "announce",
};
}
@@ -69,12 +67,10 @@ export function resolveCronDeliveryPlan(job: CronJob): CronDeliveryPlan {
const requested = legacyMode === "explicit" || (legacyMode === "auto" && hasExplicitTarget);
return {
mode: requested ? "deliver" : "none",
mode: requested ? "announce" : "none",
channel,
to,
bestEffort: payloadBestEffort,
source: "payload",
requested,
legacyMode,
};
}