github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-04-19 06:37:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: skip chmod-dependent backup rotation tests on Windows

Browse Source 
chmod is a no-op on Windows — file permissions always report 0o666
regardless of what was set, so asserting 0o600 will never pass.
This commit is contained in:
Josh Lehman
2026-03-02 15:12:28 -08:00
committed by Peter Steinberger
parent c20ee11348
commit 41bdf2df41
1 changed files with 33 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
src/config/config.backup-rotation.test.ts
View File

@@ -10,6 +10,8 @@ import {
import { withTempHome } from "./test-helpers.js"; import { withTempHome } from "./test-helpers.js";
import type { OpenClawConfig } from "./types.js"; import type { OpenClawConfig } from "./types.js";
const IS_WINDOWS = process.platform === "win32";
describe("config backup rotation", () => { describe("config backup rotation", () => {
it("keeps a 5-deep backup ring for config writes", async () => { it("keeps a 5-deep backup ring for config writes", async () => {
await withTempHome(async () => { await withTempHome(async () => {
@@ -55,7 +57,8 @@ describe("config backup rotation", () => {
}); });
}); });
it("hardenBackupPermissions sets 0o600 on all backup files", async () => { // chmod is a no-op on Windows — 0o600 can never be observed there.
it.skipIf(IS_WINDOWS)("hardenBackupPermissions sets 0o600 on all backup files", async () => {
await withTempHome(async () => { await withTempHome(async () => {
const stateDir = process.env.OPENCLAW_STATE_DIR?.trim(); const stateDir = process.env.OPENCLAW_STATE_DIR?.trim();
if (!stateDir) { if (!stateDir) {
@@ -72,14 +75,8 @@ describe("config backup rotation", () => {
const bakStat = await fs.stat(`${configPath}.bak`); const bakStat = await fs.stat(`${configPath}.bak`);
const bak1Stat = await fs.stat(`${configPath}.bak.1`); const bak1Stat = await fs.stat(`${configPath}.bak.1`);
// Windows does not reliably honor POSIX chmod bits. expect(bakStat.mode & 0o777).toBe(0o600);
if (process.platform === "win32") { expect(bak1Stat.mode & 0o777).toBe(0o600);
expect(bakStat.mode & 0o777).toBeGreaterThan(0);
expect(bak1Stat.mode & 0o777).toBeGreaterThan(0);
} else {
expect(bakStat.mode & 0o777).toBe(0o600);
expect(bak1Stat.mode & 0o777).toBe(0o600);
}
}); });
}); });
@@ -119,34 +116,34 @@ describe("config backup rotation", () => {
}); });
}); });
it("maintainConfigBackups composes rotate/copy/harden/prune flow", async () => { // chmod is a no-op on Windows — permission assertions will always fail.
await withTempHome(async () => { it.skipIf(IS_WINDOWS)(
const stateDir = process.env.OPENCLAW_STATE_DIR?.trim(); "maintainConfigBackups composes rotate/copy/harden/prune flow",
if (!stateDir) { async () => {
throw new Error("Expected OPENCLAW_STATE_DIR to be set by withTempHome"); await withTempHome(async () => {
} const stateDir = process.env.OPENCLAW_STATE_DIR?.trim();
const configPath = path.join(stateDir, "openclaw.json"); if (!stateDir) {
await fs.writeFile(configPath, JSON.stringify({ token: "secret" }), { mode: 0o600 }); throw new Error("Expected OPENCLAW_STATE_DIR to be set by withTempHome");
await fs.writeFile(`${configPath}.bak`, "previous", { mode: 0o644 }); }
await fs.writeFile(`${configPath}.bak.orphan`, "old"); const configPath = path.join(stateDir, "openclaw.json");
await fs.writeFile(configPath, JSON.stringify({ token: "secret" }), { mode: 0o600 });
await fs.writeFile(`${configPath}.bak`, "previous", { mode: 0o644 });
await fs.writeFile(`${configPath}.bak.orphan`, "old");
await maintainConfigBackups(configPath, fs); await maintainConfigBackups(configPath, fs);
// A new primary backup is created from the current config. // A new primary backup is created from the current config.
await expect(fs.readFile(`${configPath}.bak`, "utf-8")).resolves.toBe( await expect(fs.readFile(`${configPath}.bak`, "utf-8")).resolves.toBe(
JSON.stringify({ token: "secret" }), JSON.stringify({ token: "secret" }),
); );
// Prior primary backup gets rotated into ring slot 1. // Prior primary backup gets rotated into ring slot 1.
await expect(fs.readFile(`${configPath}.bak.1`, "utf-8")).resolves.toBe("previous"); await expect(fs.readFile(`${configPath}.bak.1`, "utf-8")).resolves.toBe("previous");
// Mode hardening still applies on POSIX systems. // Mode hardening still applies.
const primaryBackupStat = await fs.stat(`${configPath}.bak`); const primaryBackupStat = await fs.stat(`${configPath}.bak`);
if (process.platform === "win32") {
expect(primaryBackupStat.mode & 0o777).toBeGreaterThan(0);
} else {
expect(primaryBackupStat.mode & 0o777).toBe(0o600); expect(primaryBackupStat.mode & 0o777).toBe(0o600);
} // Out-of-ring orphan gets pruned.
// Out-of-ring orphan gets pruned. await expect(fs.stat(`${configPath}.bak.orphan`)).rejects.toThrow();
await expect(fs.stat(`${configPath}.bak.orphan`)).rejects.toThrow(); });
}); },
}); );
}); });