feat(browser): prefer default chromium browser

This commit is contained in:
Peter Steinberger
2026-01-16 05:37:37 +00:00
parent 1ab1e312b2
commit 41d44021e7
5 changed files with 373 additions and 3 deletions

View File

@@ -0,0 +1,72 @@
import { describe, expect, it, vi, beforeEach } from "vitest";
vi.mock("node:child_process", () => ({
execFileSync: vi.fn(),
}));
vi.mock("node:fs", () => {
const existsSync = vi.fn();
const readFileSync = vi.fn();
return {
existsSync,
readFileSync,
default: { existsSync, readFileSync },
};
});
import { execFileSync } from "node:child_process";
import * as fs from "node:fs";
describe("browser default executable detection", () => {
beforeEach(() => {
vi.resetModules();
vi.clearAllMocks();
});
it("prefers default Chromium browser on macOS", async () => {
vi.mocked(execFileSync).mockImplementation((cmd, args) => {
const argsStr = Array.isArray(args) ? args.join(" ") : "";
if (cmd === "/usr/bin/osascript" && argsStr.includes("id of application")) {
return "com.google.Chrome";
}
if (cmd === "/usr/bin/osascript" && argsStr.includes("POSIX path")) {
return "/Applications/Google Chrome.app";
}
if (cmd === "/usr/bin/defaults") {
return "Google Chrome";
}
return "";
});
vi.mocked(fs.existsSync).mockImplementation((p) =>
String(p).includes("/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"),
);
const { resolveBrowserExecutableForPlatform } = await import("./chrome.executables.js");
const exe = resolveBrowserExecutableForPlatform(
{} as Parameters<typeof resolveBrowserExecutableForPlatform>[0],
"darwin",
);
expect(exe?.path).toContain("Google Chrome.app/Contents/MacOS/Google Chrome");
expect(exe?.kind).toBe("chrome");
});
it("falls back when default browser is non-Chromium on macOS", async () => {
vi.mocked(execFileSync).mockImplementation((cmd, args) => {
const argsStr = Array.isArray(args) ? args.join(" ") : "";
if (cmd === "/usr/bin/osascript" && argsStr.includes("id of application")) {
return "com.apple.Safari";
}
return "";
});
vi.mocked(fs.existsSync).mockImplementation((p) =>
String(p).includes("Google Chrome.app/Contents/MacOS/Google Chrome"),
);
const { resolveBrowserExecutableForPlatform } = await import("./chrome.executables.js");
const exe = resolveBrowserExecutableForPlatform(
{} as Parameters<typeof resolveBrowserExecutableForPlatform>[0],
"darwin",
);
expect(exe?.path).toContain("Google Chrome.app/Contents/MacOS/Google Chrome");
});
});