fix(telegram): warn when accounts.default is missing in multi-account setup (#32544)

Merged via squash.

Prepared head SHA: 7ebc3f65b2
Co-authored-by: Sid-Qin <201593046+Sid-Qin@users.noreply.github.com>
Co-authored-by: gumadeiras <5599352+gumadeiras@users.noreply.github.com>
Reviewed-by: @gumadeiras
This commit is contained in:
Sid
2026-03-03 16:27:19 +08:00
committed by GitHub
parent 2370ea5d1b
commit 4ffe15c6b2
13 changed files with 495 additions and 62 deletions

View File

@@ -1,8 +1,9 @@
import { afterEach, describe, expect, it, vi } from "vitest";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { OpenClawConfig } from "../config/config.js";
import { withEnv } from "../test-utils/env.js";
import {
listTelegramAccountIds,
resetMissingDefaultWarnFlag,
resolveDefaultTelegramAccountId,
resolveTelegramAccount,
} from "./accounts.js";
@@ -11,6 +12,10 @@ const { warnMock } = vi.hoisted(() => ({
warnMock: vi.fn(),
}));
function warningLines(): string[] {
return warnMock.mock.calls.map(([line]) => String(line));
}
vi.mock("../logging/subsystem.js", () => ({
createSubsystemLogger: () => {
const logger = {
@@ -24,6 +29,7 @@ vi.mock("../logging/subsystem.js", () => ({
describe("resolveTelegramAccount", () => {
afterEach(() => {
warnMock.mockClear();
resetMissingDefaultWarnFlag();
});
it("falls back to the first configured account when accountId is omitted", () => {
@@ -105,6 +111,94 @@ describe("resolveTelegramAccount", () => {
});
describe("resolveDefaultTelegramAccountId", () => {
beforeEach(() => {
resetMissingDefaultWarnFlag();
});
afterEach(() => {
warnMock.mockClear();
resetMissingDefaultWarnFlag();
});
it("warns when accounts.default is missing in multi-account setup (#32137)", () => {
const cfg: OpenClawConfig = {
channels: {
telegram: {
accounts: { work: { botToken: "tok-work" }, alerts: { botToken: "tok-alerts" } },
},
},
};
const result = resolveDefaultTelegramAccountId(cfg);
expect(result).toBe("alerts");
expect(warnMock).toHaveBeenCalledWith(expect.stringContaining("accounts.default is missing"));
});
it("does not warn when accounts.default exists", () => {
const cfg: OpenClawConfig = {
channels: {
telegram: {
accounts: { default: { botToken: "tok-default" }, work: { botToken: "tok-work" } },
},
},
};
resolveDefaultTelegramAccountId(cfg);
expect(warningLines().every((line) => !line.includes("accounts.default is missing"))).toBe(
true,
);
});
it("does not warn when defaultAccount is explicitly set", () => {
const cfg: OpenClawConfig = {
channels: {
telegram: {
defaultAccount: "work",
accounts: { work: { botToken: "tok-work" } },
},
},
};
resolveDefaultTelegramAccountId(cfg);
expect(warningLines().every((line) => !line.includes("accounts.default is missing"))).toBe(
true,
);
});
it("does not warn when only one non-default account is configured", () => {
const cfg: OpenClawConfig = {
channels: {
telegram: {
accounts: { work: { botToken: "tok-work" } },
},
},
};
resolveDefaultTelegramAccountId(cfg);
expect(warningLines().every((line) => !line.includes("accounts.default is missing"))).toBe(
true,
);
});
it("warns only once per process lifetime", () => {
const cfg: OpenClawConfig = {
channels: {
telegram: {
accounts: { work: { botToken: "tok-work" }, alerts: { botToken: "tok-alerts" } },
},
},
};
resolveDefaultTelegramAccountId(cfg);
resolveDefaultTelegramAccountId(cfg);
resolveDefaultTelegramAccountId(cfg);
const missingDefaultWarns = warningLines().filter((line) =>
line.includes("accounts.default is missing"),
);
expect(missingDefaultWarns).toHaveLength(1);
});
it("prefers channels.telegram.defaultAccount when it matches a configured account", () => {
const cfg: OpenClawConfig = {
channels: {