github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-10 00:13:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(hooks): deduplicate before_tool_call hook in toToolDefinitions (#15502)

Browse Source
This commit is contained in:
damaozi
2026-02-14 01:44:13 +08:00
committed by Peter Steinberger
parent b4430c126a
commit 534e4213a1
4 changed files with 50 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/agents/pi-tool-definition-adapter.after-tool-call.e2e.test.ts
View File

@@ -35,10 +35,6 @@ describe("pi tool definition adapter after_tool_call", () => {
it("dispatches after_tool_call once on successful adapter execution", async () => {
hookMocks.runner.hasHooks.mockImplementation((name: string) => name === "after_tool_call");
hookMocks.runBeforeToolCallHook.mockResolvedValue({
blocked: false,
params: { mode: "safe" },
});
const tool = {
name: "read",
label: "Read",
@@ -52,10 +48,13 @@ describe("pi tool definition adapter after_tool_call", () => {
expect(result.details).toMatchObject({ ok: true });
expect(hookMocks.runner.runAfterToolCall).toHaveBeenCalledTimes(1);
// after_tool_call receives the params as passed to toToolDefinitions;
// before_tool_call adjustment happens in wrapToolWithBeforeToolCallHook
// (upstream), not inside toToolDefinitions (#15502).
expect(hookMocks.runner.runAfterToolCall).toHaveBeenCalledWith(
{
toolName: "read",
params: { mode: "safe" },
params: { path: "/tmp/file" },
result,
},
{ toolName: "read" },