refactor(extensions): dedupe connector helper usage

2026-04-19 05:07:27 +00:00 · 2026-02-16 14:51:55 +00:00
parent bc55ffb160
commit 544ffbcf7b
49 changed files with 854 additions and 1478 deletions
--- a/extensions/irc/src/connect-options.ts
+++ b/extensions/irc/src/connect-options.ts
@@ -0,0 +1,30 @@
+import type { ResolvedIrcAccount } from "./accounts.js";
+import type { IrcClientOptions } from "./client.js";
+
+type IrcConnectOverrides = Omit<
+  Partial<IrcClientOptions>,
+  "host" | "port" | "tls" | "nick" | "username" | "realname" | "password" | "nickserv"
+>;
+
+export function buildIrcConnectOptions(
+  account: ResolvedIrcAccount,
+  overrides: IrcConnectOverrides = {},
+): IrcClientOptions {
+  return {
+    host: account.host,
+    port: account.port,
+    tls: account.tls,
+    nick: account.nick,
+    username: account.username,
+    realname: account.realname,
+    password: account.password,
+    nickserv: {
+      enabled: account.config.nickserv?.enabled,
+      service: account.config.nickserv?.service,
+      password: account.config.nickserv?.password,
+      register: account.config.nickserv?.register,
+      registerEmail: account.config.nickserv?.registerEmail,
+    },
+    ...overrides,
+  };
+}
--- a/extensions/irc/src/monitor.ts
+++ b/extensions/irc/src/monitor.ts
@@ -2,6 +2,7 @@ import type { RuntimeEnv } from "openclaw/plugin-sdk";
 import type { CoreConfig, IrcInboundMessage } from "./types.js";
 import { resolveIrcAccount } from "./accounts.js";
 import { connectIrcClient, type IrcClient } from "./client.js";
+import { buildIrcConnectOptions } from "./connect-options.js";
 import { handleIrcInbound } from "./inbound.js";
 import { isChannelTarget } from "./normalize.js";
 import { makeIrcMessageId } from "./protocol.js";
@@ -59,91 +60,79 @@ export async function monitorIrcProvider(opts: IrcMonitorOptions): Promise<{ sto

  let client: IrcClient | null = null;

-  client = await connectIrcClient({
-    host: account.host,
-    port: account.port,
-    tls: account.tls,
-    nick: account.nick,
-    username: account.username,
-    realname: account.realname,
-    password: account.password,
-    nickserv: {
-      enabled: account.config.nickserv?.enabled,
-      service: account.config.nickserv?.service,
-      password: account.config.nickserv?.password,
-      register: account.config.nickserv?.register,
-      registerEmail: account.config.nickserv?.registerEmail,
-    },
-    channels: account.config.channels,
-    abortSignal: opts.abortSignal,
-    onLine: (line) => {
-      if (core.logging.shouldLogVerbose()) {
-        logger.debug?.(`[${account.accountId}] << ${line}`);
-      }
-    },
-    onNotice: (text, target) => {
-      if (core.logging.shouldLogVerbose()) {
-        logger.debug?.(`[${account.accountId}] notice ${target ?? ""}: ${text}`);
-      }
-    },
-    onError: (error) => {
-      logger.error(`[${account.accountId}] IRC error: ${error.message}`);
-    },
-    onPrivmsg: async (event) => {
-      if (!client) {
-        return;
-      }
-      if (event.senderNick.toLowerCase() === client.nick.toLowerCase()) {
-        return;
-      }
+  client = await connectIrcClient(
+    buildIrcConnectOptions(account, {
+      channels: account.config.channels,
+      abortSignal: opts.abortSignal,
+      onLine: (line) => {
+        if (core.logging.shouldLogVerbose()) {
+          logger.debug?.(`[${account.accountId}] << ${line}`);
+        }
+      },
+      onNotice: (text, target) => {
+        if (core.logging.shouldLogVerbose()) {
+          logger.debug?.(`[${account.accountId}] notice ${target ?? ""}: ${text}`);
+        }
+      },
+      onError: (error) => {
+        logger.error(`[${account.accountId}] IRC error: ${error.message}`);
+      },
+      onPrivmsg: async (event) => {
+        if (!client) {
+          return;
+        }
+        if (event.senderNick.toLowerCase() === client.nick.toLowerCase()) {
+          return;
+        }

-      const inboundTarget = resolveIrcInboundTarget({
-        target: event.target,
-        senderNick: event.senderNick,
-      });
-      const message: IrcInboundMessage = {
-        messageId: makeIrcMessageId(),
-        target: inboundTarget.target,
-        rawTarget: inboundTarget.rawTarget,
-        senderNick: event.senderNick,
-        senderUser: event.senderUser,
-        senderHost: event.senderHost,
-        text: event.text,
-        timestamp: Date.now(),
-        isGroup: inboundTarget.isGroup,
-      };
+        const inboundTarget = resolveIrcInboundTarget({
+          target: event.target,
+          senderNick: event.senderNick,
+        });
+        const message: IrcInboundMessage = {
+          messageId: makeIrcMessageId(),
+          target: inboundTarget.target,
+          rawTarget: inboundTarget.rawTarget,
+          senderNick: event.senderNick,
+          senderUser: event.senderUser,
+          senderHost: event.senderHost,
+          text: event.text,
+          timestamp: Date.now(),
+          isGroup: inboundTarget.isGroup,
+        };

-      core.channel.activity.record({
-        channel: "irc",
-        accountId: account.accountId,
-        direction: "inbound",
-        at: message.timestamp,
-      });
+        core.channel.activity.record({
+          channel: "irc",
+          accountId: account.accountId,
+          direction: "inbound",
+          at: message.timestamp,
+        });

-      if (opts.onMessage) {
-        await opts.onMessage(message, client);
-        return;
-      }
+        if (opts.onMessage) {
+          await opts.onMessage(message, client);
+          return;
+        }

-      await handleIrcInbound({
-        message,
-        account,
-        config: cfg,
-        runtime,
-        connectedNick: client.nick,
-        sendReply: async (target, text) => {
-          client?.sendPrivmsg(target, text);
-          opts.statusSink?.({ lastOutboundAt: Date.now() });
-          core.channel.activity.record({
-            channel: "irc",
-            accountId: account.accountId,
-            direction: "outbound",
-          });
-        },
-        statusSink: opts.statusSink,
-      });
-    },
-  });
+        await handleIrcInbound({
+          message,
+          account,
+          config: cfg,
+          runtime,
+          connectedNick: client.nick,
+          sendReply: async (target, text) => {
+            client?.sendPrivmsg(target, text);
+            opts.statusSink?.({ lastOutboundAt: Date.now() });
+            core.channel.activity.record({
+              channel: "irc",
+              accountId: account.accountId,
+              direction: "outbound",
+            });
+          },
+          statusSink: opts.statusSink,
+        });
+      },
+    }),
+  );

  logger.info(
    `[${account.accountId}] connected to ${account.host}:${account.port}${account.tls ? " (tls)" : ""} as ${client.nick}`,
--- a/extensions/irc/src/probe.ts
+++ b/extensions/irc/src/probe.ts
@@ -1,6 +1,7 @@
 import type { CoreConfig, IrcProbe } from "./types.js";
 import { resolveIrcAccount } from "./accounts.js";
 import { connectIrcClient } from "./client.js";
+import { buildIrcConnectOptions } from "./connect-options.js";

 function formatError(err: unknown): string {
  if (err instanceof Error) {
@@ -31,23 +32,11 @@ export async function probeIrc(

  const started = Date.now();
  try {
-    const client = await connectIrcClient({
-      host: account.host,
-      port: account.port,
-      tls: account.tls,
-      nick: account.nick,
-      username: account.username,
-      realname: account.realname,
-      password: account.password,
-      nickserv: {
-        enabled: account.config.nickserv?.enabled,
-        service: account.config.nickserv?.service,
-        password: account.config.nickserv?.password,
-        register: account.config.nickserv?.register,
-        registerEmail: account.config.nickserv?.registerEmail,
-      },
-      connectTimeoutMs: opts?.timeoutMs ?? 8000,
-    });
+    const client = await connectIrcClient(
+      buildIrcConnectOptions(account, {
+        connectTimeoutMs: opts?.timeoutMs ?? 8000,
+      }),
+    );
    const elapsed = Date.now() - started;
    client.quit("probe");
    return {
--- a/extensions/irc/src/send.ts
+++ b/extensions/irc/src/send.ts
@@ -2,6 +2,7 @@ import type { IrcClient } from "./client.js";
 import type { CoreConfig } from "./types.js";
 import { resolveIrcAccount } from "./accounts.js";
 import { connectIrcClient } from "./client.js";
+import { buildIrcConnectOptions } from "./connect-options.js";
 import { normalizeIrcMessagingTarget } from "./normalize.js";
 import { makeIrcMessageId } from "./protocol.js";
 import { getIrcRuntime } from "./runtime.js";
@@ -65,23 +66,11 @@ export async function sendMessageIrc(
  if (client?.isReady()) {
    client.sendPrivmsg(target, payload);
  } else {
-    const transient = await connectIrcClient({
-      host: account.host,
-      port: account.port,
-      tls: account.tls,
-      nick: account.nick,
-      username: account.username,
-      realname: account.realname,
-      password: account.password,
-      nickserv: {
-        enabled: account.config.nickserv?.enabled,
-        service: account.config.nickserv?.service,
-        password: account.config.nickserv?.password,
-        register: account.config.nickserv?.register,
-        registerEmail: account.config.nickserv?.registerEmail,
-      },
-      connectTimeoutMs: 12000,
-    });
+    const transient = await connectIrcClient(
+      buildIrcConnectOptions(account, {
+        connectTimeoutMs: 12000,
+      }),
+    );
    transient.sendPrivmsg(target, payload);
    transient.quit("sent");
  }