fix: per-agent sandbox overrides

src/agents/sandbox-agent-config.test.ts

@@ -1,13 +1,33 @@
-import { describe, expect, it } from "vitest";
+import { EventEmitter } from "node:events";
+import { Readable } from "node:stream";
+import { describe, expect, it, vi } from "vitest";
 import type { ClawdbotConfig } from "../config/config.js";
 
 // We need to test the internal defaultSandboxConfig function, but it's not exported.
 // Instead, we test the behavior through resolveSandboxContext which uses it.
 
+vi.mock("node:child_process", async (importOriginal) => {
+  const actual = await importOriginal<typeof import("node:child_process")>();
+  return {
+    ...actual,
+    spawn: () => {
+      const child = new EventEmitter() as {
+        stdout?: Readable;
+        stderr?: Readable;
+        on: (event: string, cb: (...args: unknown[]) => void) => void;
+      };
+      child.stdout = new Readable({ read() {} });
+      child.stderr = new Readable({ read() {} });
+      queueMicrotask(() => child.emit("close", 0));
+      return child;
+    },
+  };
+});
+
 describe("Agent-specific sandbox config", () => {
   it("should use global sandbox config when no agent-specific config exists", async () => {
     const { resolveSandboxContext } = await import("./sandbox.js");
-    
+
     const cfg: ClawdbotConfig = {
       agent: {
         sandbox: {
@@ -36,7 +56,7 @@ describe("Agent-specific sandbox config", () => {
 
   it("should override with agent-specific sandbox mode 'off'", async () => {
     const { resolveSandboxContext } = await import("./sandbox.js");
-    
+
     const cfg: ClawdbotConfig = {
       agent: {
         sandbox: {
@@ -68,7 +88,7 @@ describe("Agent-specific sandbox config", () => {
 
   it("should use agent-specific sandbox mode 'all'", async () => {
     const { resolveSandboxContext } = await import("./sandbox.js");
-    
+
     const cfg: ClawdbotConfig = {
       agent: {
         sandbox: {
@@ -100,7 +120,7 @@ describe("Agent-specific sandbox config", () => {
 
   it("should use agent-specific scope", async () => {
     const { resolveSandboxContext } = await import("./sandbox.js");
-    
+
     const cfg: ClawdbotConfig = {
       agent: {
         sandbox: {
@@ -134,7 +154,7 @@ describe("Agent-specific sandbox config", () => {
 
   it("should use agent-specific workspaceRoot", async () => {
     const { resolveSandboxContext } = await import("./sandbox.js");
-    
+
     const cfg: ClawdbotConfig = {
       agent: {
         sandbox: {
@@ -169,7 +189,7 @@ describe("Agent-specific sandbox config", () => {
 
   it("should prefer agent config over global for multiple agents", async () => {
     const { resolveSandboxContext } = await import("./sandbox.js");
-    
+
     const cfg: ClawdbotConfig = {
       agent: {
         sandbox: {
@@ -213,4 +233,48 @@ describe("Agent-specific sandbox config", () => {
     expect(familyContext).toBeDefined();
     expect(familyContext?.enabled).toBe(true);
   });
+
+  it("should prefer agent-specific sandbox tool policy", async () => {
+    const { resolveSandboxContext } = await import("./sandbox.js");
+
+    const cfg: ClawdbotConfig = {
+      agent: {
+        sandbox: {
+          mode: "all",
+          scope: "agent",
+          tools: {
+            allow: ["read"],
+            deny: ["bash"],
+          },
+        },
+      },
+      routing: {
+        agents: {
+          restricted: {
+            workspace: "~/clawd-restricted",
+            sandbox: {
+              mode: "all",
+              scope: "agent",
+              tools: {
+                allow: ["read", "write"],
+                deny: ["edit"],
+              },
+            },
+          },
+        },
+      },
+    };
+
+    const context = await resolveSandboxContext({
+      config: cfg,
+      sessionKey: "agent:restricted:main",
+      workspaceDir: "/tmp/test-restricted",
+    });
+
+    expect(context).toBeDefined();
+    expect(context?.tools).toEqual({
+      allow: ["read", "write"],
+      deny: ["edit"],
+    });
+  });
 });