github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-09 16:24:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(web): table-drive SSRF and voice input rejection cases

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-21 23:30:13 +00:00
parent d748657265
commit 59563847e4
1 changed files with 42 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
src/web/media.test.ts
View File

@@ -200,25 +200,27 @@ describe("web media loading", () => {
fetchMock.mockRestore(); fetchMock.mockRestore();
}); });
it("blocks private network URL fetches (SSRF guard)", async () => { it("blocks SSRF URLs before fetch", async () => {
const fetchMock = vi.spyOn(globalThis, "fetch"); const fetchMock = vi.spyOn(globalThis, "fetch");
const cases = [
{
name: "private network host",
url: "http://127.0.0.1:8080/internal-api",
expectedMessage: /blocked|private|internal/i,
},
{
name: "cloud metadata hostname",
url: "http://metadata.google.internal/computeMetadata/v1/",
expectedMessage: /blocked|private|internal|metadata/i,
},
] as const;
await expect(loadWebMedia("http://127.0.0.1:8080/internal-api", 1024 * 1024)).rejects.toThrow( for (const testCase of cases) {
/blocked|private|internal/i, await expect(loadWebMedia(testCase.url, 1024 * 1024), testCase.name).rejects.toThrow(
); testCase.expectedMessage,
);
}
expect(fetchMock).not.toHaveBeenCalled(); expect(fetchMock).not.toHaveBeenCalled();
fetchMock.mockRestore();
});
it("blocks cloud metadata hostnames (SSRF guard)", async () => {
const fetchMock = vi.spyOn(globalThis, "fetch");
await expect(
loadWebMedia("http://metadata.google.internal/computeMetadata/v1/", 1024 * 1024),
).rejects.toThrow(/blocked|private|internal|metadata/i);
expect(fetchMock).not.toHaveBeenCalled();
fetchMock.mockRestore(); fetchMock.mockRestore();
}); });
@@ -308,23 +310,31 @@ describe("web media loading", () => {
}); });
describe("Discord voice message input hardening", () => { describe("Discord voice message input hardening", () => {
it("rejects local paths outside allowed media roots", async () => { it("rejects unsafe voice message inputs", async () => {
const candidate = path.join(process.cwd(), "package.json"); const cases = [
await expect(sendVoiceMessageDiscord("channel:123", candidate)).rejects.toThrow( {
/Local media path is not under an allowed directory/i, name: "local path outside allowed media roots",
); candidate: path.join(process.cwd(), "package.json"),
}); expectedMessage: /Local media path is not under an allowed directory/i,
},
{
name: "private-network URL",
candidate: "http://127.0.0.1/voice.ogg",
expectedMessage: /Failed to fetch media|Blocked|private|internal/i,
},
{
name: "non-http URL scheme",
candidate: "rtsp://example.com/voice.ogg",
expectedMessage: /Local media path is not under an allowed directory|ENOENT|no such file/i,
},
] as const;
it("blocks SSRF targets when given a private-network URL", async () => { for (const testCase of cases) {
await expect( await expect(
sendVoiceMessageDiscord("channel:123", "http://127.0.0.1/voice.ogg"), sendVoiceMessageDiscord("channel:123", testCase.candidate),
).rejects.toThrow(/Failed to fetch media|Blocked|private|internal/i); testCase.name,
}); ).rejects.toThrow(testCase.expectedMessage);
}
it("rejects non-http URL schemes", async () => {
await expect(
sendVoiceMessageDiscord("channel:123", "rtsp://example.com/voice.ogg"),
).rejects.toThrow(/Local media path is not under an allowed directory|ENOENT|no such file/i);
}); });
}); });