fix(configure): reject literal "undefined" and "null" gateway auth tokens (#13767)

* fix(configure): reject literal "undefined" and "null" gateway auth tokens

* fix(configure): reject literal "undefined" and "null" gateway auth tokens

* fix(configure): validate gateway password prompt and harden token coercion (#13767) (thanks @omair445)

* test: remove unused vitest imports in baseline lint fixtures (#13767)

---------

Co-authored-by: Luna AI <luna@coredirection.ai>
Co-authored-by: Peter Steinberger <steipete@gmail.com>
This commit is contained in:
Omair Afzal
2026-02-13 21:04:41 +05:00
committed by GitHub
parent 4dc93f40d5
commit 59733a02c8
9 changed files with 118 additions and 11 deletions

View File

@@ -44,6 +44,15 @@ describe("buildGatewayAuthConfig", () => {
expect(result).toEqual({ mode: "password", password: "secret" });
});
it("does not silently omit password when literal string is provided", () => {
const result = buildGatewayAuthConfig({
mode: "password",
password: "undefined",
});
expect(result).toEqual({ mode: "password", password: "undefined" });
});
it("generates random token when token param is undefined", () => {
const result = buildGatewayAuthConfig({
mode: "token",
@@ -82,4 +91,30 @@ describe("buildGatewayAuthConfig", () => {
expect(typeof result?.token).toBe("string");
expect(result?.token?.length).toBeGreaterThan(0);
});
it('generates random token when token param is the literal string "undefined"', () => {
const result = buildGatewayAuthConfig({
mode: "token",
token: "undefined",
});
expect(result?.mode).toBe("token");
expect(result?.token).toBeDefined();
expect(result?.token).not.toBe("undefined");
expect(typeof result?.token).toBe("string");
expect(result?.token?.length).toBeGreaterThan(0);
});
it('generates random token when token param is the literal string "null"', () => {
const result = buildGatewayAuthConfig({
mode: "token",
token: "null",
});
expect(result?.mode).toBe("token");
expect(result?.token).toBeDefined();
expect(result?.token).not.toBe("null");
expect(typeof result?.token).toBe("string");
expect(result?.token?.length).toBeGreaterThan(0);
});
});