github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-09 05:27:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): remove remaining command test duplication

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-16 16:52:53 +00:00
parent 0d51869c3c
commit 5b185da366
5 changed files with 73 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/commands/agents.add.e2e.test.ts
View File

@@ -1,23 +1,18 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
import { baseConfigSnapshot, createTestRuntime } from "./test-runtime-config-helpers.js";
const configMocks = vi.hoisted(() => ({
readConfigFileSnapshot: vi.fn(),
writeConfigFile: vi.fn().mockResolvedValue(undefined),
}));
const readConfigFileSnapshotMock = vi.hoisted(() => vi.fn());
const writeConfigFileMock = vi.hoisted(() => vi.fn().mockResolvedValue(undefined));
const wizardMocks = vi.hoisted(() => ({
createClackPrompter: vi.fn(),
}));
vi.mock("../config/config.js", async (importOriginal) => {
const actual = await importOriginal<typeof import("../config/config.js")>();
return {
...actual,
readConfigFileSnapshot: configMocks.readConfigFileSnapshot,
writeConfigFile: configMocks.writeConfigFile,
};
});
vi.mock("../config/config.js", async (importOriginal) => ({
...(await importOriginal<typeof import("../config/config.js")>()),
readConfigFileSnapshot: readConfigFileSnapshotMock,
writeConfigFile: writeConfigFileMock,
}));
vi.mock("../wizard/clack-prompter.js", () => ({
createClackPrompter: wizardMocks.createClackPrompter,
@@ -30,8 +25,8 @@ const runtime = createTestRuntime();
describe("agents add command", () => {
beforeEach(() => {
configMocks.readConfigFileSnapshot.mockReset();
configMocks.writeConfigFile.mockClear();
readConfigFileSnapshotMock.mockReset();
writeConfigFileMock.mockClear();
wizardMocks.createClackPrompter.mockReset();
runtime.log.mockClear();
runtime.error.mockClear();
@@ -39,17 +34,17 @@ describe("agents add command", () => {
});
it("requires --workspace when flags are present", async () => {
configMocks.readConfigFileSnapshot.mockResolvedValue({ ...baseConfigSnapshot });
readConfigFileSnapshotMock.mockResolvedValue({ ...baseConfigSnapshot });
await agentsAddCommand({ name: "Work" }, runtime, { hasFlags: true });
expect(runtime.error).toHaveBeenCalledWith(expect.stringContaining("--workspace"));
expect(runtime.exit).toHaveBeenCalledWith(1);
expect(configMocks.writeConfigFile).not.toHaveBeenCalled();
expect(writeConfigFileMock).not.toHaveBeenCalled();
});
it("requires --workspace in non-interactive mode", async () => {
configMocks.readConfigFileSnapshot.mockResolvedValue({ ...baseConfigSnapshot });
readConfigFileSnapshotMock.mockResolvedValue({ ...baseConfigSnapshot });
await agentsAddCommand({ name: "Work", nonInteractive: true }, runtime, {
hasFlags: false,
@@ -57,11 +52,11 @@ describe("agents add command", () => {
expect(runtime.error).toHaveBeenCalledWith(expect.stringContaining("--workspace"));
expect(runtime.exit).toHaveBeenCalledWith(1);
expect(configMocks.writeConfigFile).not.toHaveBeenCalled();
expect(writeConfigFileMock).not.toHaveBeenCalled();
});
it("exits with code 1 when the interactive wizard is cancelled", async () => {
configMocks.readConfigFileSnapshot.mockResolvedValue({ ...baseConfigSnapshot });
readConfigFileSnapshotMock.mockResolvedValue({ ...baseConfigSnapshot });
wizardMocks.createClackPrompter.mockReturnValue({
intro: vi.fn().mockRejectedValue(new WizardCancelledError()),
text: vi.fn(),
@@ -73,6 +68,6 @@ describe("agents add command", () => {
await agentsAddCommand({}, runtime);
expect(runtime.exit).toHaveBeenCalledWith(1);
expect(configMocks.writeConfigFile).not.toHaveBeenCalled();
expect(writeConfigFileMock).not.toHaveBeenCalled();
});
});