refactor(test): remove remaining command test duplication

src/commands/dashboard.e2e.test.ts

@@ -1,30 +1,28 @@
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import { dashboardCommand } from "./dashboard.js";
 
-const mocks = vi.hoisted(() => ({
-  readConfigFileSnapshot: vi.fn(),
-  resolveGatewayPort: vi.fn(),
-  resolveControlUiLinks: vi.fn(),
-  detectBrowserOpenSupport: vi.fn(),
-  openUrl: vi.fn(),
-  formatControlUiSshHint: vi.fn(),
-  copyToClipboard: vi.fn(),
-}));
+const readConfigFileSnapshotMock = vi.hoisted(() => vi.fn());
+const resolveGatewayPortMock = vi.hoisted(() => vi.fn());
+const resolveControlUiLinksMock = vi.hoisted(() => vi.fn());
+const detectBrowserOpenSupportMock = vi.hoisted(() => vi.fn());
+const openUrlMock = vi.hoisted(() => vi.fn());
+const formatControlUiSshHintMock = vi.hoisted(() => vi.fn());
+const copyToClipboardMock = vi.hoisted(() => vi.fn());
 
 vi.mock("../config/config.js", () => ({
-  readConfigFileSnapshot: mocks.readConfigFileSnapshot,
-  resolveGatewayPort: mocks.resolveGatewayPort,
+  readConfigFileSnapshot: readConfigFileSnapshotMock,
+  resolveGatewayPort: resolveGatewayPortMock,
 }));
 
 vi.mock("./onboard-helpers.js", () => ({
-  resolveControlUiLinks: mocks.resolveControlUiLinks,
-  detectBrowserOpenSupport: mocks.detectBrowserOpenSupport,
-  openUrl: mocks.openUrl,
-  formatControlUiSshHint: mocks.formatControlUiSshHint,
+  resolveControlUiLinks: resolveControlUiLinksMock,
+  detectBrowserOpenSupport: detectBrowserOpenSupportMock,
+  openUrl: openUrlMock,
+  formatControlUiSshHint: formatControlUiSshHintMock,
 }));
 
 vi.mock("../infra/clipboard.js", () => ({
-  copyToClipboard: mocks.copyToClipboard,
+  copyToClipboard: copyToClipboardMock,
 }));
 
 const runtime = {
@@ -40,7 +38,7 @@ function resetRuntime() {
 }
 
 function mockSnapshot(token = "abc") {
-  mocks.readConfigFileSnapshot.mockResolvedValue({
+  readConfigFileSnapshotMock.mockResolvedValue({
     path: "/tmp/openclaw.json",
     exists: true,
     raw: "{}",
@@ -50,8 +48,8 @@ function mockSnapshot(token = "abc") {
     issues: [],
     legacyIssues: [],
   });
-  mocks.resolveGatewayPort.mockReturnValue(18789);
-  mocks.resolveControlUiLinks.mockReturnValue({
+  resolveGatewayPortMock.mockReturnValue(18789);
+  resolveControlUiLinksMock.mockReturnValue({
     httpUrl: "http://127.0.0.1:18789/",
     wsUrl: "ws://127.0.0.1:18789",
   });
@@ -60,31 +58,31 @@ function mockSnapshot(token = "abc") {
 describe("dashboardCommand", () => {
   beforeEach(() => {
     resetRuntime();
-    mocks.readConfigFileSnapshot.mockReset();
-    mocks.resolveGatewayPort.mockReset();
-    mocks.resolveControlUiLinks.mockReset();
-    mocks.detectBrowserOpenSupport.mockReset();
-    mocks.openUrl.mockReset();
-    mocks.formatControlUiSshHint.mockReset();
-    mocks.copyToClipboard.mockReset();
+    readConfigFileSnapshotMock.mockReset();
+    resolveGatewayPortMock.mockReset();
+    resolveControlUiLinksMock.mockReset();
+    detectBrowserOpenSupportMock.mockReset();
+    openUrlMock.mockReset();
+    formatControlUiSshHintMock.mockReset();
+    copyToClipboardMock.mockReset();
   });
 
   it("opens and copies the dashboard link by default", async () => {
     mockSnapshot("abc123");
-    mocks.copyToClipboard.mockResolvedValue(true);
-    mocks.detectBrowserOpenSupport.mockResolvedValue({ ok: true });
-    mocks.openUrl.mockResolvedValue(true);
+    copyToClipboardMock.mockResolvedValue(true);
+    detectBrowserOpenSupportMock.mockResolvedValue({ ok: true });
+    openUrlMock.mockResolvedValue(true);
 
     await dashboardCommand(runtime);
 
-    expect(mocks.resolveControlUiLinks).toHaveBeenCalledWith({
+    expect(resolveControlUiLinksMock).toHaveBeenCalledWith({
       port: 18789,
       bind: "loopback",
       customBindHost: undefined,
       basePath: undefined,
     });
-    expect(mocks.copyToClipboard).toHaveBeenCalledWith("http://127.0.0.1:18789/#token=abc123");
-    expect(mocks.openUrl).toHaveBeenCalledWith("http://127.0.0.1:18789/#token=abc123");
+    expect(copyToClipboardMock).toHaveBeenCalledWith("http://127.0.0.1:18789/#token=abc123");
+    expect(openUrlMock).toHaveBeenCalledWith("http://127.0.0.1:18789/#token=abc123");
     expect(runtime.log).toHaveBeenCalledWith(
       "Opened in your browser. Keep that tab to control OpenClaw.",
     );
@@ -92,27 +90,27 @@ describe("dashboardCommand", () => {
 
   it("prints SSH hint when browser cannot open", async () => {
     mockSnapshot("shhhh");
-    mocks.copyToClipboard.mockResolvedValue(false);
-    mocks.detectBrowserOpenSupport.mockResolvedValue({
+    copyToClipboardMock.mockResolvedValue(false);
+    detectBrowserOpenSupportMock.mockResolvedValue({
       ok: false,
       reason: "ssh",
     });
-    mocks.formatControlUiSshHint.mockReturnValue("ssh hint");
+    formatControlUiSshHintMock.mockReturnValue("ssh hint");
 
     await dashboardCommand(runtime);
 
-    expect(mocks.openUrl).not.toHaveBeenCalled();
+    expect(openUrlMock).not.toHaveBeenCalled();
     expect(runtime.log).toHaveBeenCalledWith("ssh hint");
   });
 
   it("respects --no-open and skips browser attempts", async () => {
     mockSnapshot();
-    mocks.copyToClipboard.mockResolvedValue(true);
+    copyToClipboardMock.mockResolvedValue(true);
 
     await dashboardCommand(runtime, { noOpen: true });
 
-    expect(mocks.detectBrowserOpenSupport).not.toHaveBeenCalled();
-    expect(mocks.openUrl).not.toHaveBeenCalled();
+    expect(detectBrowserOpenSupportMock).not.toHaveBeenCalled();
+    expect(openUrlMock).not.toHaveBeenCalled();
     expect(runtime.log).toHaveBeenCalledWith(
       "Browser launch disabled (--no-open). Use the URL above.",
     );