refactor(test): remove remaining command test duplication

This commit is contained in:
Peter Steinberger
2026-02-16 16:52:53 +00:00
parent 0d51869c3c
commit 5b185da366
5 changed files with 73 additions and 103 deletions

View File

@@ -1,23 +1,13 @@
import { beforeEach, describe, expect, it, vi } from "vitest";
import type { RuntimeEnv } from "../runtime.js";
const mocks = vi.hoisted(() => ({
createClackPrompter: vi.fn(),
runOnboardingWizard: vi.fn(),
restoreTerminalState: vi.fn(),
}));
const createClackPrompterMock = vi.hoisted(() => vi.fn());
const runOnboardingWizardMock = vi.hoisted(() => vi.fn());
const restoreTerminalStateMock = vi.hoisted(() => vi.fn());
vi.mock("../wizard/clack-prompter.js", () => ({
createClackPrompter: mocks.createClackPrompter,
}));
vi.mock("../wizard/onboarding.js", () => ({
runOnboardingWizard: mocks.runOnboardingWizard,
}));
vi.mock("../terminal/restore.js", () => ({
restoreTerminalState: mocks.restoreTerminalState,
}));
vi.mock("../wizard/clack-prompter.js", () => ({ createClackPrompter: createClackPrompterMock }));
vi.mock("../wizard/onboarding.js", () => ({ runOnboardingWizard: runOnboardingWizardMock }));
vi.mock("../terminal/restore.js", () => ({ restoreTerminalState: restoreTerminalStateMock }));
import { WizardCancelledError } from "../wizard/prompts.js";
import { runInteractiveOnboarding } from "./onboard-interactive.js";
@@ -30,35 +20,36 @@ const runtime: RuntimeEnv = {
describe("runInteractiveOnboarding", () => {
beforeEach(() => {
mocks.createClackPrompter.mockReset();
mocks.runOnboardingWizard.mockReset();
mocks.restoreTerminalState.mockReset();
createClackPrompterMock.mockReset();
runOnboardingWizardMock.mockReset();
restoreTerminalStateMock.mockReset();
runtime.log.mockClear();
runtime.error.mockClear();
runtime.exit.mockClear();
mocks.createClackPrompter.mockReturnValue({});
createClackPrompterMock.mockReturnValue({});
runOnboardingWizardMock.mockResolvedValue(undefined);
});
it("exits with code 1 when the wizard is cancelled", async () => {
mocks.runOnboardingWizard.mockRejectedValue(new WizardCancelledError());
runOnboardingWizardMock.mockRejectedValue(new WizardCancelledError());
await runInteractiveOnboarding({} as never, runtime);
expect(runtime.exit).toHaveBeenCalledWith(1);
expect(mocks.restoreTerminalState).toHaveBeenCalledWith("onboarding finish", {
expect(restoreTerminalStateMock).toHaveBeenCalledWith("onboarding finish", {
resumeStdinIfPaused: false,
});
});
it("rethrows non-cancel errors", async () => {
const err = new Error("boom");
mocks.runOnboardingWizard.mockRejectedValue(err);
runOnboardingWizardMock.mockRejectedValue(err);
await expect(runInteractiveOnboarding({} as never, runtime)).rejects.toThrow("boom");
expect(runtime.exit).not.toHaveBeenCalled();
expect(mocks.restoreTerminalState).toHaveBeenCalledWith("onboarding finish", {
expect(restoreTerminalStateMock).toHaveBeenCalledWith("onboarding finish", {
resumeStdinIfPaused: false,
});
});