chore: Enable "curly" rule to avoid single-statement if confusion/errors.

src/agents/pi-embedded-subscribe.tools.ts

@@ -7,48 +7,72 @@ const TOOL_RESULT_MAX_CHARS = 8000;
 const TOOL_ERROR_MAX_CHARS = 400;
 
 function truncateToolText(text: string): string {
-  if (text.length <= TOOL_RESULT_MAX_CHARS) return text;
+  if (text.length <= TOOL_RESULT_MAX_CHARS) {
+    return text;
+  }
   return `${truncateUtf16Safe(text, TOOL_RESULT_MAX_CHARS)}\n…(truncated)…`;
 }
 
 function normalizeToolErrorText(text: string): string | undefined {
   const trimmed = text.trim();
-  if (!trimmed) return undefined;
+  if (!trimmed) {
+    return undefined;
+  }
   const firstLine = trimmed.split(/\r?\n/)[0]?.trim() ?? "";
-  if (!firstLine) return undefined;
+  if (!firstLine) {
+    return undefined;
+  }
   return firstLine.length > TOOL_ERROR_MAX_CHARS
     ? `${truncateUtf16Safe(firstLine, TOOL_ERROR_MAX_CHARS)}…`
     : firstLine;
 }
 
 function readErrorCandidate(value: unknown): string | undefined {
-  if (typeof value === "string") return normalizeToolErrorText(value);
-  if (!value || typeof value !== "object") return undefined;
+  if (typeof value === "string") {
+    return normalizeToolErrorText(value);
+  }
+  if (!value || typeof value !== "object") {
+    return undefined;
+  }
   const record = value as Record<string, unknown>;
-  if (typeof record.message === "string") return normalizeToolErrorText(record.message);
-  if (typeof record.error === "string") return normalizeToolErrorText(record.error);
+  if (typeof record.message === "string") {
+    return normalizeToolErrorText(record.message);
+  }
+  if (typeof record.error === "string") {
+    return normalizeToolErrorText(record.error);
+  }
   return undefined;
 }
 
 function extractErrorField(value: unknown): string | undefined {
-  if (!value || typeof value !== "object") return undefined;
+  if (!value || typeof value !== "object") {
+    return undefined;
+  }
   const record = value as Record<string, unknown>;
   const direct =
     readErrorCandidate(record.error) ??
     readErrorCandidate(record.message) ??
     readErrorCandidate(record.reason);
-  if (direct) return direct;
+  if (direct) {
+    return direct;
+  }
   const status = typeof record.status === "string" ? record.status.trim() : "";
   return status ? normalizeToolErrorText(status) : undefined;
 }
 
 export function sanitizeToolResult(result: unknown): unknown {
-  if (!result || typeof result !== "object") return result;
+  if (!result || typeof result !== "object") {
+    return result;
+  }
   const record = result as Record<string, unknown>;
   const content = Array.isArray(record.content) ? record.content : null;
-  if (!content) return record;
+  if (!content) {
+    return record;
+  }
   const sanitized = content.map((item) => {
-    if (!item || typeof item !== "object") return item;
+    if (!item || typeof item !== "object") {
+      return item;
+    }
     const entry = item as Record<string, unknown>;
     const type = typeof entry.type === "string" ? entry.type : undefined;
     if (type === "text" && typeof entry.text === "string") {
@@ -67,47 +91,73 @@ export function sanitizeToolResult(result: unknown): unknown {
 }
 
 export function extractToolResultText(result: unknown): string | undefined {
-  if (!result || typeof result !== "object") return undefined;
+  if (!result || typeof result !== "object") {
+    return undefined;
+  }
   const record = result as Record<string, unknown>;
   const content = Array.isArray(record.content) ? record.content : null;
-  if (!content) return undefined;
+  if (!content) {
+    return undefined;
+  }
   const texts = content
     .map((item) => {
-      if (!item || typeof item !== "object") return undefined;
+      if (!item || typeof item !== "object") {
+        return undefined;
+      }
       const entry = item as Record<string, unknown>;
-      if (entry.type !== "text" || typeof entry.text !== "string") return undefined;
+      if (entry.type !== "text" || typeof entry.text !== "string") {
+        return undefined;
+      }
       const trimmed = entry.text.trim();
       return trimmed ? trimmed : undefined;
     })
     .filter((value): value is string => Boolean(value));
-  if (texts.length === 0) return undefined;
+  if (texts.length === 0) {
+    return undefined;
+  }
   return texts.join("\n");
 }
 
 export function isToolResultError(result: unknown): boolean {
-  if (!result || typeof result !== "object") return false;
+  if (!result || typeof result !== "object") {
+    return false;
+  }
   const record = result as { details?: unknown };
   const details = record.details;
-  if (!details || typeof details !== "object") return false;
+  if (!details || typeof details !== "object") {
+    return false;
+  }
   const status = (details as { status?: unknown }).status;
-  if (typeof status !== "string") return false;
+  if (typeof status !== "string") {
+    return false;
+  }
   const normalized = status.trim().toLowerCase();
   return normalized === "error" || normalized === "timeout";
 }
 
 export function extractToolErrorMessage(result: unknown): string | undefined {
-  if (!result || typeof result !== "object") return undefined;
+  if (!result || typeof result !== "object") {
+    return undefined;
+  }
   const record = result as Record<string, unknown>;
   const fromDetails = extractErrorField(record.details);
-  if (fromDetails) return fromDetails;
+  if (fromDetails) {
+    return fromDetails;
+  }
   const fromRoot = extractErrorField(record);
-  if (fromRoot) return fromRoot;
+  if (fromRoot) {
+    return fromRoot;
+  }
   const text = extractToolResultText(result);
-  if (!text) return undefined;
+  if (!text) {
+    return undefined;
+  }
   try {
     const parsed = JSON.parse(text) as unknown;
     const fromJson = extractErrorField(parsed);
-    if (fromJson) return fromJson;
+    if (fromJson) {
+      return fromJson;
+    }
   } catch {
     // Fall through to first-line text fallback.
   }
@@ -123,9 +173,13 @@ export function extractMessagingToolSend(
   const accountIdRaw = typeof args.accountId === "string" ? args.accountId.trim() : undefined;
   const accountId = accountIdRaw ? accountIdRaw : undefined;
   if (toolName === "message") {
-    if (action !== "send" && action !== "thread-reply") return undefined;
+    if (action !== "send" && action !== "thread-reply") {
+      return undefined;
+    }
     const toRaw = typeof args.to === "string" ? args.to : undefined;
-    if (!toRaw) return undefined;
+    if (!toRaw) {
+      return undefined;
+    }
     const providerRaw = typeof args.provider === "string" ? args.provider.trim() : "";
     const channelRaw = typeof args.channel === "string" ? args.channel.trim() : "";
     const providerHint = providerRaw || channelRaw;
@@ -135,10 +189,14 @@ export function extractMessagingToolSend(
     return to ? { tool: toolName, provider, accountId, to } : undefined;
   }
   const providerId = normalizeChannelId(toolName);
-  if (!providerId) return undefined;
+  if (!providerId) {
+    return undefined;
+  }
   const plugin = getChannelPlugin(providerId);
   const extracted = plugin?.actions?.extractToolSend?.({ args });
-  if (!extracted?.to) return undefined;
+  if (!extracted?.to) {
+    return undefined;
+  }
   const to = normalizeTargetForProvider(providerId, extracted.to);
   return to
     ? {