github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-10 17:34:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable "curly" rule to avoid single-statement if confusion/errors.

Browse Source
This commit is contained in:
cpojer
2026-01-31 16:19:20 +09:00
parent 009b16fab8
commit 5ceff756e1
1266 changed files with 27871 additions and 9393 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/browser/pw-tools-core.downloads.ts
View File

@@ -31,7 +31,9 @@ function createPageDownloadWaiter(page: Page, timeoutMs: number) {
let handler: ((download: unknown) => void) | undefined;
const cleanup = () => {
if (timer) clearTimeout(timer);
if (timer) {
clearTimeout(timer);
}
timer = undefined;
if (handler) {
page.off("download", handler as never);
@@ -41,7 +43,9 @@ function createPageDownloadWaiter(page: Page, timeoutMs: number) {
const promise = new Promise<unknown>((resolve, reject) => {
handler = (download: unknown) => {
if (done) return;
if (done) {
return;
}
done = true;
cleanup();
resolve(download);
@@ -49,7 +53,9 @@ function createPageDownloadWaiter(page: Page, timeoutMs: number) {
page.on("download", handler as never);
timer = setTimeout(() => {
if (done) return;
if (done) {
return;
}
done = true;
cleanup();
reject(new Error("Timeout waiting for download"));
@@ -59,7 +65,9 @@ function createPageDownloadWaiter(page: Page, timeoutMs: number) {
return {
promise,
cancel: () => {
if (done) return;
if (done) {
return;
}
done = true;
cleanup();
},
@@ -82,7 +90,9 @@ export async function armFileUploadViaPlaywright(opts: {
void page
.waitForEvent("filechooser", { timeout })
.then(async (fileChooser) => {
if (state.armIdUpload !== armId) return;
if (state.armIdUpload !== armId) {
return;
}
if (!opts.paths?.length) {
// Playwright removed `FileChooser.cancel()`; best-effort close the chooser instead.
try {
@@ -130,9 +140,14 @@ export async function armDialogViaPlaywright(opts: {
void page
.waitForEvent("dialog", { timeout })
.then(async (dialog) => {
if (state.armIdDialog !== armId) return;
if (opts.accept) await dialog.accept(opts.promptText);
else await dialog.dismiss();
if (state.armIdDialog !== armId) {
return;
}
if (opts.accept) {
await dialog.accept(opts.promptText);
} else {
await dialog.dismiss();
}
})
.catch(() => {
// Ignore timeouts; the dialog may never appear.
@@ -199,7 +214,9 @@ export async function downloadViaPlaywright(opts: {
const ref = requireRef(opts.ref);
const outPath = String(opts.path ?? "").trim();
if (!outPath) throw new Error("path is required");
if (!outPath) {
throw new Error("path is required");
}
state.armIdDownload = bumpDownloadArmId();
const armId = state.armIdDownload;