chore: Enable "curly" rule to avoid single-statement if confusion/errors.

This commit is contained in:
cpojer
2026-01-31 16:19:20 +09:00
parent 009b16fab8
commit 5ceff756e1
1266 changed files with 27871 additions and 9393 deletions

View File

@@ -4,8 +4,12 @@ import { normalizeTimeoutMs } from "./pw-tools-core.shared.js";
function matchUrlPattern(pattern: string, url: string): boolean {
const p = pattern.trim();
if (!p) return false;
if (p === url) return true;
if (!p) {
return false;
}
if (p === url) {
return true;
}
if (p.includes("*")) {
const escaped = p.replace(/[|\\{}()[\]^$+?.]/g, "\\$&");
const regex = new RegExp(`^${escaped.replace(/\*\*/g, ".*").replace(/\*/g, ".*")}$`);
@@ -28,7 +32,9 @@ export async function responseBodyViaPlaywright(opts: {
truncated?: boolean;
}> {
const pattern = String(opts.url ?? "").trim();
if (!pattern) throw new Error("url is required");
if (!pattern) {
throw new Error("url is required");
}
const maxChars =
typeof opts.maxChars === "number" && Number.isFinite(opts.maxChars)
? Math.max(1, Math.min(5_000_000, Math.floor(opts.maxChars)))
@@ -44,16 +50,24 @@ export async function responseBodyViaPlaywright(opts: {
let handler: ((resp: unknown) => void) | undefined;
const cleanup = () => {
if (timer) clearTimeout(timer);
if (timer) {
clearTimeout(timer);
}
timer = undefined;
if (handler) page.off("response", handler as never);
if (handler) {
page.off("response", handler as never);
}
};
handler = (resp: unknown) => {
if (done) return;
if (done) {
return;
}
const r = resp as { url?: () => string };
const u = r.url?.() || "";
if (!matchUrlPattern(pattern, u)) return;
if (!matchUrlPattern(pattern, u)) {
return;
}
done = true;
cleanup();
resolve(resp);
@@ -61,7 +75,9 @@ export async function responseBodyViaPlaywright(opts: {
page.on("response", handler as never);
timer = setTimeout(() => {
if (done) return;
if (done) {
return;
}
done = true;
cleanup();
reject(