github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-11 07:24:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable "curly" rule to avoid single-statement if confusion/errors.

Browse Source
This commit is contained in:
cpojer
2026-01-31 16:19:20 +09:00
parent 009b16fab8
commit 5ceff756e1
1266 changed files with 27871 additions and 9393 deletions
Download Patch File Download Diff File Expand all files Collapse all files

132
src/commands/health.ts
View File

@@ -79,8 +79,12 @@ const debugHealth = (...args: unknown[]) => {
};
const formatDurationParts = (ms: number): string => {
if (!Number.isFinite(ms)) return "unknown";
if (ms < 1000) return `${Math.max(0, Math.round(ms))}ms`;
if (!Number.isFinite(ms)) {
return "unknown";
}
if (ms < 1000) {
return `${Math.max(0, Math.round(ms))}ms`;
}
const units: Array<{ label: string; size: number }> = [
{ label: "w", size: 7 * 24 * 60 * 60 * 1000 },
{ label: "d", size: 24 * 60 * 60 * 1000 },
@@ -97,7 +101,9 @@ const formatDurationParts = (ms: number): string => {
remaining -= value * unit.size;
}
}
if (parts.length === 0) return "0s";
if (parts.length === 0) {
return "0s";
}
return parts.join(" ");
};
@@ -111,10 +117,16 @@ const resolveAgentOrder = (cfg: ReturnType<typeof loadConfig>) => {
const ordered: Array<{ id: string; name?: string }> = [];
for (const entry of entries) {
if (!entry || typeof entry !== "object") continue;
if (typeof entry.id !== "string" || !entry.id.trim()) continue;
if (!entry || typeof entry !== "object") {
continue;
}
if (typeof entry.id !== "string" || !entry.id.trim()) {
continue;
}
const id = normalizeAgentId(entry.id);
if (!id || seen.has(id)) continue;
if (!id || seen.has(id)) {
continue;
}
seen.add(id);
ordered.push({ id, name: typeof entry.name === "string" ? entry.name : undefined });
}
@@ -149,7 +161,9 @@ const buildSessionSummary = (storePath: string) => {
};
const isAccountEnabled = (account: unknown): boolean => {
if (!account || typeof account !== "object") return true;
if (!account || typeof account !== "object") {
return true;
}
const enabled = (account as { enabled?: boolean }).enabled;
return enabled !== false;
};
@@ -159,9 +173,13 @@ const asRecord = (value: unknown): Record<string, unknown> | null =>
const formatProbeLine = (probe: unknown, opts: { botUsernames?: string[] } = {}): string | null => {
const record = asRecord(probe);
if (!record) return null;
if (!record) {
return null;
}
const ok = typeof record.ok === "boolean" ? record.ok : undefined;
if (ok === undefined) return null;
if (ok === undefined) {
return null;
}
const elapsedMs = typeof record.elapsedMs === "number" ? record.elapsedMs : null;
const status = typeof record.status === "number" ? record.status : null;
const error = typeof record.error === "string" ? record.error : null;
@@ -171,9 +189,13 @@ const formatProbeLine = (probe: unknown, opts: { botUsernames?: string[] } = {})
const webhookUrl = webhook && typeof webhook.url === "string" ? webhook.url : null;
const usernames = new Set<string>();
if (botUsername) usernames.add(botUsername);
if (botUsername) {
usernames.add(botUsername);
}
for (const extra of opts.botUsernames ?? []) {
if (extra) usernames.add(extra);
if (extra) {
usernames.add(extra);
}
}
if (ok) {
@@ -181,21 +203,31 @@ const formatProbeLine = (probe: unknown, opts: { botUsernames?: string[] } = {})
if (usernames.size > 0) {
label += ` (@${Array.from(usernames).join(", @")})`;
}
if (elapsedMs != null) label += ` (${elapsedMs}ms)`;
if (webhookUrl) label += ` - webhook ${webhookUrl}`;
if (elapsedMs != null) {
label += ` (${elapsedMs}ms)`;
}
if (webhookUrl) {
label += ` - webhook ${webhookUrl}`;
}
return label;
}
let label = `failed (${status ?? "unknown"})`;
if (error) label += ` - ${error}`;
if (error) {
label += ` - ${error}`;
}
return label;
};
const formatAccountProbeTiming = (summary: ChannelAccountHealthSummary): string | null => {
const probe = asRecord(summary.probe);
if (!probe) return null;
if (!probe) {
return null;
}
const elapsedMs = typeof probe.elapsedMs === "number" ? Math.round(probe.elapsedMs) : null;
const ok = typeof probe.ok === "boolean" ? probe.ok : null;
if (elapsedMs == null && ok !== true) return null;
if (elapsedMs == null && ok !== true) {
return null;
}
const accountId = summary.accountId || "default";
const botRecord = asRecord(probe.bot);
@@ -209,14 +241,18 @@ const formatAccountProbeTiming = (summary: ChannelAccountHealthSummary): string
const isProbeFailure = (summary: ChannelAccountHealthSummary): boolean => {
const probe = asRecord(summary.probe);
if (!probe) return false;
if (!probe) {
return false;
}
const ok = typeof probe.ok === "boolean" ? probe.ok : null;
return ok === false;
};
function styleHealthChannelLine(line: string): string {
const colon = line.indexOf(":");
if (colon === -1) return line;
if (colon === -1) {
return line;
}
const label = line.slice(0, colon + 1);
const detail = line.slice(colon + 1).trimStart();
@@ -225,13 +261,27 @@ function styleHealthChannelLine(line: string): string {
const applyPrefix = (prefix: string, color: (value: string) => string) =>
`${label} ${color(detail.slice(0, prefix.length))}${detail.slice(prefix.length)}`;
if (normalized.startsWith("failed")) return applyPrefix("failed", theme.error);
if (normalized.startsWith("ok")) return applyPrefix("ok", theme.success);
if (normalized.startsWith("linked")) return applyPrefix("linked", theme.success);
if (normalized.startsWith("configured")) return applyPrefix("configured", theme.success);
if (normalized.startsWith("not linked")) return applyPrefix("not linked", theme.warn);
if (normalized.startsWith("not configured")) return applyPrefix("not configured", theme.muted);
if (normalized.startsWith("unknown")) return applyPrefix("unknown", theme.warn);
if (normalized.startsWith("failed")) {
return applyPrefix("failed", theme.error);
}
if (normalized.startsWith("ok")) {
return applyPrefix("ok", theme.success);
}
if (normalized.startsWith("linked")) {
return applyPrefix("linked", theme.success);
}
if (normalized.startsWith("configured")) {
return applyPrefix("configured", theme.success);
}
if (normalized.startsWith("not linked")) {
return applyPrefix("not linked", theme.warn);
}
if (normalized.startsWith("not configured")) {
return applyPrefix("not configured", theme.muted);
}
if (normalized.startsWith("unknown")) {
return applyPrefix("unknown", theme.warn);
}
return line;
}
@@ -251,7 +301,9 @@ export const formatHealthChannelLines = (
const lines: string[] = [];
for (const channelId of channelOrder) {
const channelSummary = channels[channelId];
if (!channelSummary) continue;
if (!channelSummary) {
continue;
}
const plugin = getChannelPlugin(channelId as never);
const label = summary.channelLabels?.[channelId] ?? plugin?.meta.label ?? channelId;
const accountSummaries = channelSummary.accounts ?? {};
@@ -440,8 +492,12 @@ export async function getHealthSnapshot(params?: {
enabled,
configured,
};
if (probe !== undefined) snapshot.probe = probe;
if (lastProbeAt) snapshot.lastProbeAt = lastProbeAt;
if (probe !== undefined) {
snapshot.probe = probe;
}
if (lastProbeAt) {
snapshot.lastProbeAt = lastProbeAt;
}
const summary = plugin.status?.buildChannelSummary
? await plugin.status.buildChannelSummary({
@@ -460,7 +516,9 @@ export async function getHealthSnapshot(params?: {
probe,
lastProbeAt,
} satisfies ChannelAccountHealthSummary);
if (record.configured === undefined) record.configured = configured;
if (record.configured === undefined) {
record.configured = configured;
}
if (record.lastProbeAt === undefined && lastProbeAt) {
record.lastProbeAt = lastProbeAt;
}
@@ -621,10 +679,14 @@ export async function healthCommand(
for (const agent of entries) {
const ids = byAgent.get(agent.agentId) ?? [];
for (const id of ids) {
if (!accountIds.includes(id)) accountIds.push(id);
if (!accountIds.includes(id)) {
accountIds.push(id);
}
}
}
if (accountIds.length > 0) byChannel[channelId] = accountIds;
if (accountIds.length > 0) {
byChannel[channelId] = accountIds;
}
}
for (const [channelId, fallbackIds] of Object.entries(channelAccountFallbacks)) {
if (!byChannel[channelId] || byChannel[channelId].length === 0) {
@@ -647,8 +709,12 @@ export async function healthCommand(
}
for (const plugin of listChannelPlugins()) {
const channelSummary = summary.channels?.[plugin.id];
if (!channelSummary || channelSummary.linked !== true) continue;
if (!plugin.status?.logSelfId) continue;
if (!channelSummary || channelSummary.linked !== true) {
continue;
}
if (!plugin.status?.logSelfId) {
continue;
}
const boundAccounts = channelBindings.get(plugin.id)?.get(defaultAgentId) ?? [];
const accountIds = plugin.config.listAccountIds(cfg);
const defaultAccountId = resolveChannelDefaultAccountId({