chore: Enable "curly" rule to avoid single-statement if confusion/errors.

This commit is contained in:
cpojer
2026-01-31 16:19:20 +09:00
parent 009b16fab8
commit 5ceff756e1
1266 changed files with 27871 additions and 9393 deletions

View File

@@ -16,12 +16,18 @@ function parseShellEnv(stdout: Buffer): Map<string, string> {
const shellEnv = new Map<string, string>();
const parts = stdout.toString("utf8").split("\0");
for (const part of parts) {
if (!part) continue;
if (!part) {
continue;
}
const eq = part.indexOf("=");
if (eq <= 0) continue;
if (eq <= 0) {
continue;
}
const key = part.slice(0, eq);
const value = part.slice(eq + 1);
if (!key) continue;
if (!key) {
continue;
}
shellEnv.set(key, value);
}
return shellEnv;
@@ -83,9 +89,13 @@ export function loadShellEnvFallback(opts: ShellEnvFallbackOptions): ShellEnvFal
const applied: string[] = [];
for (const key of opts.expectedKeys) {
if (opts.env[key]?.trim()) continue;
if (opts.env[key]?.trim()) {
continue;
}
const value = shellEnv.get(key);
if (!value?.trim()) continue;
if (!value?.trim()) {
continue;
}
opts.env[key] = value;
applied.push(key);
}
@@ -104,9 +114,13 @@ export function shouldDeferShellEnvFallback(env: NodeJS.ProcessEnv): boolean {
export function resolveShellEnvFallbackTimeoutMs(env: NodeJS.ProcessEnv): number {
const raw = env.OPENCLAW_SHELL_ENV_TIMEOUT_MS?.trim();
if (!raw) return DEFAULT_TIMEOUT_MS;
if (!raw) {
return DEFAULT_TIMEOUT_MS;
}
const parsed = Number.parseInt(raw, 10);
if (!Number.isFinite(parsed)) return DEFAULT_TIMEOUT_MS;
if (!Number.isFinite(parsed)) {
return DEFAULT_TIMEOUT_MS;
}
return Math.max(0, parsed);
}
@@ -115,7 +129,9 @@ export function getShellPathFromLoginShell(opts: {
timeoutMs?: number;
exec?: typeof execFileSync;
}): string | null {
if (cachedShellPath !== undefined) return cachedShellPath;
if (cachedShellPath !== undefined) {
return cachedShellPath;
}
if (process.platform === "win32") {
cachedShellPath = null;
return cachedShellPath;