github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-10 17:44:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(commands): dedupe signal install extract fixture and cover zip extract

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-21 19:31:03 +00:00
parent 3274a1b804
commit 5d61afb362
1 changed files with 29 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/commands/signal-install.test.ts
View File

@@ -133,9 +133,17 @@ describe("pickAsset", () => {
}); });
describe("extractSignalCliArchive", () => { describe("extractSignalCliArchive", () => {
it("rejects zip slip path traversal", async () => { async function withArchiveWorkspace(run: (workDir: string) => Promise<void>) {
const workDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-signal-install-")); const workDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-signal-install-"));
try { try {
await run(workDir);
} finally {
await fs.rm(workDir, { recursive: true, force: true }).catch(() => undefined);
}
}
it("rejects zip slip path traversal", async () => {
await withArchiveWorkspace(async (workDir) => {
const archivePath = path.join(workDir, "bad.zip"); const archivePath = path.join(workDir, "bad.zip");
const extractDir = path.join(workDir, "extract"); const extractDir = path.join(workDir, "extract");
await fs.mkdir(extractDir, { recursive: true }); await fs.mkdir(extractDir, { recursive: true });
@@ -147,14 +155,28 @@ describe("extractSignalCliArchive", () => {
await expect(extractSignalCliArchive(archivePath, extractDir, 5_000)).rejects.toThrow( await expect(extractSignalCliArchive(archivePath, extractDir, 5_000)).rejects.toThrow(
/(escapes destination|absolute)/i, /(escapes destination|absolute)/i,
); );
} finally { });
await fs.rm(workDir, { recursive: true, force: true }).catch(() => undefined); });
}
it("extracts zip archives", async () => {
await withArchiveWorkspace(async (workDir) => {
const archivePath = path.join(workDir, "ok.zip");
const extractDir = path.join(workDir, "extract");
await fs.mkdir(extractDir, { recursive: true });
const zip = new JSZip();
zip.file("root/signal-cli", "bin");
await fs.writeFile(archivePath, await zip.generateAsync({ type: "nodebuffer" }));
await extractSignalCliArchive(archivePath, extractDir, 5_000);
const extracted = await fs.readFile(path.join(extractDir, "root", "signal-cli"), "utf-8");
expect(extracted).toBe("bin");
});
}); });
it("extracts tar.gz archives", async () => { it("extracts tar.gz archives", async () => {
const workDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-signal-install-")); await withArchiveWorkspace(async (workDir) => {
try {
const archivePath = path.join(workDir, "ok.tgz"); const archivePath = path.join(workDir, "ok.tgz");
const extractDir = path.join(workDir, "extract"); const extractDir = path.join(workDir, "extract");
const rootDir = path.join(workDir, "root"); const rootDir = path.join(workDir, "root");
@@ -167,8 +189,6 @@ describe("extractSignalCliArchive", () => {
const extracted = await fs.readFile(path.join(extractDir, "root", "signal-cli"), "utf-8"); const extracted = await fs.readFile(path.join(extractDir, "root", "signal-cli"), "utf-8");
expect(extracted).toBe("bin"); expect(extracted).toBe("bin");
} finally { });
await fs.rm(workDir, { recursive: true, force: true }).catch(() => undefined);
}
}); });
}); });