refactor: centralize target errors and cache lookups

src/channels/plugins/outbound/discord.ts

@@ -1,5 +1,6 @@
 import { sendMessageDiscord, sendPollDiscord } from "../../../discord/send.js";
 import type { ChannelOutboundAdapter } from "../types.js";
+import { missingTargetError } from "../../../infra/outbound/target-errors.js";
 
 export const discordOutbound: ChannelOutboundAdapter = {
   deliveryMode: "direct",
@@ -11,7 +12,7 @@ export const discordOutbound: ChannelOutboundAdapter = {
     if (!trimmed) {
       return {
         ok: false,
-        error: new Error("Delivering to Discord requires target <channelId|user:ID|channel:ID>"),
+        error: missingTargetError("Discord", "<channelId|user:ID|channel:ID>"),
       };
     }
     return { ok: true, to: trimmed };

src/channels/plugins/outbound/imessage.ts

@@ -2,6 +2,7 @@ import { chunkText } from "../../../auto-reply/chunk.js";
 import { sendMessageIMessage } from "../../../imessage/send.js";
 import { resolveChannelMediaMaxBytes } from "../media-limits.js";
 import type { ChannelOutboundAdapter } from "../types.js";
+import { missingTargetError } from "../../../infra/outbound/target-errors.js";
 
 export const imessageOutbound: ChannelOutboundAdapter = {
   deliveryMode: "direct",
@@ -12,7 +13,7 @@ export const imessageOutbound: ChannelOutboundAdapter = {
     if (!trimmed) {
       return {
         ok: false,
-        error: new Error("Delivering to iMessage requires target <handle|chat_id:ID>"),
+        error: missingTargetError("iMessage", "<handle|chat_id:ID>"),
       };
     }
     return { ok: true, to: trimmed };

src/channels/plugins/outbound/signal.ts

@@ -2,6 +2,7 @@ import { chunkText } from "../../../auto-reply/chunk.js";
 import { sendMessageSignal } from "../../../signal/send.js";
 import { resolveChannelMediaMaxBytes } from "../media-limits.js";
 import type { ChannelOutboundAdapter } from "../types.js";
+import { missingTargetError } from "../../../infra/outbound/target-errors.js";
 
 export const signalOutbound: ChannelOutboundAdapter = {
   deliveryMode: "direct",
@@ -12,9 +13,7 @@ export const signalOutbound: ChannelOutboundAdapter = {
     if (!trimmed) {
       return {
         ok: false,
-        error: new Error(
-          "Delivering to Signal requires target <E.164|group:ID|signal:group:ID|signal:+E.164>",
-        ),
+        error: missingTargetError("Signal", "<E.164|group:ID|signal:group:ID|signal:+E.164>"),
       };
     }
     return { ok: true, to: trimmed };

src/channels/plugins/outbound/slack.ts

@@ -1,5 +1,6 @@
 import { sendMessageSlack } from "../../../slack/send.js";
 import type { ChannelOutboundAdapter } from "../types.js";
+import { missingTargetError } from "../../../infra/outbound/target-errors.js";
 
 export const slackOutbound: ChannelOutboundAdapter = {
   deliveryMode: "direct",
@@ -10,7 +11,7 @@ export const slackOutbound: ChannelOutboundAdapter = {
     if (!trimmed) {
       return {
         ok: false,
-        error: new Error("Delivering to Slack requires target <channelId|user:ID|channel:ID>"),
+        error: missingTargetError("Slack", "<channelId|user:ID|channel:ID>"),
       };
     }
     return { ok: true, to: trimmed };

src/channels/plugins/outbound/telegram.ts

@@ -1,6 +1,7 @@
 import { markdownToTelegramHtmlChunks } from "../../../telegram/format.js";
 import { sendMessageTelegram } from "../../../telegram/send.js";
 import type { ChannelOutboundAdapter } from "../types.js";
+import { missingTargetError } from "../../../infra/outbound/target-errors.js";
 
 function parseReplyToMessageId(replyToId?: string | null) {
   if (!replyToId) return undefined;
@@ -27,7 +28,7 @@ export const telegramOutbound: ChannelOutboundAdapter = {
     if (!trimmed) {
       return {
         ok: false,
-        error: new Error("Delivering to Telegram requires target <chatId>"),
+        error: missingTargetError("Telegram", "<chatId>"),
       };
     }
     return { ok: true, to: trimmed };

src/channels/plugins/outbound/whatsapp.ts

@@ -3,6 +3,7 @@ import { shouldLogVerbose } from "../../../globals.js";
 import { sendMessageWhatsApp, sendPollWhatsApp } from "../../../web/outbound.js";
 import { isWhatsAppGroupJid, normalizeWhatsAppTarget } from "../../../whatsapp/normalize.js";
 import type { ChannelOutboundAdapter } from "../types.js";
+import { missingTargetError } from "../../../infra/outbound/target-errors.js";
 
 export const whatsappOutbound: ChannelOutboundAdapter = {
   deliveryMode: "gateway",
@@ -26,8 +27,9 @@ export const whatsappOutbound: ChannelOutboundAdapter = {
         }
         return {
           ok: false,
-          error: new Error(
-            "Delivering to WhatsApp requires target <E.164|group JID> or channels.whatsapp.allowFrom[0]",
+          error: missingTargetError(
+            "WhatsApp",
+            "<E.164|group JID> or channels.whatsapp.allowFrom[0]",
           ),
         };
       }
@@ -51,8 +53,9 @@ export const whatsappOutbound: ChannelOutboundAdapter = {
     }
     return {
       ok: false,
-      error: new Error(
-        "Delivering to WhatsApp requires target <E.164|group JID> or channels.whatsapp.allowFrom[0]",
+      error: missingTargetError(
+        "WhatsApp",
+        "<E.164|group JID> or channels.whatsapp.allowFrom[0]",
       ),
     };
   },