github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-13 03:40:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(infra): avoid EISDIR leak to messaging when Read targets directory (Closes #31186)

Browse Source
This commit is contained in:
倪汉杰0668001185
2026-03-02 10:55:36 +08:00
committed by Peter Steinberger
parent 8a4d8c889c
commit 6398a0ba8f
2 changed files with 40 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/infra/fs-safe.test.ts
View File

@@ -73,6 +73,22 @@ describe("fs-safe", () => {
).rejects.toMatchObject({ code: "outside-workspace" });
});
it("rejects directory path within root without leaking EISDIR (issue #31186)", async () => {
const root = await tempDirs.make("openclaw-fs-safe-root-");
await fs.mkdir(path.join(root, "memory"), { recursive: true });
await expect(
openFileWithinRoot({ rootDir: root, relativePath: "memory" }),
).rejects.toMatchObject({ code: expect.stringMatching(/invalid-path|not-file/) });
const err = await openFileWithinRoot({
rootDir: root,
relativePath: "memory",
}).catch((e: unknown) => e);
expect(err).toBeInstanceOf(SafeOpenError);
expect((err as SafeOpenError).message).not.toMatch(/EISDIR/i);
});
it("reads a file within root", async () => {
const root = await tempDirs.make("openclaw-fs-safe-root-");
await fs.writeFile(path.join(root, "inside.txt"), "inside");