test: dedupe line and whatsapp target resolution tests

src/line/webhook.test.ts

@@ -1,4 +1,5 @@
 import crypto from "node:crypto";
+import type { WebhookRequestBody } from "@line/bot-sdk";
 import { describe, expect, it, vi } from "vitest";
 import { createLineWebhookMiddleware } from "./webhook.js";
 
@@ -17,126 +18,97 @@ const createRes = () => {
   return res;
 };
 
-describe("createLineWebhookMiddleware", () => {
-  it("parses JSON from raw string body", async () => {
-    const onEvents = vi.fn(async () => {});
-    const secret = "secret";
-    const rawBody = JSON.stringify({ events: [{ type: "message" }] });
-    const middleware = createLineWebhookMiddleware({ channelSecret: secret, onEvents });
+const SECRET = "secret";
 
-    const req = {
-      headers: { "x-line-signature": sign(rawBody, secret) },
-      body: rawBody,
-      // oxlint-disable-next-line typescript/no-explicit-any
-    } as any;
-    const res = createRes();
-
-    // oxlint-disable-next-line typescript/no-explicit-any
-    await middleware(req, res, {} as any);
-
-    expect(res.status).toHaveBeenCalledWith(200);
-    expect(onEvents).toHaveBeenCalledWith(expect.objectContaining({ events: expect.any(Array) }));
+async function invokeWebhook(params: {
+  body: unknown;
+  headers?: Record<string, string>;
+  onEvents?: ReturnType<typeof vi.fn>;
+  autoSign?: boolean;
+}) {
+  const onEventsMock = params.onEvents ?? vi.fn(async () => {});
+  const middleware = createLineWebhookMiddleware({
+    channelSecret: SECRET,
+    onEvents: onEventsMock as unknown as (body: WebhookRequestBody) => Promise<void>,
   });
 
-  it("parses JSON from raw buffer body", async () => {
-    const onEvents = vi.fn(async () => {});
-    const secret = "secret";
-    const rawBody = JSON.stringify({ events: [{ type: "follow" }] });
-    const middleware = createLineWebhookMiddleware({ channelSecret: secret, onEvents });
-
-    const req = {
-      headers: { "x-line-signature": sign(rawBody, secret) },
-      body: Buffer.from(rawBody, "utf-8"),
-      // oxlint-disable-next-line typescript/no-explicit-any
-    } as any;
-    const res = createRes();
+  const headers = { ...params.headers };
+  const autoSign = params.autoSign ?? true;
+  if (autoSign && !headers["x-line-signature"]) {
+    if (typeof params.body === "string") {
+      headers["x-line-signature"] = sign(params.body, SECRET);
+    } else if (Buffer.isBuffer(params.body)) {
+      headers["x-line-signature"] = sign(params.body.toString("utf-8"), SECRET);
+    }
+  }
 
+  const req = {
+    headers,
+    body: params.body,
     // oxlint-disable-next-line typescript/no-explicit-any
-    await middleware(req, res, {} as any);
+  } as any;
+  const res = createRes();
+  // oxlint-disable-next-line typescript/no-explicit-any
+  await middleware(req, res, {} as any);
+  return { res, onEvents: onEventsMock };
+}
 
+describe("createLineWebhookMiddleware", () => {
+  it.each([
+    ["raw string body", JSON.stringify({ events: [{ type: "message" }] })],
+    ["raw buffer body", Buffer.from(JSON.stringify({ events: [{ type: "follow" }] }), "utf-8")],
+  ])("parses JSON from %s", async (_label, body) => {
+    const { res, onEvents } = await invokeWebhook({ body });
     expect(res.status).toHaveBeenCalledWith(200);
     expect(onEvents).toHaveBeenCalledWith(expect.objectContaining({ events: expect.any(Array) }));
   });
 
   it("rejects invalid JSON payloads", async () => {
-    const onEvents = vi.fn(async () => {});
-    const secret = "secret";
-    const rawBody = "not json";
-    const middleware = createLineWebhookMiddleware({ channelSecret: secret, onEvents });
-
-    const req = {
-      headers: { "x-line-signature": sign(rawBody, secret) },
-      body: rawBody,
-      // oxlint-disable-next-line typescript/no-explicit-any
-    } as any;
-    const res = createRes();
-
-    // oxlint-disable-next-line typescript/no-explicit-any
-    await middleware(req, res, {} as any);
-
+    const { res, onEvents } = await invokeWebhook({ body: "not json" });
     expect(res.status).toHaveBeenCalledWith(400);
     expect(onEvents).not.toHaveBeenCalled();
   });
 
   it("rejects webhooks with invalid signatures", async () => {
-    const onEvents = vi.fn(async () => {});
-    const secret = "secret";
-    const rawBody = JSON.stringify({ events: [{ type: "message" }] });
-    const middleware = createLineWebhookMiddleware({ channelSecret: secret, onEvents });
-
-    const req = {
+    const { res, onEvents } = await invokeWebhook({
+      body: JSON.stringify({ events: [{ type: "message" }] }),
       headers: { "x-line-signature": "invalid-signature" },
-      body: rawBody,
-      // oxlint-disable-next-line typescript/no-explicit-any
-    } as any;
-    const res = createRes();
-
-    // oxlint-disable-next-line typescript/no-explicit-any
-    await middleware(req, res, {} as any);
-
+    });
     expect(res.status).toHaveBeenCalledWith(401);
     expect(onEvents).not.toHaveBeenCalled();
   });
 
   it("returns 200 for verification request (empty events, no signature)", async () => {
-    const onEvents = vi.fn(async () => {});
-    const secret = "secret";
-    const rawBody = JSON.stringify({ events: [] });
-    const middleware = createLineWebhookMiddleware({ channelSecret: secret, onEvents });
-
-    const req = {
+    const { res, onEvents } = await invokeWebhook({
+      body: JSON.stringify({ events: [] }),
       headers: {},
-      body: rawBody,
-      // oxlint-disable-next-line typescript/no-explicit-any
-    } as any;
-    const res = createRes();
-
-    // oxlint-disable-next-line typescript/no-explicit-any
-    await middleware(req, res, {} as any);
-
+      autoSign: false,
+    });
     expect(res.status).toHaveBeenCalledWith(200);
     expect(res.json).toHaveBeenCalledWith({ status: "ok" });
     expect(onEvents).not.toHaveBeenCalled();
   });
 
   it("rejects missing signature when events are non-empty", async () => {
-    const onEvents = vi.fn(async () => {});
-    const secret = "secret";
-    const rawBody = JSON.stringify({ events: [{ type: "message" }] });
-    const middleware = createLineWebhookMiddleware({ channelSecret: secret, onEvents });
-
-    const req = {
+    const { res, onEvents } = await invokeWebhook({
+      body: JSON.stringify({ events: [{ type: "message" }] }),
       headers: {},
-      body: rawBody,
-      // oxlint-disable-next-line typescript/no-explicit-any
-    } as any;
-    const res = createRes();
-
-    // oxlint-disable-next-line typescript/no-explicit-any
-    await middleware(req, res, {} as any);
-
+      autoSign: false,
+    });
     expect(res.status).toHaveBeenCalledWith(400);
     expect(res.json).toHaveBeenCalledWith({ error: "Missing X-Line-Signature header" });
     expect(onEvents).not.toHaveBeenCalled();
   });
+
+  it("rejects signed requests when raw body is missing", async () => {
+    const { res, onEvents } = await invokeWebhook({
+      body: { events: [{ type: "message" }] },
+      headers: { "x-line-signature": "signed" },
+    });
+    expect(res.status).toHaveBeenCalledWith(400);
+    expect(res.json).toHaveBeenCalledWith({
+      error: "Missing raw request body for signature verification",
+    });
+    expect(onEvents).not.toHaveBeenCalled();
+  });
 });