github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-11 04:24:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(channels): dedupe plugin routing and channel helpers

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-22 14:05:46 +00:00
parent 7abae052f9
commit 66f814a0af
57 changed files with 3744 additions and 2127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

96
src/slack/channel-migration.test.ts
View File

@@ -1,17 +1,38 @@
import { describe, expect, it } from "vitest";
import { migrateSlackChannelConfig } from "./channel-migration.js";
import { migrateSlackChannelConfig, migrateSlackChannelsInPlace } from "./channel-migration.js";
describe("migrateSlackChannelConfig", () => {
it("migrates global channel ids", () => {
const cfg = {
channels: {
slack: {
channels: {
C123: { requireMention: false },
function createSlackGlobalChannelConfig(channels: Record<string, Record<string, unknown>>) {
return {
channels: {
slack: {
channels,
},
},
};
}
function createSlackAccountChannelConfig(
accountId: string,
channels: Record<string, Record<string, unknown>>,
) {
return {
channels: {
slack: {
accounts: {
[accountId]: {
channels,
},
},
},
};
},
};
}
describe("migrateSlackChannelConfig", () => {
it("migrates global channel ids", () => {
const cfg = createSlackGlobalChannelConfig({
C123: { requireMention: false },
});
const result = migrateSlackChannelConfig({
cfg,
@@ -27,19 +48,9 @@ describe("migrateSlackChannelConfig", () => {
});
it("migrates account-scoped channels", () => {
const cfg = {
channels: {
slack: {
accounts: {
primary: {
channels: {
C123: { requireMention: true },
},
},
},
},
},
};
const cfg = createSlackAccountChannelConfig("primary", {
C123: { requireMention: true },
});
const result = migrateSlackChannelConfig({
cfg,
@@ -56,19 +67,9 @@ describe("migrateSlackChannelConfig", () => {
});
it("matches account ids case-insensitively", () => {
const cfg = {
channels: {
slack: {
accounts: {
Primary: {
channels: {
C123: {},
},
},
},
},
},
};
const cfg = createSlackAccountChannelConfig("Primary", {
C123: {},
});
const result = migrateSlackChannelConfig({
cfg,
@@ -84,16 +85,10 @@ describe("migrateSlackChannelConfig", () => {
});
it("skips migration when new id already exists", () => {
const cfg = {
channels: {
slack: {
channels: {
C123: { requireMention: true },
C999: { requireMention: false },
},
},
},
};
const cfg = createSlackGlobalChannelConfig({
C123: { requireMention: true },
C999: { requireMention: false },
});
const result = migrateSlackChannelConfig({
cfg,
@@ -109,4 +104,15 @@ describe("migrateSlackChannelConfig", () => {
C999: { requireMention: false },
});
});
it("no-ops when old and new channel ids are the same", () => {
const channels = {
C123: { requireMention: true },
};
const result = migrateSlackChannelsInPlace(channels, "C123", "C123");
expect(result).toEqual({ migrated: false, skippedExisting: false });
expect(channels).toEqual({
C123: { requireMention: true },
});
});
});