Agents: add fallback reply for tool-only completions

This commit is contained in:
Vignesh Natarajan
2026-02-22 00:23:25 -08:00
parent 8a0a28763e
commit 6ceadaa41f
3 changed files with 47 additions and 1 deletions

View File

@@ -145,6 +145,42 @@ describe("buildEmbeddedRunPayloads", () => {
expect(payloads[0]?.text).toBe("All good");
});
it("adds completion fallback when tools run successfully without final assistant text", () => {
const payloads = buildPayloads({
toolMetas: [{ toolName: "write", meta: "/tmp/out.md" }],
lastAssistant: makeAssistant({
stopReason: "stop",
errorMessage: undefined,
content: [],
}),
});
expect(payloads).toHaveLength(1);
expect(payloads[0]?.isError).toBeUndefined();
expect(payloads[0]?.text).toBe("✅ Done.");
});
it("does not add completion fallback when the run still has a tool error", () => {
const payloads = buildPayloads({
toolMetas: [{ toolName: "browser", meta: "open https://example.com" }],
lastToolError: { toolName: "browser", error: "url required" },
});
expect(payloads).toHaveLength(0);
});
it("does not add completion fallback when no tools ran", () => {
const payloads = buildPayloads({
lastAssistant: makeAssistant({
stopReason: "stop",
errorMessage: undefined,
content: [],
}),
});
expect(payloads).toHaveLength(0);
});
it("adds tool error fallback when the assistant only invoked tools and verbose mode is on", () => {
const payloads = buildPayloads({
lastAssistant: makeAssistant({

View File

@@ -294,7 +294,7 @@ export function buildEmbeddedRunPayloads(params: {
}
const hasAudioAsVoiceTag = replyItems.some((item) => item.audioAsVoice);
return replyItems
const payloads = replyItems
.map((item) => ({
text: item.text?.trim() ? item.text.trim() : undefined,
mediaUrls: item.media?.length ? item.media : undefined,
@@ -314,4 +314,13 @@ export function buildEmbeddedRunPayloads(params: {
}
return true;
});
if (
payloads.length === 0 &&
params.toolMetas.length > 0 &&
!params.lastToolError &&
!lastAssistantErrored
) {
return [{ text: "✅ Done." }];
}
return payloads;
}