test: speed up skills test suites

src/agents/skills.buildworkspaceskillsnapshot.test.ts

@@ -1,6 +1,7 @@
 import fs from "node:fs/promises";
 import path from "node:path";
 import { afterEach, describe, expect, it } from "vitest";
+import { withEnv } from "../test-utils/env.js";
 import { createTrackedTempDirs } from "../test-utils/tracked-temp-dirs.js";
 import { writeSkill } from "./skills.e2e-test-helpers.js";
 import { buildWorkspaceSkillSnapshot, buildWorkspaceSkillsPrompt } from "./skills.js";
@@ -11,14 +12,20 @@ afterEach(async () => {
   await tempDirs.cleanup();
 });
 
+function withWorkspaceHome<T>(workspaceDir: string, cb: () => T): T {
+  return withEnv({ HOME: workspaceDir, PATH: "" }, cb);
+}
+
 describe("buildWorkspaceSkillSnapshot", () => {
   it("returns an empty snapshot when skills dirs are missing", async () => {
     const workspaceDir = await tempDirs.make("openclaw-");
 
-    const snapshot = buildWorkspaceSkillSnapshot(workspaceDir, {
-      managedSkillsDir: path.join(workspaceDir, ".managed"),
-      bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-    });
+    const snapshot = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillSnapshot(workspaceDir, {
+        managedSkillsDir: path.join(workspaceDir, ".managed"),
+        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
+      }),
+    );
 
     expect(snapshot.prompt).toBe("");
     expect(snapshot.skills).toEqual([]);
@@ -38,10 +45,12 @@ describe("buildWorkspaceSkillSnapshot", () => {
       frontmatterExtra: "disable-model-invocation: true",
     });
 
-    const snapshot = buildWorkspaceSkillSnapshot(workspaceDir, {
-      managedSkillsDir: path.join(workspaceDir, ".managed"),
-      bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-    });
+    const snapshot = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillSnapshot(workspaceDir, {
+        managedSkillsDir: path.join(workspaceDir, ".managed"),
+        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
+      }),
+    );
 
     expect(snapshot.prompt).toContain("visible-skill");
     expect(snapshot.prompt).not.toContain("hidden-skill");
@@ -86,8 +95,12 @@ describe("buildWorkspaceSkillSnapshot", () => {
       },
     };
 
-    const snapshot = buildWorkspaceSkillSnapshot(workspaceDir, opts);
-    const prompt = buildWorkspaceSkillsPrompt(workspaceDir, opts);
+    const snapshot = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillSnapshot(workspaceDir, opts),
+    );
+    const prompt = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillsPrompt(workspaceDir, opts),
+    );
 
     expect(snapshot.prompt).toBe(prompt);
   });
@@ -95,38 +108,40 @@ describe("buildWorkspaceSkillSnapshot", () => {
   it("truncates the skills prompt when it exceeds the configured char budget", async () => {
     const workspaceDir = await tempDirs.make("openclaw-");
 
-    // Make a bunch of skills with very long descriptions.
-    for (let i = 0; i < 25; i += 1) {
+    // Keep fixture size modest while still forcing truncation logic.
+    for (let i = 0; i < 8; i += 1) {
       const name = `skill-${String(i).padStart(2, "0")}`;
       await writeSkill({
         dir: path.join(workspaceDir, "skills", name),
         name,
-        description: "x".repeat(5000),
+        description: "x".repeat(800),
       });
     }
 
-    const snapshot = buildWorkspaceSkillSnapshot(workspaceDir, {
-      config: {
-        skills: {
-          limits: {
-            maxSkillsInPrompt: 100,
-            maxSkillsPromptChars: 1500,
+    const snapshot = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillSnapshot(workspaceDir, {
+        config: {
+          skills: {
+            limits: {
+              maxSkillsInPrompt: 100,
+              maxSkillsPromptChars: 500,
+            },
           },
         },
-      },
-      managedSkillsDir: path.join(workspaceDir, ".managed"),
-      bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-    });
+        managedSkillsDir: path.join(workspaceDir, ".managed"),
+        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
+      }),
+    );
 
     expect(snapshot.prompt).toContain("⚠️ Skills truncated");
-    expect(snapshot.prompt.length).toBeLessThan(5000);
+    expect(snapshot.prompt.length).toBeLessThan(2000);
   });
 
   it("limits discovery for nested repo-style skills roots (dir/skills/*)", async () => {
     const workspaceDir = await tempDirs.make("openclaw-");
     const repoDir = await tempDirs.make("openclaw-skills-repo-");
 
-    for (let i = 0; i < 20; i += 1) {
+    for (let i = 0; i < 8; i += 1) {
       const name = `repo-skill-${String(i).padStart(2, "0")}`;
       await writeSkill({
         dir: path.join(repoDir, "skills", name),
@@ -135,26 +150,28 @@ describe("buildWorkspaceSkillSnapshot", () => {
       });
     }
 
-    const snapshot = buildWorkspaceSkillSnapshot(workspaceDir, {
-      config: {
-        skills: {
-          load: {
-            extraDirs: [repoDir],
-          },
-          limits: {
-            maxCandidatesPerRoot: 5,
-            maxSkillsLoadedPerSource: 5,
+    const snapshot = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillSnapshot(workspaceDir, {
+        config: {
+          skills: {
+            load: {
+              extraDirs: [repoDir],
+            },
+            limits: {
+              maxCandidatesPerRoot: 5,
+              maxSkillsLoadedPerSource: 5,
+            },
           },
         },
-      },
-      managedSkillsDir: path.join(workspaceDir, ".managed"),
-      bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-    });
+        managedSkillsDir: path.join(workspaceDir, ".managed"),
+        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
+      }),
+    );
 
     // We should only have loaded a small subset.
     expect(snapshot.skills.length).toBeLessThanOrEqual(5);
     expect(snapshot.prompt).toContain("repo-skill-00");
-    expect(snapshot.prompt).not.toContain("repo-skill-19");
+    expect(snapshot.prompt).not.toContain("repo-skill-07");
   });
 
   it("skips skills whose SKILL.md exceeds maxSkillFileBytes", async () => {
@@ -170,20 +187,22 @@ describe("buildWorkspaceSkillSnapshot", () => {
       dir: path.join(workspaceDir, "skills", "big-skill"),
       name: "big-skill",
       description: "Big",
-      body: "x".repeat(50_000),
+      body: "x".repeat(5_000),
     });
 
-    const snapshot = buildWorkspaceSkillSnapshot(workspaceDir, {
-      config: {
-        skills: {
-          limits: {
-            maxSkillFileBytes: 1000,
+    const snapshot = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillSnapshot(workspaceDir, {
+        config: {
+          skills: {
+            limits: {
+              maxSkillFileBytes: 1000,
+            },
           },
         },
-      },
-      managedSkillsDir: path.join(workspaceDir, ".managed"),
-      bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-    });
+        managedSkillsDir: path.join(workspaceDir, ".managed"),
+        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
+      }),
+    );
 
     expect(snapshot.skills.map((s) => s.name)).toContain("small-skill");
     expect(snapshot.skills.map((s) => s.name)).not.toContain("big-skill");
@@ -208,21 +227,23 @@ describe("buildWorkspaceSkillSnapshot", () => {
       description: "Nested skill discovered late",
     });
 
-    const snapshot = buildWorkspaceSkillSnapshot(workspaceDir, {
-      config: {
-        skills: {
-          load: {
-            extraDirs: [repoDir],
-          },
-          limits: {
-            maxCandidatesPerRoot: 30,
-            maxSkillsLoadedPerSource: 30,
+    const snapshot = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillSnapshot(workspaceDir, {
+        config: {
+          skills: {
+            load: {
+              extraDirs: [repoDir],
+            },
+            limits: {
+              maxCandidatesPerRoot: 30,
+              maxSkillsLoadedPerSource: 30,
+            },
           },
         },
-      },
-      managedSkillsDir: path.join(workspaceDir, ".managed"),
-      bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-    });
+        managedSkillsDir: path.join(workspaceDir, ".managed"),
+        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
+      }),
+    );
 
     expect(snapshot.skills.map((s) => s.name)).toContain("late-skill");
     expect(snapshot.prompt).toContain("late-skill");
@@ -236,23 +257,25 @@ describe("buildWorkspaceSkillSnapshot", () => {
       dir: rootSkillDir,
       name: "root-big-skill",
       description: "Big",
-      body: "x".repeat(50_000),
+      body: "x".repeat(5_000),
     });
 
-    const snapshot = buildWorkspaceSkillSnapshot(workspaceDir, {
-      config: {
-        skills: {
-          load: {
-            extraDirs: [rootSkillDir],
-          },
-          limits: {
-            maxSkillFileBytes: 1000,
+    const snapshot = withWorkspaceHome(workspaceDir, () =>
+      buildWorkspaceSkillSnapshot(workspaceDir, {
+        config: {
+          skills: {
+            load: {
+              extraDirs: [rootSkillDir],
+            },
+            limits: {
+              maxSkillFileBytes: 1000,
+            },
           },
         },
-      },
-      managedSkillsDir: path.join(workspaceDir, ".managed"),
-      bundledSkillsDir: path.join(workspaceDir, ".bundled"),
-    });
+        managedSkillsDir: path.join(workspaceDir, ".managed"),
+        bundledSkillsDir: path.join(workspaceDir, ".bundled"),
+      }),
+    );
 
     expect(snapshot.skills.map((s) => s.name)).not.toContain("root-big-skill");
     expect(snapshot.prompt).not.toContain("root-big-skill");