github/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-05-08 04:11:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: make windows CI path handling deterministic

Browse Source
This commit is contained in:
Peter Steinberger
2026-02-22 22:34:42 +00:00
parent 3b0e62d5bf
commit 84e5ab598a
3 changed files with 59 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/infra/exec-safe-bin-runtime-policy.test.ts
View File

@@ -1,3 +1,4 @@
import path from "node:path";
import { describe, expect, it } from "vitest";
import {
isInterpreterLikeSafeBin,
@@ -72,16 +73,18 @@ describe("exec safe-bin runtime policy", () => {
});
it("merges explicit safe-bin trusted dirs from global and local config", () => {
const customDir = path.join(path.sep, "custom", "bin");
const agentDir = path.join(path.sep, "agent", "bin");
const policy = resolveExecSafeBinRuntimePolicy({
global: {
safeBinTrustedDirs: [" /custom/bin ", "/custom/bin"],
safeBinTrustedDirs: [` ${customDir} `, customDir],
},
local: {
safeBinTrustedDirs: ["/agent/bin"],
safeBinTrustedDirs: [agentDir],
},
});
expect(policy.trustedSafeBinDirs.has("/custom/bin")).toBe(true);
expect(policy.trustedSafeBinDirs.has("/agent/bin")).toBe(true);
expect(policy.trustedSafeBinDirs.has(path.resolve(customDir))).toBe(true);
expect(policy.trustedSafeBinDirs.has(path.resolve(agentDir))).toBe(true);
});
});

20
src/infra/install-flow.test.ts
View File

@@ -51,17 +51,19 @@ describe("withExtractedArchiveRoot", () => {
});
it("extracts archive and passes root directory to callback", async () => {
const tmpRoot = path.join(path.sep, "tmp", "openclaw-install-flow");
const archivePath = path.join(path.sep, "tmp", "plugin.tgz");
const extractDir = path.join(tmpRoot, "extract");
const packageRoot = path.join(extractDir, "package");
const withTempDirSpy = vi
.spyOn(installSource, "withTempDir")
.mockImplementation(async (_prefix, fn) => await fn("/tmp/openclaw-install-flow"));
.mockImplementation(async (_prefix, fn) => await fn(tmpRoot));
const extractSpy = vi.spyOn(archive, "extractArchive").mockResolvedValue(undefined);
const resolveRootSpy = vi
.spyOn(archive, "resolvePackedRootDir")
.mockResolvedValue("/tmp/openclaw-install-flow/extract/package");
const resolveRootSpy = vi.spyOn(archive, "resolvePackedRootDir").mockResolvedValue(packageRoot);
const onExtracted = vi.fn(async (rootDir: string) => ({ ok: true as const, rootDir }));
const result = await withExtractedArchiveRoot({
archivePath: "/tmp/plugin.tgz",
archivePath,
tempDirPrefix: "openclaw-plugin-",
timeoutMs: 1000,
onExtracted,
@@ -70,14 +72,14 @@ describe("withExtractedArchiveRoot", () => {
expect(withTempDirSpy).toHaveBeenCalledWith("openclaw-plugin-", expect.any(Function));
expect(extractSpy).toHaveBeenCalledWith(
expect.objectContaining({
archivePath: "/tmp/plugin.tgz",
archivePath,
}),
);
expect(resolveRootSpy).toHaveBeenCalledWith("/tmp/openclaw-install-flow/extract");
expect(onExtracted).toHaveBeenCalledWith("/tmp/openclaw-install-flow/extract/package");
expect(resolveRootSpy).toHaveBeenCalledWith(extractDir);
expect(onExtracted).toHaveBeenCalledWith(packageRoot);
expect(result).toEqual({
ok: true,
rootDir: "/tmp/openclaw-install-flow/extract/package",
rootDir: packageRoot,
});
});